From: Carl Lee <qq1145099@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Charles Hsu <ythsu0511@gmail.com>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, peter.shen@amd.com,
colin.huang2@amd.com
Subject: Re: [PATCH v2 1/3] dt-bindings: hwmon: pmbus: mpq8785: add MPQ8786 support
Date: Fri, 6 Feb 2026 14:46:28 +0800 [thread overview]
Message-ID: <aYWORPv2goAEfIgt@carl-amd> (raw)
In-Reply-To: <79a6a2bc-4894-4ff9-8a11-5ed71195cf09@roeck-us.net>
On Thu, Feb 05, 2026 at 08:17:07AM -0800, Guenter Roeck wrote:
> On Thu, Feb 05, 2026 at 02:46:29PM +0100, Krzysztof Kozlowski wrote:
> > On Thu, Feb 05, 2026 at 06:01:37PM +0800, Carl Lee wrote:
> > > Add device type support for MPQ8786
> > >
> > > Signed-off-by: Carl Lee <carl.lee@amd.com>
> > > ---
> > > Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml | 5 ++++-
> > > 1 file changed, 4 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml
> > > index 90970a0433e9..aec7397a29f9 100644
> > > --- a/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml
> > > +++ b/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml
> > > @@ -19,6 +19,7 @@ properties:
> > > - mps,mpm3695-25
> > > - mps,mpm82504
> > > - mps,mpq8785
> > > + - mps,mpq8786
> >
> > Your driver code says they are the same, so compatible. Express it with
> > fallback or provide real rationale in commit msg.
> >
>
> Agreed. The mpq8785 datasheet is public, but the mpq8786 datasheet isn't.
> That makes it all but impossible to determine if there are indeed no
> notable differences between the chips.
>
> Guenter
There is no chip-specific difference in the driver code to justify
separate MPQ8786 support.
Therefore, Therefore, I will use MPQ8785 for support.
next prev parent reply other threads:[~2026-02-06 6:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-05 10:01 [PATCH v2 0/3] hwmon: pmbus: Add support for MPQ8786 Carl Lee via B4 Relay
2026-02-05 10:01 ` [PATCH v2 1/3] dt-bindings: hwmon: pmbus: mpq8785: add MPQ8786 support Carl Lee via B4 Relay
2026-02-05 13:46 ` Krzysztof Kozlowski
2026-02-05 16:17 ` Guenter Roeck
2026-02-06 5:54 ` Carl Lee
2026-02-06 6:41 ` Carl Lee
2026-02-06 6:46 ` Carl Lee [this message]
2026-02-07 11:07 ` Krzysztof Kozlowski
2026-02-05 10:01 ` [PATCH v2 2/3] hwmon: pmbus: mpq8785: add support for MPQ8786 Carl Lee via B4 Relay
2026-02-05 10:01 ` [PATCH v2 3/3] hwmon: pmbus: mpq8785: force direct mode for VID VOUT on MPQ8785/MPQ8786 Carl Lee via B4 Relay
2026-02-05 16:58 ` Guenter Roeck
[not found] ` <aYl+pTlG9rEuE59h@carl-amd>
2026-02-09 15:44 ` Guenter Roeck
2026-02-05 17:46 ` Guenter Roeck
2026-02-09 6:53 ` Carl Lee
2026-02-07 11:04 ` kernel test robot
2026-02-07 11:15 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYWORPv2goAEfIgt@carl-amd \
--to=qq1145099@gmail.com \
--cc=colin.huang2@amd.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=peter.shen@amd.com \
--cc=robh@kernel.org \
--cc=ythsu0511@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox