From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: David Laight <david.laight.linux@gmail.com>
Cc: Dmitry Antipov <dmantipov@yandex.ru>,
Andrew Morton <akpm@linux-foundation.org>,
Kees Cook <kees@kernel.org>,
"Darrick J . Wong" <djwong@kernel.org>,
linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/5] lib: fix _parse_integer_limit() to handle overflow
Date: Fri, 6 Feb 2026 09:42:40 +0200 [thread overview]
Message-ID: <aYWbcFb73qO16tEC@smile.fi.intel.com> (raw)
In-Reply-To: <20260205221537.34778ff0@pumpkin>
On Thu, Feb 05, 2026 at 10:15:37PM +0000, David Laight wrote:
> On Wed, 4 Feb 2026 16:57:13 +0300
> Dmitry Antipov <dmantipov@yandex.ru> wrote:
...
> Although I wonder whether strtoul() (etc) should stop 'eating' input
> when the value would overflow
Definitely no stop condition. The idea behind simple_strto*() in the kernel
is that they will help to parse combined strings (several fields in one
*constant* string), not eating the extra "valid" characters (digits) will
be a disaster in a couple of aspects.
> and return a pointer to the digit that caused the error.
No.
> Code looking at the terminating character wont be expecting a digit
> and will treat it as a syntax error - which is what you are trying to do.
>
> That is a much easier API to use, and a 'drop-in' for existing code.
Maybe, but problematic from the usage point of view as I described above.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-02-06 7:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-04 13:57 [PATCH v5 0/5] lib and lib/cmdline enhancements Dmitry Antipov
2026-02-04 13:57 ` [PATCH v5 1/5] lib: fix _parse_integer_limit() to handle overflow Dmitry Antipov
2026-02-04 14:31 ` Andy Shevchenko
2026-02-05 9:04 ` Dmitry Antipov
2026-02-05 16:03 ` Andy Shevchenko
2026-02-05 22:15 ` David Laight
2026-02-06 7:42 ` Andy Shevchenko [this message]
2026-02-06 9:53 ` Dmitry Antipov
2026-02-06 10:11 ` Andy Shevchenko
2026-02-04 13:57 ` [PATCH v5 2/5] lib: fix memparse() " Dmitry Antipov
2026-02-04 14:42 ` Andy Shevchenko
2026-02-05 9:17 ` Dmitry Antipov
2026-02-05 16:05 ` Andy Shevchenko
2026-02-04 13:57 ` [PATCH v5 3/5] lib: add more string to 64-bit integer conversion overflow tests Dmitry Antipov
2026-02-04 13:57 ` [PATCH v5 4/5] lib/cmdline_kunit: add test case for memparse() Dmitry Antipov
2026-02-04 13:57 ` [PATCH v5 5/5] lib/cmdline: adjust a few comments to fix kernel-doc -Wreturn warnings Dmitry Antipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYWbcFb73qO16tEC@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=akpm@linux-foundation.org \
--cc=david.laight.linux@gmail.com \
--cc=djwong@kernel.org \
--cc=dmantipov@yandex.ru \
--cc=kees@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox