From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F2A3346AD6; Fri, 6 Feb 2026 08:27:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770366444; cv=none; b=b3IddjGSg9g+EsxhUYNxT6aEDKvpjMOpK5H/PXd4YwcEv5sMxQC87bnfJeD+0pYwT/d341TkBUAYQIRxgdaGIw3OQG8vjW6LbvXy3oY113nBIVPmCXsb5vcQ8yT6MarfL1D2+Fvc3ATLgeJjijuZPfujExS25l19sczfmfZURlY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770366444; c=relaxed/simple; bh=hFLsbylF6p6A9KUqjQvFLetTNZX+wdgm8GS3pPMp/0Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TKRMnE4HSfPOru+hNemAbdmkMTFgqb1hxPndx+I5BDQJ5PaNDhfdbefMzPCy7DMjaPHqjBWOSkjoRyWrl2IczxzSdTzhIBU7Fg2OkYUUCbTRcSDtRyvIDmvGV8My1P274H3T2aH6wPKURZ/rDtHB459+fCGvFxpZ07D9aUHfgnQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HoCgSWJA; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HoCgSWJA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A422FC116C6; Fri, 6 Feb 2026 08:27:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770366444; bh=hFLsbylF6p6A9KUqjQvFLetTNZX+wdgm8GS3pPMp/0Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HoCgSWJAYnZUO2RoEREhCOmqxkrfsTnico+svE9PZ4e5ZgE6qDRHJUIMkD0SPNv81 sbXDlzaI+E8QDKgXtzNCY5OXB0XjscNWGPd+vslG87ViPT76tsk5tlO/JhYq/TNBjC LrPVTibxAI15pjfkrloKkB2vOCkhT6M1PoO0iPW5ZIBTOpSSjX7CIblB4NEreb33Fl F+tFDdZ0O1gA72VaCCrqdlwsKNHVCSxfyZawTZol/9Tvpf/gvQccBwzySk6moMNALo 0cosaWjVJOsjV6oIszz2lukfUjdK/nl+/Kem+5ZwQi29WdJvmt8lt4yM1gMZNHeLOw H27972wgdI63g== Date: Fri, 6 Feb 2026 09:25:30 +0100 From: Nicolas Schier To: Thomas =?iso-8859-1?Q?Wei=DFschuh?= Cc: Nathan Chancellor , Arnd Bergmann , Luis Chamberlain , Petr Pavlu , Sami Tolvanen , Daniel Gomez , Paul Moore , James Morris , "Serge E. Hallyn" , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Naveen N Rao , Mimi Zohar , Roberto Sassu , Dmitry Kasatkin , Eric Snowberg , Daniel Gomez , Aaron Tomlin , "Christophe Leroy (CS GROUP)" , Nicolas Bouchinet , Xiu Jianfeng , Fabian =?iso-8859-1?Q?Gr=FCnbichler?= , Arnout Engelen , Mattia Rizzolo , kpcyrd , Christian Heusel , =?iso-8859-1?Q?C=E2ju?= Mihai-Drosi , Sebastian Andrzej Siewior , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-modules@vger.kernel.org, linux-security-module@vger.kernel.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-integrity@vger.kernel.org Subject: Re: [PATCH v4 03/17] ima: efi: Drop unnecessary check for CONFIG_MODULE_SIG/CONFIG_KEXEC_SIG Message-ID: Mail-Followup-To: Nicolas Schier , Thomas =?iso-8859-1?Q?Wei=DFschuh?= , Nathan Chancellor , Arnd Bergmann , Luis Chamberlain , Petr Pavlu , Sami Tolvanen , Daniel Gomez , Paul Moore , James Morris , "Serge E. Hallyn" , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Naveen N Rao , Mimi Zohar , Roberto Sassu , Dmitry Kasatkin , Eric Snowberg , Daniel Gomez , Aaron Tomlin , "Christophe Leroy (CS GROUP)" , Nicolas Bouchinet , Xiu Jianfeng , Fabian =?iso-8859-1?Q?Gr=FCnbichler?= , Arnout Engelen , Mattia Rizzolo , kpcyrd , Christian Heusel , =?iso-8859-1?Q?C=E2ju?= Mihai-Drosi , Sebastian Andrzej Siewior , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-modules@vger.kernel.org, linux-security-module@vger.kernel.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-integrity@vger.kernel.org References: <20260113-module-hashes-v4-0-0b932db9b56b@weissschuh.net> <20260113-module-hashes-v4-3-0b932db9b56b@weissschuh.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260113-module-hashes-v4-3-0b932db9b56b@weissschuh.net> X-TUID: awWjl2+9zWWD On Tue, Jan 13, 2026 at 01:28:47PM +0100, Thomas Weißschuh wrote: > When configuration settings are disabled the guarded functions are > defined as empty stubs, so the check is unnecessary. > The specific configuration option for set_module_sig_enforced() is > about to change and removing the checks avoids some later churn. > > Signed-off-by: Thomas Weißschuh > --- > security/integrity/ima/ima_efi.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > Reviewed-by: Nicolas Schier -- Nicolas