From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D29AF3D9024 for ; Fri, 6 Feb 2026 13:41:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.65 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770385283; cv=none; b=aya0WgW6MU0+I40HC5bLdK4Iv+eNc6DHCFmt3hSWN2XTA5q2fqlX9RulkO5nhkRKO1v0N+tkAXO4SOgl9MOr8RY/RMzAH2lQDSMmIOUSCbMmp0DxZ4fshAZzpa7bqCqhFQLb17udZLnxoNWokq+Nh6w3btRmKzhFobG8VAI+P14= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770385283; c=relaxed/simple; bh=d1Fc3qjMK07ZIjos2W+qQST8uvOeBj22r2znJ8orYdI=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=R4tBzb7FKcgg0DKu7C7qNxKIe1JLaifTEuuNkJT1vr3M4NkReJ+69WkNzpbvFox00/UoP0StC/naOkbLVndU449ugBTz5Tj4x/+jB5hAnWv0+FkluSminiVdp1P2OtPVwAbxfnCD45p95hgXR3mVLI9B6B7NiKxqRo26p8PphGo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=t48MWUcy; arc=none smtp.client-ip=209.85.128.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="t48MWUcy" Received: by mail-wm1-f65.google.com with SMTP id 5b1f17b1804b1-4806bf03573so3918725e9.2 for ; Fri, 06 Feb 2026 05:41:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770385281; x=1770990081; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=zfBsG/ENCKfWi97pteJC8UgQBfR+tgoV52ZMJOZPJrM=; b=t48MWUcyV1u9hHD1Q3dHic5e/fImB01eL9LQrN+pcEk4IzHfevyhI/vNfI0ZmYplu2 m4Iz4G7idLfLTGVor+x/RfHO7cnNKUKW8VSb/q+7QLXf5T4+v2Vla7F+sj+aTQ9BJQ7j 6wWeTmIW1FTRdU2UNWxo98FTxkgCVdN47XfQ7ifPRCthLTnKJhPRBPn0BOmnSrWRy/mG 40wrmTX9LR3yZCWARgA5imJxX82BavElW/QzE15FUDSgUdeyQ8So6tMl6O2cpwTdX8Lr CLUvRddGtxub0mmXZVy0AYJFbHT3/Uf8mxfn3OHOMmO9X+nVX5ii4P3IQTcs7x5bZSrE JRBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770385281; x=1770990081; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zfBsG/ENCKfWi97pteJC8UgQBfR+tgoV52ZMJOZPJrM=; b=dShTGsLoUrD4/4/Vk0+E/uLcqxOLNtNRYfY6pJ0D+xfJarD2oaSPmvShhJ6TsSotA4 BKANc4KQ0aBXxSbkTO+Lih1ckxUnyz9DH37kDNz2Xy/8Ee8nlFl3ud8SAbZg9j7F2Ja9 XhAvqA38f/fQlidb1NBx8uIQMymVu8w+6HiVymI2oGc2rlap2DcuFpYgyTcS+VIh+AzJ CS1ImsyK5cD23/XniYEyifvJQzUK9xTwoxgJEZQZVzZ7RCkXyEWxVCOG0jEpgTbqLoxS WDu5MaG6AgdB+KxeOEJJK18vBhiKDeEbHCYp1bdzpVkrVdf1ZomBnWBSBtWB1OGMANai uosA== X-Gm-Message-State: AOJu0Yw9QkuQNzVVnOywvZq3j3xnYeiwjOlQ91DmTSDK+2NXD3kRpN+V PQXoY1h1WiHxp4dQOqFJy1vV4Vi1lxO38OQhLyORgp6FQAJ2w0Ue+BVAj/GdoVcCMB0= X-Gm-Gg: AZuq6aL7/R29Uox08lR0lEEKfg9C+0wsErn+FKznXOLydflQdneyNjxOde2EJ3DxAxe Q5XzhoUNUlGk49g6/NRckEo9weO7g3QTyda3YbJOCpP/Sc9aQPKC4zREojOyXW5m+M/exehEyHT ricYqMNU1cEQzAFG3rB04pJ6CC6sMLdou+fBsu0P/aFuI6bYY+wZ7SFMrfLBnXjeNjurSIGjXCf VSDjjNhPHiy+xKJzmrfnIDpWPlBqO7/WUTf7RL5zi+1OTr7AoxDEWDwUs5/BKkCOnKtE+exxROH zxUgtP4PoIjzMfeAmSovEP6uBzumy8vA/DoRsybLY2WXe0tuk0xdfoxD5N+DnDtaCmLpYXblA1c J96Zg+/zi8n9T3lyp94f5cpZteBBqVrkxSHmDYUC006X7Vd+zL3+zoi8lSU+tikkQ80wvFC6EmB PXDX4FubVfRhGgWMm9 X-Received: by 2002:a05:600c:1549:b0:477:582e:7a81 with SMTP id 5b1f17b1804b1-483201da21bmr39901045e9.4.1770385281163; Fri, 06 Feb 2026 05:41:21 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483179dbdcfsm161783045e9.0.2026.02.06.05.41.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Feb 2026 05:41:20 -0800 (PST) Date: Fri, 6 Feb 2026 16:41:17 +0300 From: Dan Carpenter To: Ioana Ciornei Cc: linux-kernel Subject: [bug report] irqchip/ls-extirq: Convert to a platform driver to make it work again Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: [ Smatch checking is paused while we raise funding. #SadFace https://lore.kernel.org/all/aTaiGSbWZ9DJaGo7@stanley.mountain/ -dan ] Hello Ioana Ciornei, Commit 05cd654829dd ("irqchip/ls-extirq: Convert to a platform driver to make it work again") from Jan 22, 2026 (linux-next), leads to the following Smatch static checker warning: drivers/irqchip/irq-ls-extirq.c:180 ls_extirq_probe() warn: 'priv->intpcr' is an error pointer or valid drivers/irqchip/irq-ls-extirq.c 158 static int ls_extirq_probe(struct platform_device *pdev) 159 { 160 struct irq_domain *domain, *parent_domain; 161 struct device_node *node, *parent; 162 struct device *dev = &pdev->dev; 163 struct ls_extirq_data *priv; 164 int ret; 165 166 node = dev->of_node; 167 parent = of_irq_find_parent(node); 168 if (!parent) 169 return dev_err_probe(dev, -ENODEV, "Failed to get IRQ parent node\n"); 170 171 parent_domain = irq_find_host(parent); 172 if (!parent_domain) 173 return dev_err_probe(dev, -EPROBE_DEFER, "Cannot find parent domain\n"); 174 175 priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); 176 if (!priv) 177 return dev_err_probe(dev, -ENOMEM, "Failed to allocate memory\n"); 178 179 priv->intpcr = devm_of_iomap(dev, node, 0, NULL); --> 180 if (!priv->intpcr) This should be an IS_ERR() check. 181 return dev_err_probe(dev, -ENOMEM, "Cannot ioremap OF node %pOF\n", node); 182 183 ret = ls_extirq_parse_map(priv, node); 184 if (ret) 185 return dev_err_probe(dev, ret, "Failed to parse IRQ map\n"); 186 187 priv->big_endian = of_device_is_big_endian(node->parent); 188 priv->is_ls1021a_or_ls1043a = of_device_is_compatible(node, "fsl,ls1021a-extirq") || 189 of_device_is_compatible(node, "fsl,ls1043a-extirq"); 190 raw_spin_lock_init(&priv->lock); 191 192 domain = irq_domain_create_hierarchy(parent_domain, 0, priv->nirq, of_fwnode_handle(node), 193 &extirq_domain_ops, priv); 194 if (!domain) 195 return dev_err_probe(dev, -ENOMEM, "Failed to add IRQ domain\n"); 196 197 return 0; 198 } regards, dan carpenter