From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 932393EF0D7 for ; Fri, 6 Feb 2026 13:41:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.67 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770385286; cv=none; b=UceiGzo7uxLmIASUiw8fwh9bbhTgm0sAEVONo8/wVPSJrk05tx8Ukw5l4p3Wx/K3F0SFzTJJdveIYdr+P1xgk9Zu5z7gas+opybebOMENb8deWzUCtatUvazDeRboGuyguHvtsik1pmZCN8dG6DiurSg06eCrIALNL6j33MzkVU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770385286; c=relaxed/simple; bh=gDywjJacYZsMcwrC3XauhgSNjnoscYFcwbigyK6yv6I=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=HLgNrKNtifsaNiURoy9TtAaFsfnewLu2niCDfA5vUhogI/MrNCcOkQ5+tIuYzh7DVVY+FGYoU/8CmoDiXWE+Cd84NNVhQMlQK0hYTQ1+O/ouoTdEfcchRUqAz8Mxmi0kbFtl7keV6KYDH2I2ewQ5Au1aOZVutEWK2ffjt9J/zrM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=dV53Aq+V; arc=none smtp.client-ip=209.85.221.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="dV53Aq+V" Received: by mail-wr1-f67.google.com with SMTP id ffacd0b85a97d-4362507f0feso908289f8f.0 for ; Fri, 06 Feb 2026 05:41:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770385285; x=1770990085; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=LCL1DbowgJz3KhWgEdjSYavXvn767FPhfGqyYV8f3No=; b=dV53Aq+VPwHRCsWtZ0Tn0mQhp52Dd5M+B5JNT77L/QBDTwRgZ7GdebfxuYWq3V8SEi ZDpbnyq01KC9DHluTnjWhozqnTfBwVPCZB1kPo5VD4MGTfcETGZS1HNid0xafZBqTO22 4akD8ceB/I5ngFw5ZUDKM/0LGm33jt/m/BBEklEboa43CKcHMBRlbQ3hMojrIJpukCbm 9rotjpzWBaaEormBJ9m97pT9NR+LnPXY0gL65WTSegh5XQ9ajnJcToGypVAjZlPvoIZy XeTBSYSXtZYZFancAo3liM5LsZElkPsmiiFh7/1Z895RtFmkaMFjN50ZSpE8QAbu41MD 4Vdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770385285; x=1770990085; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LCL1DbowgJz3KhWgEdjSYavXvn767FPhfGqyYV8f3No=; b=sWwMlAfDyqYvKvO0mzPtZApZlFiQRCWvbxW3Kt8YB4L1F+bdtYK3aNUPhA7Bchfdqe ftR2ewuOSiuQoarpcVY2I8ivjDDZXtSDtSz9nNDu4JAxTYa4TjXqtVymjmIOBq8yzBe7 XG1WWtTbOVOKFVr8C1aoi/xD+sPkt5e2qFu9Le0W2m2Cc+dGkVrAdxdvMI4T+ZqFxgAv SW9o5me6IegpydbxDAFQnycAyEdMiA3d0qT4jVZ9V4oMzHIjmoklxXj3icGvkZi9eMLQ p3625KpcCFZ41rS53ST7MNllIHo0et9ksGyNx3IabAX5wsGsYBZ0XQYwbVTrCn9m2cHd 2nYA== X-Forwarded-Encrypted: i=1; AJvYcCV363QUMDPpS0f8pbxxDtYsyol1s1CyOb6CNhy7smG8JOdbRPIi5FSunPTilocLOXZxUyVlJrjQHirvrAE=@vger.kernel.org X-Gm-Message-State: AOJu0YzsMo0LAyTQgIIcY38o5PoMPyxBYRqcxljIkzLR/Pm2QPaIpLRA qEywg1f5lFyzgAFjOhefXgYfzRrnCylE9ak4f4ArbHUl3VrQXHsG9hS8WMDEsCqgtvw= X-Gm-Gg: AZuq6aL4x4JCKYddSMVBn0FaOOktK6wjm2kxUKhz0FtpaQBeohWDmaAyLx3/ThiYjue 6csdFjDde8jZPBGqRFcjMQi4z1nsRKMSIIAw/BiDVR20CngUECWYJvnVjDrMfWJSmip7FVW0yOR mwqqsdm/BiYqPHBMlVSDbbdjry9ywrxrM0KCSDeuRv+aIoTo6cttEQqFsh3FV/oiM3qj+P//s6V 429uCOpekCADlOPbAWeCUM3XjWUc8xNWnx1ccEYEXqul54lALu59yhU/5AKQxKJQb0wDEd96r6x YUzpGVS6Ob1UuKb51JXr15JrOiIsOugL9BjycUNnN93Y+44TNQwitXDw2HKk7HgtQkqWC420Ujk YsFssBsCrCb4du6MRfEiHpTCe9yH9nio9mvLFcTTpCl2mVTF9+La3OhM0CSksmmPd0Ia30k/xmp +8CI+B+FvP2TXg8LyA X-Received: by 2002:a05:6000:240e:b0:431:752:671e with SMTP id ffacd0b85a97d-436293422d4mr4829014f8f.15.1770385284981; Fri, 06 Feb 2026 05:41:24 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43629730992sm5455993f8f.21.2026.02.06.05.41.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Feb 2026 05:41:24 -0800 (PST) Date: Fri, 6 Feb 2026 16:41:21 +0300 From: Dan Carpenter To: Shawn Lin Cc: linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel Subject: [bug report] soc: rockchip: grf: Support multiple grf to be handled Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: [ Smatch checking is paused while we raise funding. #SadFace https://lore.kernel.org/all/aTaiGSbWZ9DJaGo7@stanley.mountain/ -dan ] Hello Shawn Lin, Commit 75fb63ae0312 ("soc: rockchip: grf: Support multiple grf to be handled") from Jan 16, 2026 (linux-next), leads to the following Smatch static checker warning: drivers/soc/rockchip/grf.c:249 rockchip_grf_init() warn: inconsistent refcounting 'np->kobj.kref.refcount.refs.counter': drivers/soc/rockchip/grf.c 212 static int __init rockchip_grf_init(void) 213 { 214 const struct rockchip_grf_info *grf_info; 215 const struct of_device_id *match; 216 struct device_node *np; 217 struct regmap *grf; 218 int ret, i; 219 220 for_each_matching_node_and_match(np, rockchip_grf_dt_match, &match) { 221 if (!of_device_is_available(np)) 222 continue; 223 if (!match || !match->data) { 224 pr_err("%s: missing grf data\n", __func__); 225 of_node_put(np); 226 return -EINVAL; 227 } 228 229 grf_info = match->data; 230 231 grf = syscon_node_to_regmap(np); 232 if (IS_ERR(grf)) { 233 pr_err("%s: could not get grf syscon\n", __func__); 234 return PTR_ERR(grf); Missing of_node_put(np) before returning. 235 } 236 237 for (i = 0; i < grf_info->num_values; i++) { 238 const struct rockchip_grf_value *val = &grf_info->values[i]; 239 240 pr_debug("%s: adjusting %s in %#6x to %#10x\n", __func__, 241 val->desc, val->reg, val->val); 242 ret = regmap_write(grf, val->reg, val->val); 243 if (ret < 0) 244 pr_err("%s: write to %#6x failed with %d\n", 245 __func__, val->reg, ret); 246 } 247 } 248 249 return 0; 250 } regards, dan carpenter