From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f202.google.com (mail-pl1-f202.google.com [209.85.214.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 474222DB781 for ; Fri, 6 Feb 2026 17:58:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770400739; cv=none; b=qgtBjrjOg5lSreiXwkWEoIUVnR1RRdmsCdTfTblsWX5upU+t4hcTzoYKxz4FToFXA1D6luSwPilTK7Jc2Tah+SrGVw9+gkLKzw2JA8cSLe8zmiwbetzMi9IjcoCjy7fqaCMLcWLgreoKImitXcUAAjt76SMpqa4117ivqD7rqnE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770400739; c=relaxed/simple; bh=8d1BD4eF30+KyWgVRBOma68bMrR8sNdqhiQDUmpNgpM=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=IeeGEreKverWmJKbBTrFMx9pJJq2wLk8wg+VasIArjfqhTDD7me7slijT5GN2BNcW1WZaP0ZZT3o48Q4S5uB79SNKlZ5XpFONKQ9wbqN2NmlvxHwYe2/ukNDCw1BjAkWUK+EMl9G/51F6zHvCPrnWnBvkBqBF+ZHCMyGimDC2tA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=lLSI8Pi4; arc=none smtp.client-ip=209.85.214.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="lLSI8Pi4" Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-2a943e214daso55963005ad.3 for ; Fri, 06 Feb 2026 09:58:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1770400739; x=1771005539; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=Njl6WISo/cIP/yX5hq9KMqO4jpKhLSD8WrbMSm0p7fU=; b=lLSI8Pi4MNI9wZxAain+SMlxBsUL2lidYR6rX0PGVDS7JAfKxH9zkWGcBLroIA/uDf WhaMZs9D0+jaGKhEATGpQBZbhZFqlwDbCtt5dR0XT7I1NCK9JSW7k/XV6babBKizFcIF /4BXviohFEWC/U48rOU/iuenE+HQvwlpkjzGg7bqQTMG9oM+Xx/TetB2D1XVIV02Cr2T oUKi4TUNHJBog+wGoyO53LBOf2HWcU/xyHSrhV5zGCuBG4zLnGN3ILb89DyI9vRvVbnd NH9qBbKMePPhFzRDYjw1UKdUa+UV5szLQlH4wmB0XGA9AbDyjtnAOhtjuRs26T5IXuAW tgKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770400739; x=1771005539; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Njl6WISo/cIP/yX5hq9KMqO4jpKhLSD8WrbMSm0p7fU=; b=PxEpb/QpXsTNT78VK2pZyZQy+/B75flIAqbWrMz0ywV714K7vXs7l1BBvv95R+Wd2K GJuQIB4ouFp/aW3XyMxFO/q6Wbptr3SxQ3CXLEuoFVbYNwWb2PqtZgFtjQ1wR/uMwjTy +ITWknWxeKbvHqZCaockm5Iudjd8FM9oY6DufSw2RLZ9TrM/zDMuTkiw8lV8K72pPqsr jboCh9DrA6YELGkMC7EXOyQ9T0ff9CYvAVaGyggQ4a456ZvMHKlRlLpdtguk7mkK4v90 vzo3tEYIqami29nFxFru+TGGzJIKF2YMhtEEsuqbY5pFw7EthGl0NQpF8IaX+4mmrcTw YniA== X-Forwarded-Encrypted: i=1; AJvYcCXpxBGoziPFRVCCsIEpJpsVw7B7u4XfJO990IYS5dRUCC1OX1HTV/6CXgcFtenCAdDfVoYUpq3hNAXf8tA=@vger.kernel.org X-Gm-Message-State: AOJu0YxTP4jjVnAC34EC+734mTKfv2crHVoLRJcXxlt5qg0ANIRse665 uSq4L1N9LtdknA5EeuZcoVhCHI9sC9GDPBFqmOcOxTEvMxWX3ExBQgLSiJ3tHhHWLMihOyVQSm5 qb5MQCQ== X-Received: from plcb1.prod.google.com ([2002:a17:902:d301:b0:2a0:81d1:64f4]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:e947:b0:2a0:b066:3f55 with SMTP id d9443c01a7336-2a951605e26mr31266215ad.10.1770400738628; Fri, 06 Feb 2026 09:58:58 -0800 (PST) Date: Fri, 6 Feb 2026 09:58:57 -0800 In-Reply-To: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260115011312.3675857-1-yosry.ahmed@linux.dev> <20260115011312.3675857-22-yosry.ahmed@linux.dev> Message-ID: Subject: Re: [PATCH v4 21/26] KVM: SVM: Rename vmcb->virt_ext to vmcb->misc_ctl2 From: Sean Christopherson To: Yosry Ahmed Cc: Paolo Bonzini , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" On Fri, Feb 06, 2026, Yosry Ahmed wrote: > On Thu, Feb 05, 2026 at 05:31:01PM -0800, Sean Christopherson wrote: > > On Thu, Jan 15, 2026, Yosry Ahmed wrote: > > > @@ -244,6 +241,8 @@ struct __attribute__ ((__packed__)) vmcb_control_area { > > > #define SVM_MISC_CTL_SEV_ENABLE BIT(1) > > > #define SVM_MISC_CTL_SEV_ES_ENABLE BIT(2) > > > > > > +#define SVM_MISC_CTL2_LBR_CTL_ENABLE BIT_ULL(0) > > > +#define SVM_MISC_CTL2_V_VMLOAD_VMSAVE_ENABLE BIT_ULL(1) > > > > Since you're changing names anyways, What do you think about shortening things > > a bit, and using the more standard syle of __? E.g. > > > > #define SVM_MISC2_ENABLE_LBR_VIRTUALIZATION BIT_ULL(0) > > #define SVM_MISC2_ENABLE_V_VMLOAD_VMSAVE BIT_ULL(1) > > SVM_MISC2_ENABLE_LBR_VIRTUALIZATION is actually longer, Heh, yeah, I knew that when I hit "send", I just wasn't sure if V_LBR was a good name. > how about SVM_MISC2_ENABLE_V_LBR? Shorter and more consistent with > SVM_MISC2_ENABLE_V_VMLOAD_VMSAVE. Works for me. I was mildly concerned that V_LBR wouldn't be intuitive, but since you independently came up with the name too, apparently not :-)