From: Willy Tarreau <w@1wt.eu>
To: David Laight <david.laight.linux@gmail.com>
Cc: "Thomas Weißschuh" <linux@weissschuh.net>,
linux-kernel@vger.kernel.org, "Cheng Li" <lechain@gmail.com>
Subject: Re: [PATCH v2 next 04/11] tools/nolibc/printf: Output pad characters in 16 byte chunks
Date: Sun, 8 Feb 2026 16:14:22 +0100 [thread overview]
Message-ID: <aYioTsLEytuc1uue@1wt.eu> (raw)
In-Reply-To: <20260207234305.508019e5@pumpkin>
On Sat, Feb 07, 2026 at 11:43:05PM +0000, David Laight wrote:
> On Sat, 7 Feb 2026 20:38:36 +0100
> Willy Tarreau <w@1wt.eu> wrote:
>
> > On Fri, Feb 06, 2026 at 07:11:14PM +0000, david.laight.linux@gmail.com wrote:
> > > From: David Laight <david.laight.linux@gmail.com>
> > >
> > > Simple to do and saves calls to the callback function.
> >
> > +20 bytes here but OK for me.
>
> I think some of those come back when I change all the variables to 'int'.
> Some, but not all, is because width is 32bit but len is 64bit.
> The final change that did:
> width -= len;
> ...
> while (width > 0)
> saved a surprising amount provided the ... contained some code.
> Breath on the code (or compiler version) and you easily get +/-60 bytes.
Yeah I tried as well with size_t (since compilers generally do not like
mixing data types and tend to place conversions every few instructions),
but some constants become larger and the code inflates as well.
Willy
next prev parent reply other threads:[~2026-02-08 15:14 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-06 19:11 [PATCH v2 next 00/11] tools/nolibc: Enhance printf() david.laight.linux
2026-02-06 19:11 ` [PATCH v2 next 01/11] tools/nolibc/printf: Change variable used for format chars from 'c' to 'ch' david.laight.linux
2026-02-07 18:51 ` Willy Tarreau
2026-02-16 18:52 ` Thomas Weißschuh
2026-02-06 19:11 ` [PATCH v2 next 02/11] tools/nolibc/printf: Move snprintf length check to callback david.laight.linux
2026-02-07 19:12 ` Willy Tarreau
2026-02-07 23:28 ` David Laight
2026-02-08 15:12 ` Willy Tarreau
2026-02-08 22:49 ` David Laight
2026-02-06 19:11 ` [PATCH v2 next 03/11] tools/nolibc/printf: Add buffering to vfprintf() callback david.laight.linux
2026-02-07 19:29 ` Willy Tarreau
2026-02-07 23:36 ` David Laight
2026-02-16 19:07 ` Thomas Weißschuh
2026-02-17 11:51 ` David Laight
2026-02-18 17:52 ` Thomas Weißschuh
2026-02-06 19:11 ` [PATCH v2 next 04/11] tools/nolibc/printf: Output pad characters in 16 byte chunks david.laight.linux
2026-02-07 19:38 ` Willy Tarreau
2026-02-07 23:43 ` David Laight
2026-02-08 15:14 ` Willy Tarreau [this message]
2026-02-16 19:30 ` Thomas Weißschuh
2026-02-16 22:29 ` David Laight
2026-02-18 17:30 ` Thomas Weißschuh
2026-02-06 19:11 ` [PATCH v2 next 05/11] tools/nolibc/printf: Simplify __nolibc_printf() david.laight.linux
2026-02-07 20:05 ` Willy Tarreau
2026-02-07 23:50 ` David Laight
2026-02-08 12:20 ` David Laight
2026-02-08 14:44 ` Willy Tarreau
2026-02-08 16:54 ` David Laight
2026-02-08 17:06 ` Willy Tarreau
2026-02-06 19:11 ` [PATCH v2 next 06/11] tools/nolibc/printf: Use bit-masks to hold requested flag, length and conversion chars david.laight.linux
2026-02-08 15:22 ` Willy Tarreau
2026-02-16 19:52 ` Thomas Weißschuh
2026-02-16 22:47 ` David Laight
2026-02-18 17:36 ` Thomas Weißschuh
2026-02-18 22:57 ` David Laight
2026-02-06 19:11 ` [PATCH v2 next 07/11] tools/nolibc/printf: Add support for conversion flags "#- +" and format "%X" david.laight.linux
2026-02-08 15:47 ` Willy Tarreau
2026-02-08 17:14 ` David Laight
2026-02-08 16:06 ` Willy Tarreau
2026-02-16 19:57 ` Thomas Weißschuh
2026-02-16 22:50 ` David Laight
2026-02-18 17:39 ` Thomas Weißschuh
2026-02-16 20:11 ` Thomas Weißschuh
2026-02-16 22:52 ` David Laight
2026-02-06 19:11 ` [PATCH v2 next 08/11] tools/nolibc/printf: Add support for zero padding and field precision david.laight.linux
2026-02-08 16:16 ` Willy Tarreau
2026-02-08 17:31 ` David Laight
2026-02-06 19:11 ` [PATCH v2 next 09/11] selftests/nolibc: Improve reporting of vfprintf() errors david.laight.linux
2026-02-16 20:05 ` Thomas Weißschuh
2026-02-17 10:48 ` David Laight
2026-02-18 17:48 ` Thomas Weißschuh
2026-02-06 19:11 ` [PATCH v2 next 10/11] selftests/nolibc: Increase coverage of printf format tests david.laight.linux
2026-02-16 20:14 ` Thomas Weißschuh
2026-02-16 20:23 ` Thomas Weißschuh
2026-02-16 22:54 ` David Laight
2026-02-18 17:41 ` Thomas Weißschuh
2026-02-06 19:11 ` [PATCH v2 next 11/11] selftests/nolibc: Use printf("%.*s", n, "") to align output david.laight.linux
2026-02-08 16:20 ` Willy Tarreau
2026-02-16 20:22 ` Thomas Weißschuh
2026-02-06 21:36 ` [PATCH v2 next 00/11] tools/nolibc: Enhance printf() David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYioTsLEytuc1uue@1wt.eu \
--to=w@1wt.eu \
--cc=david.laight.linux@gmail.com \
--cc=lechain@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@weissschuh.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox