From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07D7B1917ED; Mon, 9 Feb 2026 08:19:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.9 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770625145; cv=none; b=pNx+v91oxSyYUVHmU3O4Uv4/0+AkBmkRehLEgEzEpSEIppySgExHAa5fAf7NW8K8rxcQbtiA6zstWf9g30CeSKwrFp1+stMi1Xo1f+aImzX2v9gDGFDCL3w1HLxbJ46hQiyAEU66dEtI1N8xzUWCBUCbSN/E3CAMI7LScmILXpA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770625145; c=relaxed/simple; bh=v4+gioVzpmtpOGpUk+G0irz2D9GY7eKMbeUGrW55+yk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DI8ZyoCbqewICrS9G+DnBFtjCLxNWOCZKMo2EM+SCyJbTDaujvBAV2U2J19Fm/dp+GPTLzjMFfBJwRdczkKmrn+ZEx3I/ohHXiMhfzWrWsFb63/MHwcL9JO+/jbiZ7ugNyXrj5Fn6dklf+V/wQrcYmdtiCoEOoGMpX/U5GVXB4M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=YJqIkIf2; arc=none smtp.client-ip=192.198.163.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="YJqIkIf2" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1770625145; x=1802161145; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=v4+gioVzpmtpOGpUk+G0irz2D9GY7eKMbeUGrW55+yk=; b=YJqIkIf2ojg4CWIJf9DbTDdzS4eBtQsL1xZ+PO0Pn9p65TePynCEYsbR PkiPUpg0rIcgPC1pQToKTXpDRQSIB5diQCImzmiVUMkJJwQ8Y/fzLJvti cQG/dZz8/kRawUPQzXksz/l+2XDMTi4ZPf7lZiNRGurC307f+fPjSmGVX k1KeEZDLd6uZE+UJiLXMlmvfj757COKfdRtXEm03zssPfk6xVX2gwhlnH W4EqAadCa0aAPNaSDtACEoawp9tB8oySfvnCquJBc0sep4XBjc0dJb1wy kRQs9B2afRNzDon/hujimVfAAHkyusI2Hh3ictT7wmbNGO8k0Sq6cC/vJ A==; X-CSE-ConnectionGUID: 5FpaSrHLQGuthp+ziVvWGA== X-CSE-MsgGUID: FfZqHRd5S4yqLlL+TwiXGw== X-IronPort-AV: E=McAfee;i="6800,10657,11695"; a="82465464" X-IronPort-AV: E=Sophos;i="6.21,281,1763452800"; d="scan'208";a="82465464" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Feb 2026 00:19:04 -0800 X-CSE-ConnectionGUID: GemA8WHCSOacCXQ5QuuqCA== X-CSE-MsgGUID: JpaDVtz5Qa2PnJz4Q/Sfrg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,281,1763452800"; d="scan'208";a="210600232" Received: from pgcooper-mobl3.ger.corp.intel.com (HELO localhost) ([10.245.245.128]) by orviesa006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Feb 2026 00:18:59 -0800 Date: Mon, 9 Feb 2026 10:18:57 +0200 From: Andy Shevchenko To: Svyatoslav Ryhel Cc: Jonathan Cameron , David Lechner , Nuno =?iso-8859-1?Q?S=E1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dmitry Torokhov , Lee Jones , Pavel Machek , Liam Girdwood , Mark Brown , Dixit Parmar , Tony Lindgren , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org Subject: Re: [PATCH v2 10/11] mfd: motorola-cpcap: diverge configuration per-board Message-ID: References: <20260206172845.145407-1-clamor95@gmail.com> <20260206172845.145407-11-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Sun, Feb 08, 2026 at 05:19:49PM +0200, Svyatoslav Ryhel wrote: > 8 лютого 2026 р. 14:54:53 GMT+02:00, Andy Shevchenko пише: > >On Fri, Feb 06, 2026 at 07:28:44PM +0200, Svyatoslav Ryhel wrote: ... > >> -static const struct of_device_id cpcap_of_match[] = { > >> - { .compatible = "motorola,cpcap", }, > >> - { .compatible = "st,6556002", }, > >> - {}, > >> -}; > >> -MODULE_DEVICE_TABLE(of, cpcap_of_match); > >> - > >> static const struct spi_device_id cpcap_spi_ids[] = { > >> { .name = "cpcap", }, > >> { .name = "6556002", }, > >> + { .name = "mapphone-cpcap", }, > >> {}, > >> }; > > > >This also needs to be converted to use driver data. > > I can do that, but is it needed? For the consistency's sake. Also brief look at MFD SPI drivers I see that most of them use driver data. All that is redundancy? Maybe clean them up as well to show the point? > This id table, if I understand correctly, is here solely to silence warnings > about missing spi id table. Driver itself does not use it in any way and will > never use since all available devices that use this driver rely solely on the > device tree, all possible future devices will be relying on device tree too > due to obvious reasons. Then maybe SPI should be fixed to avoid this table to be present? (But don't waste your time, it will be a rabbit hole.) > >> MODULE_DEVICE_TABLE(spi, cpcap_spi_ids); ... > And please, may you contain all your reviewing in one iteration. Then both of > us will spend less time working on the patch. Thank you! It's an impossible request, you should understand that. If you want, use AI or your robot colleagues for that, I'm just a human being, I can't see everything at once. -- With Best Regards, Andy Shevchenko