From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Griffin Kroah-Hartman <griffin.kroah@fairphone.com>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Luca Weiss <luca.weiss@fairphone.com>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v3 2/3] Input: aw86938 - add driver for Awinic AW86938
Date: Mon, 9 Feb 2026 06:59:39 -0800 [thread overview]
Message-ID: <aYn13PdUF9MXhmE_@google.com> (raw)
In-Reply-To: <20260209-aw86938-driver-v3-2-5c79cff30492@fairphone.com>
Hi Griffin,
On Mon, Feb 09, 2026 at 01:59:46PM +0100, Griffin Kroah-Hartman wrote:
> @@ -377,7 +390,7 @@ static int aw86927_play_sine(struct aw86927_data *haptics)
> return err;
>
> /* set gain to value lower than 0x80 to avoid distorted playback */
> - err = regmap_write(haptics->regmap, AW86927_PLAYCFG2_REG, 0x7c);
> + err = regmap_write(haptics->regmap, AW86927_PLAYCFG2_REG, 0x45);
> if (err)
> return err;
>
Sorry, just noticed this: does this really belong to this patch or maybe
it needs be split?
Thanks.
--
Dmitry
next prev parent reply other threads:[~2026-02-09 14:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-09 12:59 [PATCH v3 0/3] Add support for Awinic AW86938 haptic driver Griffin Kroah-Hartman
2026-02-09 12:59 ` [PATCH v3 1/3] dt-bindings: input: awinic,aw86927: Add Awinic AW86938 Griffin Kroah-Hartman
2026-02-09 13:41 ` Krzysztof Kozlowski
2026-02-09 12:59 ` [PATCH v3 2/3] Input: aw86938 - add driver for " Griffin Kroah-Hartman
2026-02-09 14:59 ` Dmitry Torokhov [this message]
2026-02-09 12:59 ` [PATCH v3 3/3] arm64: dts: qcom: milos-fairphone-fp6: Add vibrator support Griffin Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYn13PdUF9MXhmE_@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=griffin.kroah@fairphone.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox