From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC87838759B for ; Mon, 9 Feb 2026 19:31:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770665514; cv=none; b=VnO6sqaUhDSxO9U9DOg87/pDD7BWQEHiGTL2pHflgwPNCMuk5yCl9xCSnX1x/i8hms6l/kkZS0vJ5FVHMAh/7HXI0iLlc5Dt4B92nHYv1qoqGG0os2UWS7l1KwZZWPz6uW0KSkWul5eEcR6dz3YedZZE3GEkHZG1B9QQZFzr8W0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770665514; c=relaxed/simple; bh=NMMjrph8bNLMAw02ZraHdiK+pEZZUMZxT3K+AuWZRZs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IIHNLmH1W0WR9t4nzkSp1qn4qQu9Iv+HGy5qskhLrCKqz4xNw2ioKviSNby0ITocW8qCC+OoMNPLOpNr31xFBW4nbcfpSsCaZtghDRxCuCHxkb34azjtkYjEkGKDdX2WxhZ1/nT1hVZvgMlQUYCP5Wz3Xl5q7c0Lhzr3PzOAqFQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=lr4QbNsG; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="lr4QbNsG" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2a964077671so12275ad.0 for ; Mon, 09 Feb 2026 11:31:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1770665514; x=1771270314; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=L9rHFvDcYDJ5I2XeyKJgfwKYtF6xJ5jOPGzWKqUMlyY=; b=lr4QbNsGLRm9OYgccT+9NZAIwNtZbD/VWJ0t4X/j7Ter4ZV2JLaWMa2b1ccXZZr8Iw a41XBf+g5opQSgW2AIba3h1O3A4Iu1Z4990I96glDlpi2lDuA1c46GBfZniTgjEW2Gp6 febFoFpul8se0HjpAKLaylfDzf+b/Z31sUWWSMdrarmVe0zVxL8rC7dI3vQxv1G551wf PgNwOHBZcHWgAErYiUZmRddipCo/sECt7njm7Th3XPOC89BXruZNVSyDDNHTwzBcHxI/ 4VunwDr6WQf7tb+AaNzCP1CgYuPUsmGzxcTmb4e/mCuw6qPvWwiZaOJzv432nwBR8umY LX2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770665514; x=1771270314; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=L9rHFvDcYDJ5I2XeyKJgfwKYtF6xJ5jOPGzWKqUMlyY=; b=XS4F3GR33e+1qtrOYfUAFcK+oFE2BT5Sw1IuGAVbhlxVz7NQbqFSx4fdyOM+Nf8PJv mWHS1jTTh/7AbLJMezpX+JUFXu1n3bZ4YxkDMw6Foxzs+DUI/02PexFC9o0eAJhYmWPG OZ9D7gqoc12bwpHqPoPl+bN+rUHpcOaaWo23tcdLQmaxNy3SYELAfIS7tGBxHQ3VpV5n ZvQuMg8i5gmlZn7oqwGL3TfolA94M6uBux2gtfLwGT6RZx3VzwvJyf1tQF1A1hE7MrxE 79IcRGTnb6L0b3gsHdDpb+lsDrolwA8vmP0T9tCvFZnDWQibYtArrcOtCpEQH+CCZh52 QQsA== X-Forwarded-Encrypted: i=1; AJvYcCWH+U5PxLnttUFpPWhTee5mqkfUvf9CPV1or1mitjANZfJfpid+nRavfAqz/ULeueY+s0hZSNr3tYJaSn0=@vger.kernel.org X-Gm-Message-State: AOJu0Yy11VguTTtyAZzABoHmVidwiDwgtoxPeppGeMvoZRSCNkzakyGo xFP06INhOyiOApf7PlRutWFgiMUN1qSiiJAVYNnGgOc6hqAaNrE8PA+GaWSp2NR5tQ== X-Gm-Gg: AZuq6aI6kMglXdpGZ4gu9prscA7sDifp1qx3E7s6f8boEEV+475MU7GOyshfkM2cePu YTcL5f8RxHbQdpxIoURBPHYO4aaYe/uWpWRUhJDz6JZBxhyv/TeQcATgnmQ6zB4qc0tWyU1nB8H u4EFuDzR5hAu1cvwtwPsDBMTm3m0O+p3eHh5BcXAuBHEJjK9WIkdaf0/34iqiNVsNjapp6WgwFT yWPrIETHlqFS0TdKekInzyWYxMX9pJT0iFhnz5qMLDyB2iXt7T1Kupr9XtSJA3niacigawAHc0Q zIxKPjS4AwupcPNZQ4PELGVOA/ngNtdEdEZ94Kbutc14ez+MemCfwohhM5uWdyo/m6tWzCL8j9T EFrgyY+x+ULIDZk0MSQYp/lGqZLDvYeBiWs/RFAvDgDL6eSL2gt+64TQdk/3DDTVAe8GenLQMSo n2aAmc+Owq12CjCGxPoHIFPb0+3Y8a/ArshiGnOw+DXme4d7UJBA== X-Received: by 2002:a17:902:7c93:b0:271:9873:80d9 with SMTP id d9443c01a7336-2ab0ea1940dmr290255ad.7.1770665513647; Mon, 09 Feb 2026 11:31:53 -0800 (PST) Received: from google.com (185.29.127.34.bc.googleusercontent.com. [34.127.29.185]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a951ca59f4sm112387565ad.43.2026.02.09.11.31.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Feb 2026 11:31:53 -0800 (PST) Date: Mon, 9 Feb 2026 11:31:48 -0800 From: Igor Pylypiv To: Bart Van Assche Cc: "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH v2] scsi: core: Add 'serial' sysfs attribute for SCSI/SATA Message-ID: References: <20260205180015.2215143-1-ipylypiv@google.com> <430f606d-9305-41d9-9a49-b9ab6894cd61@acm.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <430f606d-9305-41d9-9a49-b9ab6894cd61@acm.org> On Mon, Feb 09, 2026 at 09:31:39AM -0800, Bart Van Assche wrote: > On 2/5/26 10:00 AM, Igor Pylypiv wrote: > > + return sysfs_emit(buf, "%s\n", buf); > > Since many snprintf() variants do not allow to specify the output buffer as > input argument, the above seems risky to me. Has it been considered to > replace the above statement with the following? > > return sysfs_emit_at(buf, strlen(buf), "\n"); Thank you for pointing this out, Bart! I've now realized that you pointed out this in V1 as well but I misunderstood your comment. sysfs_emit_at() returns number of characters written starting at &buf[at] so it would return 1 for the added newline. We can add the number of characters written by scsi_vpd_lun_serial() to return the correct number of characters: return ret + sysfs_emit_at(buf, ret, "\n"); This looks a bit too complicated/ugly to me. Instead, I will put a newline manually and return the correct number of characters. PAGE_SIZE is passed to scsi_vpd_lun_serial() so we don't sysfs_emit_at() to check it again. buf[ret] = '\n'; return ret + 1; Let me know if this sounds good to you. Thank you! Igor > > Thanks, > > Bart. >