From: Hamza Mahfooz <someguy@effective-light.com>
To: "Christian König" <christian.koenig@amd.com>
Cc: dri-devel@lists.freedesktop.org,
"Timur Kristóf" <timur.kristof@gmail.com>,
"Michel Dänzer" <michel.daenzer@mailbox.org>,
"Xaver Hugl" <xaver.hugl@kde.org>,
"Harry Wentland" <harry.wentland@amd.com>,
"Leo Li" <sunpeng.li@amd.com>,
"Rodrigo Siqueira" <siqueira@igalia.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Ivan Lipski" <ivan.lipski@amd.com>,
"Kenneth Feng" <kenneth.feng@amd.com>,
"Alex Hung" <alex.hung@amd.com>,
"Tom Chung" <chiahsuan.chung@amd.com>,
"Melissa Wen" <mwen@igalia.com>,
"Michel Dänzer" <mdaenzer@redhat.com>,
"Fangzhi Zuo" <Jerry.Zuo@amd.com>,
amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] drm: introduce KMS recovery mechanism
Date: Mon, 9 Feb 2026 18:04:15 -0500 [thread overview]
Message-ID: <aYpn74JYNIR5Kr-9@hal-station> (raw)
In-Reply-To: <2ac2dc2f-552c-4084-872b-179a1e489156@amd.com>
On Mon, Feb 09, 2026 at 10:35:05AM +0100, Christian König wrote:
> > + /**
> > + * @page_flip_timeout:
> > + *
> > + * This optional hook is called if &drm_crtc_commit.flip_done times out,
> > + * and can be used by drivers to attempt to recover from a page flip
> > + * timeout.
> > + */
> > + void (*page_flip_timeout)(struct drm_crtc *crtc);
>
> As far as I can see a callback is clearly not the right approach.
>
> The drm_atomic_helper_wait_for_flip_done() helper is called by the driver, isn't it?
>
> So what we need is just to give an error code back to the driver.
>
I guess we could just have the function return -ETIMEOUT, but then
drivers wouldn't know which crtc is timing out and AFAIK drivers aren't
supposed to touch `drm_crtc_commit`s so they don't really have a
sanctioned means to figure that out on their own.
next prev parent reply other threads:[~2026-02-09 23:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-06 23:58 [PATCH v2 1/2] drm: introduce KMS recovery mechanism Hamza Mahfooz
2026-02-06 23:58 ` [PATCH v2 2/2] drm/amdgpu: implement page_flip_timeout() support Hamza Mahfooz
2026-02-09 9:36 ` Christian König
2026-02-09 22:53 ` [PATCH v2 2/2] drm/amdgpu: implement page_flip_timeout() supporty Hamza Mahfooz
2026-02-09 9:35 ` [PATCH v2 1/2] drm: introduce KMS recovery mechanism Christian König
2026-02-09 23:04 ` Hamza Mahfooz [this message]
2026-02-10 8:26 ` Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYpn74JYNIR5Kr-9@hal-station \
--to=someguy@effective-light.com \
--cc=Jerry.Zuo@amd.com \
--cc=airlied@gmail.com \
--cc=alex.hung@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=chiahsuan.chung@amd.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=ivan.lipski@amd.com \
--cc=kenneth.feng@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mdaenzer@redhat.com \
--cc=michel.daenzer@mailbox.org \
--cc=mripard@kernel.org \
--cc=mwen@igalia.com \
--cc=simona@ffwll.ch \
--cc=siqueira@igalia.com \
--cc=sunpeng.li@amd.com \
--cc=timur.kristof@gmail.com \
--cc=tzimmermann@suse.de \
--cc=xaver.hugl@kde.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox