From: Brian Masney <bmasney@redhat.com>
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Claudiu Beznea <claudiu.beznea@tuxon.dev>
Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-clk@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
Adrian Hunter <adrian.hunter@intel.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-mmc@vger.kernel.org, Linus Walleij <linusw@kernel.org>,
linux-gpio@vger.kernel.org,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
linux-rtc@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
linux-serial@vger.kernel.org, Guenter Roeck <linux@roeck-us.net>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
linux-watchdog@vger.kernel.org,
Lukas Bulwahn <lukas.bulwahn@redhat.com>
Subject: Re: [PATCH v2 00/16] MIPS: move pic32.h header file from asm to platform_data
Date: Tue, 10 Feb 2026 07:42:25 -0500 [thread overview]
Message-ID: <aYsnsecPa8bWMbaA@redhat.com> (raw)
In-Reply-To: <20260112-mips-pic32-header-move-v2-0-927d516b1ff9@redhat.com>
Hi Thomas,
On Mon, Jan 12, 2026 at 05:47:54PM -0500, Brian Masney wrote:
> There are currently some pic32 MIPS drivers that are in tree, and are
> only configured to be compiled on the MIPS pic32 platform. There's a
> risk of breaking some of these drivers when migrating drivers away from
> legacy APIs. It happened to me with a pic32 clk driver.
>
> Let's go ahead and move the pic32.h from the asm to the platform_data
> include directory in the tree. This will make it easier, and cleaner to
> enable COMPILE_TEST for some of these pic32 drivers. To do this requires
> updating some includes, which I do at the beginning of this series.
>
> This series was compile tested on a centos-stream-10 arm64 host in two
> different configurations:
>
> - native arm64 build with COMPILE_TEST (via make allmodconfig)
> - MIPS cross compile on arm64 with:
> ARCH=mips CROSS_COMPILE=mips64-linux-gnu- make pic32mzda_defconfig
>
> Note that there is a separate MIPS compile error in linux-next, and I
> reported it at https://lore.kernel.org/all/aWVs2gVB418WiMVa@redhat.com/
>
> I included a patch at the end that shows enabling COMPILE_TEST for a
> pic32 clk driver.
>
> Merge Strategy
> ==============
> - Patches 1-15 can go through the MIPS tree.
> - Patch 16 I can repost to Claudiu after patches 1-15 are in Linus's
> tree after the next merge window. There is a separate patch set that
> fixes a compiler error I unintentionally introduced via the clk tree.
> https://lore.kernel.org/linux-clk/CABx5tq+eOocJ41X-GSgkGy6S+s+Am1yCS099wqP695NtwALTmg@mail.gmail.com/T/
Sorry about the duplicate message. I just wanted to reply to the series
with MIPS in the header so this message isn't lost.
Can you back out these two patches from your tree in linux-next, and not
send these to Linus?
clk: microchip: core: allow driver to be compiled with COMPILE_TEST
https://git.kernel.org/pub/scm/linux/kernel/git/mips/linux.git/commit/?id=026d70dcfe5de1543bb8edb8e50d22dc16863e6b
clk: microchip: fix typo in reference to a config option
https://git.kernel.org/pub/scm/linux/kernel/git/mips/linux.git/commit/?id=a6ab150deb4b740334721d18e02ad400a9d888f5
See
https://lore.kernel.org/oe-kbuild-all/202602100954.BAVYq6aC-lkp@intel.com/
All of the other patches with the include changes are good. I have
patches queued to send out in two weeks to other subsystems once the
include changes land in Linus's tree.
Thanks,
Brian
next prev parent reply other threads:[~2026-02-10 12:42 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-12 22:47 [PATCH v2 00/16] MIPS: move pic32.h header file from asm to platform_data Brian Masney
2026-01-12 22:47 ` [PATCH v2 01/16] MIPS: pic32: include linux/io.h header on several files Brian Masney
2026-01-12 22:47 ` [PATCH v2 02/16] MIPS: pic32: include linux/types.h on pic32.h Brian Masney
2026-01-12 22:47 ` [PATCH v2 03/16] MIPS: pic32: drop unused include linux/io.h from pic32.h Brian Masney
2026-01-16 7:12 ` claudiu beznea
2026-01-16 15:14 ` Brian Masney
2026-01-12 22:47 ` [PATCH v2 04/16] MIPS: copy pic32.h header file from asm/mach-pic32/ to include/platform-data/ Brian Masney
2026-01-12 22:47 ` [PATCH v2 05/16] MAINTAINERS: add include/linux/platform_data/pic32.h to MIPS entry Brian Masney
2026-01-12 22:48 ` [PATCH v2 06/16] MIPS: update include to use pic32.h from platform_data Brian Masney
2026-01-12 22:48 ` [PATCH v2 07/16] clk: microchip: core: " Brian Masney
2026-01-16 7:15 ` claudiu beznea
2026-01-12 22:48 ` [PATCH v2 08/16] irqchip/irq-pic32-evic: " Brian Masney
2026-01-13 8:53 ` Thomas Gleixner
2026-01-12 22:48 ` [PATCH v2 09/16] mmc: sdhci-pic32: " Brian Masney
2026-01-21 6:51 ` Adrian Hunter
2026-01-22 17:26 ` Ulf Hansson
2026-01-12 22:48 ` [PATCH v2 10/16] pinctrl: pic32: " Brian Masney
2026-01-12 22:48 ` [PATCH v2 11/16] rtc: " Brian Masney
2026-01-12 22:48 ` [PATCH v2 12/16] serial: pic32_uart: " Brian Masney
2026-01-13 6:38 ` Jiri Slaby
2026-01-13 11:30 ` Brian Masney
2026-01-12 22:48 ` [PATCH v2 13/16] watchdog: pic32-dmt: " Brian Masney
2026-01-12 22:48 ` [PATCH v2 14/16] watchdog: pic32-wdt: " Brian Masney
2026-01-12 22:48 ` [PATCH v2 15/16] MIPS: drop unused pic32.h header Brian Masney
2026-01-12 22:48 ` [PATCH v2 16/16] clk: microchip: core: allow driver to be compiled with COMPILE_TEST Brian Masney
2026-01-13 5:48 ` Stephen Boyd
2026-01-13 11:35 ` Brian Masney
2026-01-23 0:49 ` [PATCH v2 00/16] MIPS: move pic32.h header file from asm to platform_data Brian Masney
2026-01-30 14:37 ` Thomas Bogendoerfer
2026-02-10 12:42 ` Brian Masney [this message]
2026-02-10 15:50 ` Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYsnsecPa8bWMbaA@redhat.com \
--to=bmasney@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lukas.bulwahn@redhat.com \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
--cc=tsbogend@alpha.franken.de \
--cc=ulf.hansson@linaro.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox