From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Antoniu Miclaus <antoniu.miclaus@analog.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: dac: max5522: use devm_regulator_get_enable_read_voltage()
Date: Tue, 10 Feb 2026 21:35:26 +0200 [thread overview]
Message-ID: <aYuIftCDo5O0IF9F@smile.fi.intel.com> (raw)
In-Reply-To: <20260210175137.44178-1-antoniu.miclaus@analog.com>
On Tue, Feb 10, 2026 at 07:51:27PM +0200, Antoniu Miclaus wrote:
> Simplify probe by using devm_regulator_get_enable_read_voltage() to
> get, enable and read the regulator voltage in a single call, caching
> the value at probe time.
...
> - struct regulator *vrefin_reg;
> + unsigned short vref_mv;
vref_mV ?
...
> + state->vref_mv = ret / 1000;
"1000" --> "(MICRO / MILLI)" ?
(yes, this way with the parentheses).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-02-10 19:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-10 17:51 [PATCH] iio: dac: max5522: use devm_regulator_get_enable_read_voltage() Antoniu Miclaus
2026-02-10 19:35 ` Andy Shevchenko [this message]
2026-02-14 18:20 ` Jonathan Cameron
2026-02-14 18:31 ` Andy Shevchenko
2026-02-14 18:36 ` David Lechner
2026-02-15 7:53 ` Andy Shevchenko
2026-02-15 16:00 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYuIftCDo5O0IF9F@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox