From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C29232E126; Tue, 10 Feb 2026 20:05:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.15 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770753931; cv=none; b=FlS+2mTR1vMZCr2U7R+dqM8YQ9gyVjSxHMMLZK80AqgtgM8Uh+CB0+lpPu9ouHVSVRcI8zH7oGvu9G9A3cKofxfhWKdAMOqtm6T8cRDU1ee9WaZJ3fzTE0wOJB4QDA6RimgKBSvvJfCHRyodN686soWta5+60kzRSBuno2azNYk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770753931; c=relaxed/simple; bh=7NF/NMO9NmFb4sERswHkU4tsfUJu0ywTAY7+eT4qWzU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WvfvuY2tukIeyL7Wv6hDf/vMtAH3VRafBW+4Py0RTBK0aPw0ca0OX0a/jPpefhzVw2ZMqK848eWFNbW7RiO+sEieFpXQWwpZgKATDmSz7WtpFLQS9W409K6Xc3oFXFMkkkR12IeAVXsmIuhMvFoKdaZcT9l/TrnIbdvmXp681sc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=kSnzDYxd; arc=none smtp.client-ip=198.175.65.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="kSnzDYxd" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1770753930; x=1802289930; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=7NF/NMO9NmFb4sERswHkU4tsfUJu0ywTAY7+eT4qWzU=; b=kSnzDYxdJSgZ+LgSZwSZJz8u6+CM29EXPJEbHhC/A5AE/j3QYvok+cfG NeYy5t9JasvI7O2G7RJ+VzTic6IcAHf0rbOkdakJpFKxS5zshB5hTkglR 1Q+EydtCJ7Sojh6FcK2mN+exJY8MlnKfdRQan55dzflG7/CvSFx7vxr9d m77VL3niBquB57F8P0xDc9AfJYvbdEKeBiOhqMQGt0TYQm3TLUURTOVEF y7bEBHApQegQStL+5QydwiQ63/BdQzxIVLNAPITnw06iR4oze+A0ES3c2 tHzbUur6n262Oa64OmFvSxYRbnIacPzrDrgR+WSJaSTv3JwKZM0r8LM5w w==; X-CSE-ConnectionGUID: Iw6yRsp/TN2WrOrPqHHJHQ== X-CSE-MsgGUID: oENPT5UwQsujDDBlmUYYOw== X-IronPort-AV: E=McAfee;i="6800,10657,11697"; a="75521833" X-IronPort-AV: E=Sophos;i="6.21,283,1763452800"; d="scan'208";a="75521833" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2026 12:05:29 -0800 X-CSE-ConnectionGUID: YM/FttBkQXikQv1OHVi4RA== X-CSE-MsgGUID: GZjw9gtdQiWcUoKOPv0zRg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,283,1763452800"; d="scan'208";a="216973532" Received: from dalessan-mobl3.ger.corp.intel.com (HELO localhost) ([10.245.244.131]) by orviesa005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2026 12:05:27 -0800 Date: Tue, 10 Feb 2026 22:05:24 +0200 From: Andy Shevchenko To: rodrigo.alencar@analog.com Cc: linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, Michael Hennerich , Lars-Peter Clausen , Jonathan Cameron , David Lechner , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley Subject: Re: [PATCH v4 07/11] iio: amplifiers: ad8366: refactor device resource management Message-ID: References: <20260210-iio-ad8366-update-v4-0-15505f7b15b4@analog.com> <20260210-iio-ad8366-update-v4-7-15505f7b15b4@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260210-iio-ad8366-update-v4-7-15505f7b15b4@analog.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Tue, Feb 10, 2026 at 07:42:07PM +0000, Rodrigo Alencar via B4 Relay wrote: > Adhere modern device resource management with the following: > - Voltage regulator managed and enabled internally; > - IIO device registration handled with devm_iio_device_register(); > - removal of goto's from the probe function; > - ad8366_remove() removed as it is not needed anymore; > > With the drop of goto's dev_err_probe() is used to report probe errors. I think the regulator change should be split and go before the previous patch, because that one affects the ordering in the error path and remove stage. Otherwise LGTM. -- With Best Regards, Andy Shevchenko