From: "Luck, Tony" <tony.luck@intel.com>
To: Sohil Mehta <sohil.mehta@intel.com>
Cc: Dave Hansen <dave.hansen@intel.com>,
Dave Hansen <dave.hansen@linux.intel.com>, <zhao1.liu@intel.com>,
Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
Ingo Molnar <mingo@redhat.com>, Jon Kohler <jon@nutanix.com>,
Pawan Gupta <pawan.kumar.gupta@linux.intel.com>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Thomas Gleixner <tglx@kernel.org>, <x86@kernel.org>,
Iwona Winiarska <iwona.winiarska@intel.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/6] x86/cpu: Break Vendor/Family/Model macros into separate header
Date: Tue, 10 Feb 2026 15:32:23 -0800 [thread overview]
Message-ID: <aYvAB10SyKs17XiS@agluck-desk3> (raw)
In-Reply-To: <54745fd4-d139-4162-82b5-a10c1993e77a@intel.com>
On Tue, Feb 10, 2026 at 03:03:18PM -0800, Sohil Mehta wrote:
> On 2/10/2026 2:17 PM, Dave Hansen wrote:
>
> > The reality is that we have non-x86 code using an x86 header. That's
> > crazy and it's very very unusual and we're probably going to keep
> > accidentally breaking it.
Maybe the answer is to change the peci code to not do that crazy
include of an arch/x86 file and simply have its own copies of the
#define model numbers for the eight models it cares about?
If they add a ninth at some point, they have to change their code
anyway to add a "case INTEL_FOO:". So adding the model number to
their own local include file doesn't seem like much extra work.
-Tony
next prev parent reply other threads:[~2026-02-10 23:32 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-06 23:14 [PATCH 0/6] [v2] x86/cpu: Take Intel platform into account for old microcode checks Dave Hansen
2026-02-06 23:14 ` [PATCH 1/6] x86/cpu: Break Vendor/Family/Model macros into separate header Dave Hansen
2026-02-10 22:13 ` Sohil Mehta
2026-02-10 22:17 ` Dave Hansen
2026-02-10 23:03 ` Sohil Mehta
2026-02-10 23:32 ` Luck, Tony [this message]
2026-02-10 23:35 ` Dave Hansen
2026-02-10 23:52 ` Luck, Tony
2026-02-11 21:12 ` Dave Hansen
2026-02-11 21:54 ` Sohil Mehta
2026-02-11 22:32 ` Luck, Tony
2026-02-11 22:35 ` Sohil Mehta
2026-02-11 23:02 ` Dave Hansen
2026-02-11 22:21 ` Luck, Tony
2026-02-06 23:14 ` [PATCH 2/6] x86/cpu: Add missing #include Dave Hansen
2026-02-06 23:14 ` [PATCH 3/6] x86/microcode: Refactor platform ID enumeration into a helper Dave Hansen
2026-02-10 23:20 ` Sohil Mehta
2026-02-10 23:23 ` Dave Hansen
2026-02-06 23:14 ` [PATCH 4/6] x86/cpu: Add platform ID to CPU info structure Dave Hansen
2026-02-08 21:37 ` Borislav Petkov
2026-02-11 18:40 ` Dave Hansen
2026-02-12 15:22 ` Borislav Petkov
2026-02-10 23:23 ` Sohil Mehta
2026-02-06 23:14 ` [PATCH 5/6] x86/cpu: Add platform ID to CPU matching structure Dave Hansen
2026-02-10 23:27 ` Sohil Mehta
2026-02-06 23:14 ` [PATCH 6/6] x86/microcode: Add platform mask to Intel microcode "old" list Dave Hansen
2026-02-10 23:39 ` Sohil Mehta
2026-02-09 10:20 ` [PATCH 0/6] [v2] x86/cpu: Take Intel platform into account for old microcode checks Maciej Wieczor-Retman
2026-02-09 15:15 ` Dave Hansen
-- strict thread matches above, loose matches on Subject: below --
2026-01-19 19:50 [PATCH 0/6] " Dave Hansen
2026-01-19 19:50 ` [PATCH 1/6] x86/cpu: Break Vendor/Family/Model macros into separate header Dave Hansen
2026-01-20 8:24 ` Andy Shevchenko
2026-01-20 15:03 ` Dave Hansen
2026-01-20 16:22 ` Andy Shevchenko
2026-01-20 16:34 ` Dave Hansen
2026-01-20 20:54 ` Andy Shevchenko
2026-01-20 16:48 ` Luck, Tony
2026-01-20 20:50 ` Shevchenko, Andriy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYvAB10SyKs17XiS@agluck-desk3 \
--to=tony.luck@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=iwona.winiarska@intel.com \
--cc=jon@nutanix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=peterz@infradead.org \
--cc=sohil.mehta@intel.com \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox