From: Keith Busch <kbusch@kernel.org>
To: Junnan Zhang <zhangjn_dev@163.com>
Cc: axboe@kernel.dk, hch@lst.de, linux-kernel@vger.kernel.org,
linux-nvme@lists.infradead.org, liuyx92@chinatelecom.cn,
sagi@grimberg.me, sunshx@chinatelecom.cn,
yuanql9@chinatelecom.cn, zhangjn11@chinatelecom.cn,
zhangzl68@chinatelecom.cn
Subject: Re: [PATCH] nvme-pci: fix potential I/O hang when CQ is full
Date: Wed, 11 Feb 2026 05:27:50 -0700 [thread overview]
Message-ID: <aYx1xoY_yeNvTtF2@kbusch-mbp> (raw)
In-Reply-To: <20260211094744.32366-1-zhangjn_dev@163.com>
On Wed, Feb 11, 2026 at 05:47:44PM +0800, Junnan Zhang wrote:
> On Tue, 10 Feb 2026 16:57:12 +0100, Christoph Hellwig wrote:
>
> > We can't update the CQ head before consuming the CQEs, otherwise
> > the device can reuse them. And devices must not discard completions
> > when there is no completion queue entry, nvme does allow SQs and CQs
> > to be smaller than the number of outstanding commands.
>
> Updating the CQ head before consuming the CQE would not cause the device to
> reuse these entries, as new commands can only be submitted by the driver after
> the CQE is consumed. Therefore, the device does not have the opportunity
> to reuse these entries.
That's just an artifact of how this host implementation constrains its
tag space. It's not a reflection of how the NVMe protocol fundamentally
works.
A full queue is not an error. It's a spec defined condition that the
submitter just has to deal with. The protocol was specifically made to
allow scenarios for dispatching more outstanding commands than the
queues can hold. Your controller is broken.
next prev parent reply other threads:[~2026-02-11 12:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-09 12:10 [PATCH] nvme-pci: fix potential I/O hang when CQ is full Junnan Zhang
2026-02-10 15:57 ` Christoph Hellwig
2026-02-11 9:47 ` Junnan Zhang
2026-02-11 12:27 ` Keith Busch [this message]
2026-02-12 9:42 ` Junnan Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYx1xoY_yeNvTtF2@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=liuyx92@chinatelecom.cn \
--cc=sagi@grimberg.me \
--cc=sunshx@chinatelecom.cn \
--cc=yuanql9@chinatelecom.cn \
--cc=zhangjn11@chinatelecom.cn \
--cc=zhangjn_dev@163.com \
--cc=zhangzl68@chinatelecom.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox