From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Neel Bullywon <neelb2403@gmail.com>
Cc: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com,
andy@kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 3/3] iio: magnetometer: bmc150_magn: minor formatting cleanup
Date: Wed, 11 Feb 2026 10:41:58 +0200 [thread overview]
Message-ID: <aYxA1lBOluYHYjCv@smile.fi.intel.com> (raw)
In-Reply-To: <20260210233945.40975-4-neelb2403@gmail.com>
On Tue, Feb 10, 2026 at 06:39:45PM -0500, Neel Bullywon wrote:
> Improve initializer list style for bmc150_magn_samp_freq_table by
> moving the opening brace to its own line and grouping four entries
> per line with index comments.
>
> Add spaces inside braces for initializer lists in the preset table
> for consistency.
>
> Fix indentation of bmc150_magn_scan_masks array. No functional changes.
...
> +} bmc150_magn_samp_freq_table[] = {
> + { 2, 0x01 }, { 6, 0x02 }, { 8, 0x03 }, { 10, 0x00 }, /* 0 - 3 */
> + { 15, 0x04 }, { 20, 0x05 }, { 25, 0x06 }, { 30, 0x07 }, /* 4 - 7 */
Problem with indentation of the comment in the last line.
> +};
Otherwise, LGTM.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-02-11 8:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-10 23:39 [PATCH v6 0/3] iio: magnetometer: bmc150_magn: cleanup and formatting Neel Bullywon
2026-02-10 23:39 ` [PATCH v6 1/3] iio: magnetometer: bmc150_magn: use automated cleanup for mutex Neel Bullywon
2026-02-11 8:39 ` Andy Shevchenko
2026-02-13 23:31 ` kernel test robot
2026-02-14 16:34 ` Jonathan Cameron
2026-02-14 16:28 ` David Lechner
2026-02-10 23:39 ` [PATCH v6 2/3] iio: magnetometer: bmc150_magn: replace msleep with fsleep Neel Bullywon
2026-02-11 8:40 ` Andy Shevchenko
2026-02-10 23:39 ` [PATCH v6 3/3] iio: magnetometer: bmc150_magn: minor formatting cleanup Neel Bullywon
2026-02-11 8:41 ` Andy Shevchenko [this message]
2026-02-14 16:31 ` David Lechner
2026-02-14 18:00 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYxA1lBOluYHYjCv@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neelb2403@gmail.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox