From: Sean Christopherson <seanjc@google.com>
To: Jamie Liu <jamieliu@google.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Borislav Petkov <bp@alien8.de>, Thomas Gleixner <tglx@kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: x86: Virtualize AMD CPUID faulting
Date: Wed, 11 Feb 2026 05:50:59 -0800 [thread overview]
Message-ID: <aYyJQ92032DNvqSd@google.com> (raw)
In-Reply-To: <20260210210911.1118316-1-jamieliu@google.com>
On Tue, Feb 10, 2026, Jamie Liu wrote:
> CPUID faulting via MSR_MISC_FEATURES_ENABLES_CPUID_FAULT is only used on
> Intel CPUs. The mechanism virtualized by this change is used on AMD
> CPUs. See arch/x86/kernel/cpu/amd.c:bsp_init_amd(),
> arch/x86/kernel/process.c:set_cpuid_faulting().
Please rewrite this to state what is being changed, e.g. how KVM is virtualizing
the feature, and most importantly why it is "safe" to do so. Specifically, this
needs to call out that CPUID_USER_DIS is documented in the APM as an architectural
MSR, which for me at least, is mandatory for virtualizing/emulating any of the
MSR_K7_HWCR.
The fact that Intel uses some other mechanism is irrelevant, and the kernel source
code is not authoritative for things like this.
prev parent reply other threads:[~2026-02-11 13:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-10 21:09 [PATCH] KVM: x86: Virtualize AMD CPUID faulting Jamie Liu
2026-02-10 23:23 ` Jim Mattson
2026-02-11 13:50 ` Sean Christopherson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYyJQ92032DNvqSd@google.com \
--to=seanjc@google.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jamieliu@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox