From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f173.google.com (mail-dy1-f173.google.com [74.125.82.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5BA734321F for ; Wed, 11 Feb 2026 21:45:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770846318; cv=none; b=mEnbRL7R3+uCrxFN1U2iBZ+VjS9RXGJHjzuSKxgcISHgZKl36YvN+dym4QVM9nqJ1T2YKYOZS8LJE0XNkmZI+4Lx7wtuRoHiGQ6F8WQfReuUsn4djaOx6i+R/WPWcSWsGSj1tFx0oRc10OtXwdkCl4faBlcUe6mTyypdjBhLbWc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770846318; c=relaxed/simple; bh=RtUeeV6zYQZwMrWhdB9hgDezJFrJfXgCHvJ3MBFTbz0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SbqinWr97WP+gvgVCM/9mOXlTNSRL+q7ZQOCMIoi9jFPI8zYKFOJmiw1Y30v81NEwJzQ8niO047BM2hgF7lnRpu72cSbFhER4qnifdFFtY7O/nSJWKuhfMwPeanE0BS4yZ8jJ41XjnF3K9e2StdYtlHhwJx1/jRzN+oOJVH1/os= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NjxKP3BE; arc=none smtp.client-ip=74.125.82.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NjxKP3BE" Received: by mail-dy1-f173.google.com with SMTP id 5a478bee46e88-2b785801c93so13908695eec.0 for ; Wed, 11 Feb 2026 13:45:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770846317; x=1771451117; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=WbrdtXUZqdG9RbVky/2Xj3vrytI/PZAZDAo/EZQS2SU=; b=NjxKP3BEMJyaqafZ8hqTCEFQiaMQHFei+EipSzd5pnITJdmiE5mf5quOr+9oajSVF5 xY9/N0/TW4A6stI8yCLtEcPRolHmZz5CzCctSY6MzvS/ZVAny4VKYKjYFL/39dvdVxeB 8MPBVpwYPWTEjgWV7J1ml8+BuVVa3cPuitkc4qKFcuGF1mQVxzFThoGA6q0tPv5umw2j y+yRhxTesCVRDymjp8VfAxL1YfWrVeO2njtK+SsazqsdW/+YmkKmo3cNBswreGzEBTso E1t60icB6cRL3ETwNHszNxnivei5YRTNs5S3LNpweQ1w1ODM0NDCNWrti2BZwlXZGS8H dsMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770846317; x=1771451117; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WbrdtXUZqdG9RbVky/2Xj3vrytI/PZAZDAo/EZQS2SU=; b=WaBXB6IF3L0s+RA3rbyD4o46IrmKQWrTIZVcAaLsKM1ijjfErGLyjmrE95gLi7Gk13 u+Z6e/vw83jSZME822UkLKjRal1N9OpjmsKUBP29C7yah1+b5QtTxJiDrk0yfBZ6JWhv 3AAlaOI1HAwEAGaEQSUTRRHojXjz3OZXCCJjZcxQX3VyEXzWo+dud5CUXz57CXF2BrAB lpbB0SxmtPIp+JeM99PiBF+c6OuYDfDF8esaCDWmeD4sP5aRGk6EQ7K9r6Nn8mv9KgXT vevNb0nPLupzEuHfN8WweKRVI0jkp2cLUEZ07hHa4pM0YJbwTiTkCJANlNR7P5jgr8W+ X1Fg== X-Gm-Message-State: AOJu0Yz2vqZt1H+zgjgtrOg5Beasn5vVTKuefPwtqBbH6H9IVIPMx+e7 vwMeH1mw1FMUREj73ppE7JizH2fhxuU2lpiodTm1Wq33M6oFHFLB+G3n X-Gm-Gg: AZuq6aKOghtq/srF/lyGIPlKYPEXtdfQG0f+C/7EIVMk2ZhKNPWjA+V/yY8+AABuj3v GsBg6a5apadyknoxWTaDcCOcLsNViUx43vxkk4vo2khAsJon3grZO4Yi136ZMzeMtORNNKH/aEN YqpGLAvGdPO5L7OM3wofffuwop5K5kE1AZrWcX6SIMFVPNF028oNDepxBJxYKTS2kWLXdFzV/Mr XhqWk1z1ASMZVANFEHnx5Yl0lH5+yfeBYRAhs5pvWxSWb08XaaU4DPCEiGAJckBYYHGE4MTvBwb YN3YGDc3tBBGiWm+H2/AlSqnsrhxmAdwaitbatRhxAu4ryLVzyj5e3B0yKsTamByJzOukHKuIix KHmOW2IQgOBRctoLlaXzShbpLU9KBkanDVkuRZvuN3e++xjf/jE7ULInrHbww4OQ2uqxVR/cvvU F5kHbY8wqfSqwK7/nKx13y6BHgyq8o2oEQag8WoSN4TPqxBQrPV7iv47M= X-Received: by 2002:a05:693c:3005:b0:2ac:1a21:841d with SMTP id 5a478bee46e88-2baa7fbbf5fmr382130eec.16.1770846316595; Wed, 11 Feb 2026 13:45:16 -0800 (PST) Received: from fedora (c-67-164-59-41.hsd1.ca.comcast.net. [67.164.59.41]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2ba9dcd03d8sm2123316eec.21.2026.02.11.13.45.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Feb 2026 13:45:16 -0800 (PST) Date: Wed, 11 Feb 2026 13:45:13 -0800 From: "Vishal Moola (Oracle)" To: Dave Hansen Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, "Mike Rapoport (Microsoft)" , akpm@linux-foundation.org, "Matthew Wilcox (Oracle)" , Dave Hansen , Andy Lutomirski , Peter Zijlstra Subject: Re: [PATCH v5 3/4] x86/mm/pat: Convert pmd code to use ptdescs Message-ID: References: <20260211195233.368497-1-vishal.moola@gmail.com> <20260211195233.368497-4-vishal.moola@gmail.com> <29599d4e-c2c7-4f40-a444-28dcc3768ce4@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <29599d4e-c2c7-4f40-a444-28dcc3768ce4@intel.com> On Wed, Feb 11, 2026 at 12:07:05PM -0800, Dave Hansen wrote: > On 2/11/26 11:52, Vishal Moola (Oracle) wrote: > > Also, rename *_pmd_page() functions to *_pmd(). Rename them now to avoid > > any confusion later. Eventually these allocations will be backed by a > > ptdesc not a page, but that's not important to callers either. > > So, pages are still a thing, whether the API says 'struct page' or not. > The hardware kinda uses pages for page tables. ;) > > Could we please leave out the unnecessary churn from the renames? Yeah I'll drop the renames. I thought it'd be better for correctness-sake, as the idea is to "allocate memory for a page table" rather than "allocate a generic page for a page table." As long as its using the right APIs the naming doesn't really matter to me.