From: "Jose A. Perez de Azpillaga" <azpijr@gmail.com>
To: greybus-dev@lists.linaro.org, linux-kernel@vger.kernel.org
Subject: PATCH 1/1: greybus/usb: handle unspecified lengths in hub_control
Date: Wed, 11 Feb 2026 23:02:17 +0100 [thread overview]
Message-ID: <aYz8aUyx9W_IZD3F@fedora> (raw)
From 1e099b581fe475905509b9d600015ea2500b8cf8 Mon Sep 17 00:00:00 2001
From: "Jose A. Perez de Azpillaga" <azpijr@gmail.com>
Date: Wed, 11 Feb 2026 22:54:40 +0100
Subject: [PATCH] greybus/usb: handle unspecified lengths in hub_control
Fixes the FIXME in hub_control where response length was not handled correctly.
Signed-off-by: Jose A. Perez de Azpillaga <azpijr@gmail.com>
---
drivers/staging/greybus/usb.c | 16 +++++++++++-----
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/greybus/usb.c b/drivers/staging/greybus/usb.c
index 475f24f20cd4..f5f5a4863ddc 100644
--- a/drivers/staging/greybus/usb.c
+++ b/drivers/staging/greybus/usb.c
@@ -105,8 +105,10 @@ static int hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue, u16 wIndex,
size_t response_size;
int ret;
- /* FIXME: handle unspecified lengths */
- response_size = sizeof(*response) + wLength;
+ /* Calculate expected response size */
+ response_size = sizeof(*response);
+ if (wLength)
+ response_size += wLength;
operation = gb_operation_create(dev->connection,
GB_USB_TYPE_HUB_CONTROL,
@@ -127,9 +129,13 @@ static int hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue, u16 wIndex,
goto out;
if (wLength) {
- /* Greybus core has verified response size */
- response = operation->response->payload;
- memcpy(buf, response->buf, wLength);
+ size_t actual_size = operation->response->payload_size - sizeof(*response);
+ size_t copy_size = min(wLength, actual_size);
+
+ if (copy_size) {
+ response = operation->response->payload;
+ memcpy(buf, response->buf, copy_size);
+ }
}
out:
gb_operation_put(operation);
--
2.51.0
next reply other threads:[~2026-02-11 22:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-11 22:02 Jose A. Perez de Azpillaga [this message]
2026-02-12 11:43 ` [greybus-dev] PATCH 1/1: greybus/usb: handle unspecified lengths in hub_control Greg KH
2026-02-12 18:23 ` [PATCH v2] " Jose A. Perez de Azpillaga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYz8aUyx9W_IZD3F@fedora \
--to=azpijr@gmail.com \
--cc=greybus-dev@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox