From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 291D927E045 for ; Wed, 11 Feb 2026 22:02:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770847342; cv=none; b=cLcyXlPpJoH3GpWp3n5oQ+DQOK3jVALGJPF/CJVghI+hKbYiC+dPyXOAuJ4oSgyOhLG0oIwCNkvID11RpMbkAs8hQkLpQjQgj9pMy4dmQ/8gz/Piu1qOVa8gThs8tMSTM5lwVyaNEQ72vzJyzAFxiVhPqMFKMXl0j6hMKy2w0M4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770847342; c=relaxed/simple; bh=oK0HXAmQQ5ovk4s1xcf8wCb/Pcis6RDFVuacMLV36dM=; h=Date:From:To:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=Dgam2hd8y7n0ebTKAATkJhBjWAXpllb2ZWNwNawXNp416gY2Z0YQSlUsAW/Mjg6l+Ry6N6eO6ClgxPHWNNYMeddM0RJ0g58IhBcm/IvC91VQPQ7X+aFf3SXKDz4XF/lvUfG2E6AiWY3lpVhNPNKs7sSCGAK2FnDaBeKC2jNa1rA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Dqpm04OS; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Dqpm04OS" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-4362d4050c1so5725846f8f.2 for ; Wed, 11 Feb 2026 14:02:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770847339; x=1771452139; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=mHm+4A9zE9vLZYqsBw9MzVdAOAcFoDEVbjmqs7/Amh8=; b=Dqpm04OSFiUIfsEMJ87Y/wK5Q67tBJ0OmKevRZ29y5ikmQDR4V6fhIQpY0rY7z/Bvw /upDpdMApSvWXKfSYVemhxILzs9ZEB4PZjz0Pw7nRs3/zZKwGC6gi3ChcT8prjK9QWRH jEhyvS8v18svwC4K/L+QQJtXMEtgCItZUVRBxDD1CeQ2BxP3xQ7oTrzGl4rtGzPngOqt MNaL9pznb/x1+L9kg8A65wydDzI1tzmnbmQZjFAzpMpbm2ORnOKhkgIwvRaLUtHggUWu tDE4AR30lQ5TZGFiuMZ8BwdV2y/Vceqs9g6yhPqpn33qV09YZClB12VBOp8t+EEEZcuI xO5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770847339; x=1771452139; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mHm+4A9zE9vLZYqsBw9MzVdAOAcFoDEVbjmqs7/Amh8=; b=PUlEc6WRnjaCbmJjGtTryoG/pRnVLgfxGXvQupqjzqnxEkd30jZ1/6EliHTAOj5STn W7i1Is1at9n/3U6OWiwke11T4x+fSqKZQhHJm31owmpKTUBlPhVjjs9gbHgUWF2MWSku ToIR2nES4CogRCWr70jOrSQFaZWi4qn6KOyS4RCQEQ0IZVQ+Fc4he2brNigM1hCgU82P 5sFkBiOQp44XXmONT3ksVZdHoSBVcTtPxn3SIyMLq00ct101VSMlaOtyb6PiiOrbcgJi eCrKnRgem/91F93PZmA+VsWOQLkxSHGaD1UayQdx5UN32p9Hd4Ne7yyom8+rTAWrf3Yw LRFA== X-Forwarded-Encrypted: i=1; AJvYcCUmdVL4sRwHgiudhRXVGZvf5/gif8ucSAvaMxgOX85UXwyR7RsavNf6yUR5W5HUBOUqO3t218gimUeBsjc=@vger.kernel.org X-Gm-Message-State: AOJu0YzXTSj/MAQKAlvvjq/9QAdWUfiL5PZCm9gAZMmG+xdge4PPezz+ tjGZxuMr/knifdCEWYYMFqFAqp2S2gpzQZMjOJqD22vvVfqpI0OhrAWj X-Gm-Gg: AZuq6aKPJp7K2L1Xos6EDAx0FB/firk6kfn2IIOSjEf9TBB3o8ZW6BtiFE5TRKMIbea +q1ff8i7BKtHeLA+pM8cboVkGIp1+5CHZlWiPcuYB5UbuKdKofze5ZHRyvwC92bw4dYtyQGJbzc JZWSrsdeIKY0O4njHYabi4KHNmIN7R6o3278l+J3O/ZKrExg3lL7jxzFuJBen3dBAzHQCsxfNsO amHeLczSuL4wFdBfVdKgPedv3rNjm/WhHwNTlN0JUyB8TGnWSOFQfIo5t7QNn4btsgsgDnI43ms FisQlfS1nirjb4bQSSo/4gpALl7fgHRSCyePwG0KuJkWp0UkESMMiR8QW8c8Plm0nzgPD0lPTog VGIsZwxMlP9HrrKJHOTD1MEN3lpYqsZtaKiQOr0gug7kqGS9NuaKKQyUe9arlfB3dyrXKcapOcW v+T9uK1yCdY+oHNnYwHJEppzg= X-Received: by 2002:a05:6000:2407:b0:436:34c0:c9c8 with SMTP id ffacd0b85a97d-4378adc9cbfmr1276817f8f.60.1770847339219; Wed, 11 Feb 2026 14:02:19 -0800 (PST) Received: from localhost ([83.231.69.9]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43783d30f6dsm6859873f8f.3.2026.02.11.14.02.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Feb 2026 14:02:18 -0800 (PST) Date: Wed, 11 Feb 2026 23:02:17 +0100 From: "Jose A. Perez de Azpillaga" To: greybus-dev@lists.linaro.org, linux-kernel@vger.kernel.org Subject: PATCH 1/1: greybus/usb: handle unspecified lengths in hub_control Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline >From 1e099b581fe475905509b9d600015ea2500b8cf8 Mon Sep 17 00:00:00 2001 From: "Jose A. Perez de Azpillaga" Date: Wed, 11 Feb 2026 22:54:40 +0100 Subject: [PATCH] greybus/usb: handle unspecified lengths in hub_control Fixes the FIXME in hub_control where response length was not handled correctly. Signed-off-by: Jose A. Perez de Azpillaga --- drivers/staging/greybus/usb.c | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/drivers/staging/greybus/usb.c b/drivers/staging/greybus/usb.c index 475f24f20cd4..f5f5a4863ddc 100644 --- a/drivers/staging/greybus/usb.c +++ b/drivers/staging/greybus/usb.c @@ -105,8 +105,10 @@ static int hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue, u16 wIndex, size_t response_size; int ret; - /* FIXME: handle unspecified lengths */ - response_size = sizeof(*response) + wLength; + /* Calculate expected response size */ + response_size = sizeof(*response); + if (wLength) + response_size += wLength; operation = gb_operation_create(dev->connection, GB_USB_TYPE_HUB_CONTROL, @@ -127,9 +129,13 @@ static int hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue, u16 wIndex, goto out; if (wLength) { - /* Greybus core has verified response size */ - response = operation->response->payload; - memcpy(buf, response->buf, wLength); + size_t actual_size = operation->response->payload_size - sizeof(*response); + size_t copy_size = min(wLength, actual_size); + + if (copy_size) { + response = operation->response->payload; + memcpy(buf, response->buf, copy_size); + } } out: gb_operation_put(operation); -- 2.51.0