From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B9B053806A0 for ; Wed, 25 Feb 2026 23:15:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772061350; cv=none; b=qL3pt2MLksWSdD7o9BGnuXCPHmTU5y74ryHVaHxvzCAqF2ZCfFHViS870urzEoPYokXSk8DEFhO7Ubu/vOpsZADgGmzf5Mtc5tr0uBGoyygm3zIsLX8n1vvO48GNP+Ge7F2P1bdA80JW2WIT67g15vpzR99RMIhxlS6f8JSWdfA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772061350; c=relaxed/simple; bh=5WhoQCUa24yhiUF/WAnlscnk6BtiGnEv65SGVktgBo8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EiDMPPUp4NNNln9FtPZSwwjH3V4oGWhq0DtI4s5Odk0NTtDhUGnRfhqrK8mquIpNPnQH4xmoRZwpxf797cyAyV/EDPCJGWjRdtpeoF3vY5M/rdBKLM4gzvtRMeJ22x7AK8kkyIkvQ53R3CmBF0lFhtqVuFDTP3YIlwUjcBczWko= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=SAzDj0cM; arc=none smtp.client-ip=209.85.210.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="SAzDj0cM" Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-827307b12dfso114350b3a.1 for ; Wed, 25 Feb 2026 15:15:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1772061349; x=1772666149; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+aqTMCmmaBlC6BgaLKDJu82UvyrNA1bTtUP5fONJU9U=; b=SAzDj0cMcnIVDVrDDPPeF9qTI17Q90maO4BP4ziO34L6rUv6mL1YVRMwWENMo6UhoK S78EAj0tAdojwdpSjIA1UkcviDGE+9Lxu3qaHYDAc05L/iXb9ov7ebzJsisQrXP+7LBB QVHvs0lTdzYR0O90hbeUPUchlgS7775rDPTxygZUTyBZ3kfpKOm6XJ0Tt5imThS0a3sN wpGGuuvNGcQ+rBhHIy7hUPDjjGOFLsJGRKM0AyKSXOOc6Bb3Ybn1ReYri10kI2GEZEoD k9znRzQvb6GWXEr+5SAaHM1IYk2QE/OuzpOz/R81m/aBLtCV0eXShGkNMvVBmBfptHuz v9Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772061349; x=1772666149; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+aqTMCmmaBlC6BgaLKDJu82UvyrNA1bTtUP5fONJU9U=; b=DossHHH3BT6MZcKzqajG16r9CnOkpKlSzwV3z+un8HJpYewZ5zXQR+DrPvMD5hMjLg dyeyHlAC5b/3DWHANY4ZDkPssdCU/ZnzTFrxBGyr4aZNtYRy/zTgKRrua6LmVWHR90jQ 8CTYV5/eCizc6EThxWDwbF2aiIoRRjNABXzqqWtQNqzabE7Vx1EG80GuiY140rB8xZ4Q 1953VGqeKil1QquA7wgLLUlFqvnddC3LR49iXCGTjNZuHZ0rZVaer86AFqowB7yh2dJI f9Ka1nluUJVGE7bnlaQkX4rcodSnT1Zl5pTNw7T43MctVBVBpE+/PI+FdQnAmIURjR7k +F7A== X-Forwarded-Encrypted: i=1; AJvYcCWfu4AQFnghoo569IlDRn8Otg/FRrcYnISDVyJWyh8Qa8rYB9BO5Qi4zsxo+xiF7XaIc5D5Rzc6PWo0sg4=@vger.kernel.org X-Gm-Message-State: AOJu0Yz639xytI0oCs6NFIIvW33mQjoeUy8kU6nQlkQJS+TO/k/4Pz6V NKfBhUHUQgSstlLpo76LD8I0rMIEX7YCaRJbKs+9yr5w7FKTFe1MfKHDfm6a1y9Bzg== X-Gm-Gg: ATEYQzwDyCL8C9XeyZOqyb88R5DdHkt5MO3SVhY9Ap866iAV0zGa64f9FnGLTRw/l4Z tcUwQ7xbG47CNK9m97V5JFQqYG3AcfX9fOZWPN7AxjwYmL0eKwFMfxdZmxNb0j7stE1TENLdvYp mo9vXQxIfZhw4yR3kWCJBfHxtgiWBwLBJWH2cn9CALvEqmp1RLykOXOaK/qjfQABgBBhSgdj3zx bUhYc1mSYO33JK7QTXp2hXg6wwn5Ciqq0Ek6Ytojztc6tlYQvqXkN+95MamXCyZ7c+WnaAKOamQ Lp4/qajq4HX7EEEFv5jx55n6qvGiEogYkwqUCr21gN/gEUI8LJIed2eveJtd2M0S6qoCbWNtlMx 643FZdpcol3TGVnHISiFuRAGIL5lSZTmGOBh4tuwcJDOEG3XF0U6HgS2CjQ+2owfDgqzOgdOLvR 9U+ZAga7d20g37YsX9GwPANoiyGCXltWMCUjHoMsNIBmzPPtb+LbS3K2/26am3jw== X-Received: by 2002:a05:6a21:7e0c:b0:395:46aa:4467 with SMTP id adf61e73a8af0-395b1d39ecdmr623014637.14.1772061348571; Wed, 25 Feb 2026 15:15:48 -0800 (PST) Received: from google.com (239.23.105.34.bc.googleusercontent.com. [34.105.23.239]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c70fa8479aasm89953a12.31.2026.02.25.15.15.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Feb 2026 15:15:47 -0800 (PST) Date: Wed, 25 Feb 2026 23:15:43 +0000 From: David Matlack To: Alex Williamson Cc: Adithya Jayachandran , Alexander Graf , Alex Mastro , Alistair Popple , Andrew Morton , Ankit Agrawal , Bjorn Helgaas , Chris Li , David Rientjes , Jacob Pan , Jason Gunthorpe , Jason Gunthorpe , Jonathan Corbet , Josh Hilke , Kevin Tian , kexec@lists.infradead.org, kvm@vger.kernel.org, Leon Romanovsky , Leon Romanovsky , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-pci@vger.kernel.org, Lukas Wunner , =?utf-8?Q?Micha=C5=82?= Winiarski , Mike Rapoport , Parav Pandit , Pasha Tatashin , Pranjal Shrivastava , Pratyush Yadav , Raghavendra Rao Ananta , Rodrigo Vivi , Saeed Mahameed , Samiullah Khawaja , Shuah Khan , Thomas =?iso-8859-1?Q?Hellstr=F6m?= , Tomita Moeko , Vipin Sharma , Vivek Kasireddy , William Tu , Yi Liu , Zhu Yanjun Subject: Re: [PATCH v2 04/22] vfio/pci: Register a file handler with Live Update Orchestrator Message-ID: References: <20260129212510.967611-1-dmatlack@google.com> <20260129212510.967611-5-dmatlack@google.com> <20260225143328.35be89f6@shazbot.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260225143328.35be89f6@shazbot.org> On 2026-02-25 02:33 PM, Alex Williamson wrote: > On Thu, 29 Jan 2026 21:24:51 +0000 > David Matlack wrote: > > +int __init vfio_pci_liveupdate_init(void) > > +{ > > + if (!liveupdate_enabled()) > > + return 0; > > + > > + return liveupdate_register_file_handler(&vfio_pci_liveupdate_fh); > > +} > > liveupdate_register_file_handler() "pins" vfio-pci with a > try_module_get(). Since this is done in our module_init function and > unregister occurs in our module_exit function, rather than relative > to any actual device binding or usage, this means vfio-pci CANNOT be > unloaded. That seems bad. Thanks, Good point. So a better approach that would allow vfio-pci to be unloaded would be to register the file handler when the number of devices bound to vfio-pci goes from 0->1 and then unregister on 1->0.