From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46D402CCB9 for ; Thu, 26 Feb 2026 02:32:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772073131; cv=none; b=VTWxq56XqQMRlEpMD7J/poPjGX4KNMWRrnt851UU098dOMMiCEfouta7KpvFweIS5KxVJ+E3Fn2xVmJ8n8Tc3kF7vyjbyV8WTNYwQgGvLUzduk5fRr+muY/3gVZJVO8EoYuo+3aSXXdwb46awlI/reTRVeubwpyErU0+H6n94WM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772073131; c=relaxed/simple; bh=Vb89xHFzy54Wt00V2fX4v17/wwSsg8RCxSpcGohoye8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ebt5JdzN07rOZIXzyqP0oJBWzBrLxkYN53HJtOiWxAEaC8sCjI1EQYAL60Apoe0Hz55mygmboPBuHgH/126KSmt1emsLWCT8MaH7tttbrFNqf9NVtHxD3W0BzputsRXv9XZZQ+8LgrFz0ckdPthbth0r7B1DY+QtX+awiC3nMDg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kr3WqLM6; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kr3WqLM6" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-8230f2140beso931687b3a.1 for ; Wed, 25 Feb 2026 18:32:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772073128; x=1772677928; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=PyaLR/WAQ6lRZ3NjaSm33RIJgsY01uZatFM5bOpfcaQ=; b=kr3WqLM60W/lUwpVtWZc2NHs2qLsaZwibnH/RyQWwWdSaR/8CFBkQ7U/5CMkrOWVI9 J4v7Uv2jcWSTiG+o79YTyps+fEPXej3gM5Wka1jz9NQUmuRpY7A5gTIkaETrvj/v30m4 zHs5va8N3OIoW2o3kMYVPCiepu+hkNAJAqLIHIpvF6MzS0H5mVszkN+uxav6TCvjGG+S lrsamyW9EzxEg6UlDsXH3gb9SeJBvg3fO3XYvDaOvCP9uz2ZbabSd3nnF24iRNpsmVje MQBGa0B6IjNCsRIlLPrmfrwt+K7A6EjyKtGiObT+RHYltE4e8RI+v1yy/+kDCcTKpXou +nQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772073128; x=1772677928; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PyaLR/WAQ6lRZ3NjaSm33RIJgsY01uZatFM5bOpfcaQ=; b=muqMz7aIsl/Pet3+jvB5C/KoPe1uMRtTnln9oxC3HtI+zAHVDSrdT+BqsXG6NnEKHK WpwqGJl7yTCbS05m3Di/euZ8LPeJM8Rb1HhJnlQb5tTzswb5sRlJ4/jbXFs22bPLqPoL PoqzPlzfobZ8b+lINgsjEyey1d8v1DhYbpFvyBXrGNjjMzVpr6mVT4Fv3i261f4OOOyN c8WtdDPEBDKICSqTI1u+4qkZvQ3tkI2FHUH0KhWisU99qOLB7KwdXuJtcpjiO8ugAKIz HHOKhKSY0ZSh1LULCT44uptDqDL/2No2AWmH3c1rtJgB1VjCPHJmGgp/v32pin0geaMN ntSg== X-Forwarded-Encrypted: i=1; AJvYcCUE5nJCEOozZQ8+6Jzf+SycvcgJqCbhn9925DWfmBxBJFmfizWHOib1YckLbDz59CWP9UvA6XVyYzMNKWw=@vger.kernel.org X-Gm-Message-State: AOJu0Yw5fkfNzOLTlOoAl0ripwS22lx0ejrVEaK+O2jO8htP6y7fT1Bp w14wfmKIEdeDRX+u0uZ4UR7YwJ0wOTnJeftVVmchPuVzUtoa/DLK9PhK X-Gm-Gg: ATEYQzygle0hI8A/XPcpRt0Eroah8Y6nDEp6+SMrNhJ15+ZjMsoMvz2hdnOPgel6eas KXypZ6ccd+7oZVp7xbDIT7mqILPiiUj1Foi/oEbJXYy1xN2++lE+YpiOMmLryAYmejC66y6SEwn Lddgx/E4PyKa51F0YF486qvQm1mhFHZzuifEahU+R85zL7W8c3vslA78mp9/oDDDhjqRB4ChiP8 zU/XHS4VdSxVCt1126NxTwaWx+SKGbmg1voLYKMtX7mhyBKN+fu06PGrb5mpAEKR/5KE03NraMq 2zyhe2Uyo1wRrza8TI2gvTs/cSbYPVF8NqyRfclJOe7krk8lD59PzQ9zNlimfXCpXLEF7nHm9Se VmyHHm87MWyH3Anb6njFlq3xMU45T5GesjZOD1tv9fKzj5yQ6mss3RwQ6CU/2KlNTqjCjbufz86 6V35EqT7pOc/U6EQ== X-Received: by 2002:a05:6a21:7794:b0:394:64c1:da88 with SMTP id adf61e73a8af0-395b1d312f4mr1020060637.13.1772073128506; Wed, 25 Feb 2026 18:32:08 -0800 (PST) Received: from localhost ([27.122.242.71]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-359034bbfd4sm4114745a91.10.2026.02.25.18.32.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Feb 2026 18:32:08 -0800 (PST) Date: Thu, 26 Feb 2026 11:32:06 +0900 From: Hyunchul Lee To: Ethan Tidmore Cc: Namjae Jeon , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ntfs: Fix null pointer dereference Message-ID: References: <20260225222453.1962678-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260225222453.1962678-1-ethantidmore06@gmail.com> On Wed, Feb 25, 2026 at 04:24:53PM -0600, Ethan Tidmore wrote: > The variable ctx can be null and once confirmed to be null in its error > path goes to label err_out. Once there it can be immediately dereferenced > by the function ntfs_attr_put_search_ctx() which has no null pointer check. > > Detected by Smatch: > fs/ntfs/ea.c:687 ntfs_new_attr_flags() error: > we previously assumed 'ctx' could be null (see line 577) > > Add null pointer check before running ntfs_attr_put_search_ctx() in > error path. > > Fixes: fc053f05ca282 ("ntfs: add reparse and ea operations") > Signed-off-by: Ethan Tidmore Looks good to me. Thanks for the patch. Reviewed-by: Hyunchul Lee > --- > fs/ntfs/ea.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/fs/ntfs/ea.c b/fs/ntfs/ea.c > index 82ad9b61ec64..b2b0a9a043a9 100644 > --- a/fs/ntfs/ea.c > +++ b/fs/ntfs/ea.c > @@ -684,7 +684,8 @@ static int ntfs_new_attr_flags(struct ntfs_inode *ni, __le32 fattr) > a->flags = new_aflags; > mark_mft_record_dirty(ctx->ntfs_ino); > err_out: > - ntfs_attr_put_search_ctx(ctx); > + if (ctx) > + ntfs_attr_put_search_ctx(ctx); > unmap_mft_record(ni); > return err; > } > -- > 2.53.0 > -- Thanks, Hyunchul