public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Teddy Astie <teddy.astie@vates.tech>
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
	Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Subject: Re: [RFC PATCH] x86/xen: Consider Xen PVH support in CONFIG_XEN_PVHVM
Date: Tue, 24 Feb 2026 15:26:21 +0100	[thread overview]
Message-ID: <aZ21DQLRzeyStl-0@macbook.local> (raw)
In-Reply-To: <962fa327-2e9f-41e5-8382-71ace6fb0a10@vates.tech>

On Tue, Feb 24, 2026 at 12:34:31PM +0000, Teddy Astie wrote:
> Le 24/02/2026 à 12:16, Roger Pau Monné a écrit :
> > On Tue, Feb 24, 2026 at 10:51:35AM +0000, Teddy Astie wrote:
> >> It's currently possible to build Linux with CONFIG_PVH|CONFIG_XEN_PVHVM
> >> and no CONFIG_XEN_PVH. That leads to inconsistent kernels that fails with
> >> "Missing xen PVH initialization" when booting using PVH boot method or
> >> display various errors and fail to initialize Xen PV drivers when booting
> >> with PVH-GRUB.
> >>
> >>      platform_pci_unplug: Xen Platform PCI: unrecognised magic value
> >>      ...
> >>      # modprobe xen-blkfront
> >>      modprobe: ERROR: could not insert 'xen_blkfront': No such device
> >>      # modprobe xen-netfront
> >>      modprobe: ERROR: could not insert 'xen_netfront': No such device
> >>
> >> When built without CONFIG_XEN_PVH, PVH-specific logic is disabled, hence when
> >> booting with e.g PVH-OVMF, Linux assumes we are a HVM guest, even when we aren't
> >> actually one (in the "with HVM emulated devices" sense).
> >>
> >> As it is actually possible to boot Xen PVH without CONFIG_PVH; and that most
> >> Xen-related logic exist within CONFIG_XEN_PVHVM; consider PVH guests support
> >> within CONFIG_XEN_PVHVM instead of CONFIG_XEN_PVH.
> > 
> > So the current CONFIG_PVH selection done by CONFIG_XEN_PVH is moot?
> > 
> >> Keep CONFIG_XEN_PVH as a shortcut to enable PVH boot, ACPI support and PVHVM.
> >>
> >> Signed-off-by: Teddy Astie <teddy.astie@vates.tech>
> >> ---
> >> Cc: Juergen Gross <jgross@suse.com>
> >> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> >> Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> >>
> >> A tentative patch, I'm not sure of the way of dealing with the KConfig part,
> >> keeping CONFIG_XEN_PVH as a shortcut is interesting, but there may be other
> >> options.
> >>
> >> There are widespreadly used Linux distributions that have a similar configuration
> >> to this one, thus exhibit this issue i.e fail to boot.
> > 
> > Do you know the underlying cause of not enabling CONFIG_XEN_PVH?  Is
> > the default set to n on the defconfig?  Or are distros specifically
> > disabling this option on purpose?
> > 
> 
> I'm observing in these distros that
> 
>  > # CONFIG_XEN_PVH is not set
>  > CONFIG_XEN_PVHVM_GUEST=y
>  > CONFIG_XEN_PVHVM=y
> 
> Which makes CONFIG_XEN_PVH defaults to n.

We should possibly send a patch to those distros Kconfig to enable
CONFIG_XEN_PVH?  I think it's a bug on their side that Xen PVH is not
enabled.  Us trying to workaround this in our Linux Kconfig options
seem wrong.

Thanks, Roger.

      reply	other threads:[~2026-02-24 14:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-24 10:51 [RFC PATCH] x86/xen: Consider Xen PVH support in CONFIG_XEN_PVHVM Teddy Astie
2026-02-24 11:01 ` Jan Beulich
2026-02-24 11:13   ` Jürgen Groß
2026-02-24 11:14 ` Roger Pau Monné
2026-02-24 11:23   ` Jürgen Groß
2026-02-24 12:46     ` Teddy Astie
2026-02-24 13:53       ` Jürgen Groß
2026-02-24 12:34   ` Teddy Astie
2026-02-24 14:26     ` Roger Pau Monné [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aZ21DQLRzeyStl-0@macbook.local \
    --to=roger.pau@citrix.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=jgross@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleksandr_tyshchenko@epam.com \
    --cc=teddy.astie@vates.tech \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox