From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C1D9376BE5 for ; Tue, 24 Feb 2026 14:42:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771944176; cv=none; b=WTTwenkIX+P0jMOvzvYVJal2dCrMQC2kfiDQryvj2kbl1mGZ49x/5Zq4U5fqWlKNs1SojSjCTQbCm8CjWVbxzJlBCj6ZTpSBjggU2gp6VDv2381c8JdWd2L8KV0WTLZgh1Cnn49xW41tRwP7txiU6V4Kp/jNx73m0oFcXeduF7k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771944176; c=relaxed/simple; bh=TRs6fgkQYCZmT3snZ+87Qz6FxsRhtiQwZHuPDvKLEcM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CgojtWpVCFKVSQcuzCOonnK152UNbUe0t+dQy9x2v/RswQKj56ZhRegfU+rVm4MUutBnTecKeiPzoxfpplIeYFADhMX7WJbBvyk2q6irGua5VcEbpbzzS2JkQ91IG9TmdJG1e7fRs32Eqfl52+qMhuXhwRVxhGQanbDYhXzVrqU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fvSvfMxh; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fvSvfMxh" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-4807068eacbso44056615e9.2 for ; Tue, 24 Feb 2026 06:42:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771944173; x=1772548973; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=TRs6fgkQYCZmT3snZ+87Qz6FxsRhtiQwZHuPDvKLEcM=; b=fvSvfMxh4oLcgJO9kOPO+iboVdl7woS6DAdDmISdjnuWTjuTDz2W1BbwyncjiB41i0 xqA5bK81c8dbl2AFLiLv6zjrYbtjn5u4P8JchfBWS52STqmUCsajOlKApBEX5jjbJygJ dzwy5dMFHO4iMOR9AzZtMoF60a8B+9tCVvxeV9nneFPSVyG1c1kdlaBI1ovKA3JxFuhc GWvTaXeB4iojeDTBJaFdhV2JtKBHMAqcoUKSa7vatb9l829vST1kBDo15mTa+91Us14w aFwT9wEIqcd3lB3il7le9wJUwllsLuR3ZTcTETxh5dZqTqzAhPGjtO96l6xbirYb/NbT zLHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771944173; x=1772548973; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TRs6fgkQYCZmT3snZ+87Qz6FxsRhtiQwZHuPDvKLEcM=; b=eLWRswI74GynI6RR91QWmjK3bOGbN1KYsfJR5USBNihongpGzXemuNmFJAjegqR6V7 psowBY0LLjJCtwL9/fp/nN/vW3j/kpAexRdH1drCi1oyC6qMEERtnVQ89pS+Y1jmV+oQ ckNIvGERSKDFK+hlTdgZrV/Nifv55uASRcra3+CYDYm9tBuPcCZhGV5VPlI/u6xSFuZ9 s5kUuuotee0igxDjmnFNu4XWUJQtfP4SkNGQBQ/hMCM8WZwsLRXPsXr2vkMYZ8D3lf45 sVR4cvVgIxI2CIXYuAXzKzQ4sF8lF+nuoLMCuxykcvcAN5I4PkNko0tj3f5NkaAtQddK Fgaw== X-Forwarded-Encrypted: i=1; AJvYcCUnYpHbxRhZH0x054ryKUcVkKYUzHboOodG/sj1a5OBRb1vsErgBc+AdDP3BYh4fg+36bmRiVWtZGzQL3w=@vger.kernel.org X-Gm-Message-State: AOJu0YwAHy0K762ulb8+rzfVDZelG7Ndz18GEPrjV1a96mfs2ObunavN NBF3bxTwPnEtXz7i8b0lQchCQT2056tikTungEupLQZDPbLjR/5g8DCN X-Gm-Gg: AZuq6aKdPxeavNWsW3suMHlso1KRzucgA+PnYhtREPSdHU9R0HFriBKgb0q5+GmqK4N gnNxr0D51dUysaY1JK5IKW+g8AV/aI06ye20ncTOGMMPBOCtg04WA4J4CbO0eru4yiNhFtqaugx amKKWL5zV8frdkuFtN0DJQfBzwagXIIBnyUej/ZpmczsE6RvDodR0GaoXZF/geJWJOdez9Iyzrn jiEeovB9Ar7yCjZc5VrX06iKeJaVaolx6GlQHkSHhsy8ARsdG6U9aGhH71lcV8WJGT6PKImGzPf LPafqmORt2d4QVipJR8PT7sTXAdfWK3citALwe7QHKm8w3ZPGkjG9KWu2hLmXxLxdDBViYM8rQg vbtEiXitvdguRaNarzf2mlCEkVoOogPy0x2A0DbuzNJQjrf99GfsJ38v9GrsnvysC0agxNrjWel h7h2OVM9aJGEYGo/JpVndN2qyn X-Received: by 2002:a05:600c:3b10:b0:471:700:f281 with SMTP id 5b1f17b1804b1-483a95e5b24mr202226015e9.25.1771944173275; Tue, 24 Feb 2026 06:42:53 -0800 (PST) Received: from fedora ([146.70.134.19]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483b8902ed2sm20141925e9.20.2026.02.24.06.42.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Feb 2026 06:42:52 -0800 (PST) Date: Tue, 24 Feb 2026 15:42:49 +0100 From: Filippo =?utf-8?B?TXVzY2hlcsOg?= To: Andy Shevchenko Cc: jdelvare@suse.com, andi.shyti@kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] i2c: amd8111: Switch to pcim_enable_device() and pcim_request_region() Message-ID: References: <20260224102216.17606-1-filippo.muschera@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Feb 24, 2026 at 12:38:13PM +0200, Andy Shevchenko wrote: > Looking at the code now I see the difference this patch may bring. > I was under impression that there is pci_enable_device() already in > the code. But it is not the case, which makes quite a different > enumeration flow (it will write CMD register and touch some bits > that might be sensitive). While the code looks okay and I can even > Acked-by: Andy Shevchenko > the change needs to be tested on real hardware before going in. Hi Andy, Thanks for the review and the Acked-by. Unfortunately I don't have access to an AMD8111 system to test if pcim_enable_device() causes any regressions. I completely see the point you're making now. I was focusing purely on the API modernization and I didn't consider these legacy implications. I leave it entirely up to you and the subsystem maintainers whether to queue this patch for testing or just drop it to avoid any risks. Best regards, Filippo