From: Keith Busch <kbusch@kernel.org>
To: Caleb Sander Mateos <csander@purestorage.com>
Cc: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>,
Chaitanya Kulkarni <kch@nvidia.com>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/7] nvme: set discard_granularity from NPDG/NPDA
Date: Tue, 24 Feb 2026 08:15:21 -0700 [thread overview]
Message-ID: <aZ3Aib5gQlIiIaEp@kbusch-mbp> (raw)
In-Reply-To: <20260221033302.1451669-6-csander@purestorage.com>
On Fri, Feb 20, 2026 at 08:33:00PM -0700, Caleb Sander Mateos wrote:
> @@ -2113,11 +2114,27 @@ static bool nvme_update_disk_info(struct nvme_ns *ns, struct nvme_id_ns *id,
> else if (ctrl->oncs & NVME_CTRL_ONCS_DSM)
> lim->max_hw_discard_sectors = UINT_MAX;
> else
> lim->max_hw_discard_sectors = 0;
>
> - lim->discard_granularity = lim->logical_block_size;
> + if (ctrl->dmrsl && ctrl->dmrsl <= nvme_sect_to_lba(ns->head, UINT_MAX))
> + lim->max_hw_discard_sectors =
> + nvme_lba_to_sect(ns->head, ctrl->dmrsl);
> + else if (ctrl->oncs & NVME_CTRL_ONCS_DSM)
> + lim->max_hw_discard_sectors = UINT_MAX;
> + else
> + lim->max_hw_discard_sectors = 0;
Something seems off about this patch: these last four new lines added
here are the same as the unmodified lines preceding it.
next prev parent reply other threads:[~2026-02-24 15:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-21 3:32 [PATCH v2 0/7] nvme: set discard_granularity from NPDG/NPDA Caleb Sander Mateos
2026-02-21 3:32 ` [PATCH v2 1/7] nvme: add preferred I/O size fields to struct nvme_id_ns_nvm Caleb Sander Mateos
2026-02-21 3:32 ` [PATCH v2 2/7] nvme: fold nvme_config_discard() into nvme_update_disk_info() Caleb Sander Mateos
2026-02-24 14:29 ` Christoph Hellwig
2026-02-21 3:32 ` [PATCH v2 3/7] nvme: update nvme_id_ns OPTPERF constants Caleb Sander Mateos
2026-02-24 14:30 ` Christoph Hellwig
2026-02-21 3:32 ` [PATCH v2 4/7] nvme: always issue I/O Command Set specific Identify Namespace Caleb Sander Mateos
2026-02-21 3:33 ` [PATCH v2 5/7] nvme: set discard_granularity from NPDG/NPDA Caleb Sander Mateos
2026-02-24 14:33 ` Christoph Hellwig
2026-02-24 15:15 ` Keith Busch [this message]
2026-02-24 16:05 ` Caleb Sander Mateos
2026-02-21 3:33 ` [PATCH v2 6/7] nvmet: use NVME_NS_FEAT_OPTPERF_SHIFT Caleb Sander Mateos
2026-02-21 3:33 ` [PATCH v2 7/7] nvmet: report NPDGL and NPDAL Caleb Sander Mateos
2026-02-24 14:34 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZ3Aib5gQlIiIaEp@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=axboe@kernel.dk \
--cc=csander@purestorage.com \
--cc=hch@lst.de \
--cc=kch@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox