From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Fuad Tabba <tabba@google.com>
Cc: Kees Cook <kees@kernel.org>, Andy Shevchenko <andy@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org,
will@kernel.org
Subject: Re: [PATCH] lib/string: Fix UBSAN misaligned access in sized_strscpy
Date: Tue, 24 Feb 2026 19:21:47 +0200 [thread overview]
Message-ID: <aZ3eKyVXPd-Fvcst@smile.fi.intel.com> (raw)
In-Reply-To: <20260224170427.2296592-1-tabba@google.com>
On Tue, Feb 24, 2026 at 05:04:27PM +0000, Fuad Tabba wrote:
> sized_strscpy() performs word-at-a-time writes to the destination
> buffer. If the destination buffer is not aligned to unsigned long,
> direct assignment causes UBSAN misaligned-access errors.
>
> Use put_unaligned() to safely write the words to the destination.
Have you measured the performance impact?
Have you read the comment near to
if (IS_ENABLED(CONFIG_KMSAN))
?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-02-24 17:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-24 17:04 [PATCH] lib/string: Fix UBSAN misaligned access in sized_strscpy Fuad Tabba
2026-02-24 17:21 ` Andy Shevchenko [this message]
2026-02-24 17:54 ` Fuad Tabba
2026-02-24 23:06 ` David Laight
2026-02-25 8:33 ` Fuad Tabba
2026-02-25 10:11 ` David Laight
2026-02-25 11:09 ` Fuad Tabba
2026-02-24 21:07 ` Kees Cook
2026-02-25 8:08 ` Fuad Tabba
2026-02-25 9:32 ` Andy Shevchenko
2026-02-25 14:40 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZ3eKyVXPd-Fvcst@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=akpm@linux-foundation.org \
--cc=andy@kernel.org \
--cc=kees@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tabba@google.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox