From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f169.google.com (mail-dy1-f169.google.com [74.125.82.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4560F34B1A1 for ; Tue, 24 Feb 2026 22:45:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771973156; cv=none; b=Ceh8Ddwtj+AVdHfrM8PHtHR8o2ihfiv0wrM+cwRLCUW9laW6dax6IKmDSvA2eS2Fg7fuQ5rMNPHWblLpWibnmVaitQ63B/6nadfIJgK9w+3Zmv8V26RUVMg+wVzo4b0SV6J9+upE5S0iu4NkRmYjWwGs2izcn+rlLATsbNMDyYk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771973156; c=relaxed/simple; bh=TYBiyejN0jz0+b/rgo7kDkzVulDkERlKSoX28q5x02c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LkQa5mM3XM7xviL98B+ctjYbhl8Swiq2bn0+UIAILGmbM/1NG+B6vqqEjYgFLPv/XvnIbwy4zP60simrBNclhrf9JehOkJjScCaac/E0iJE1qNrLkIhETQq5ztqBkCcFLZx6tqsGn2RV9rlYOG276UeN6M931lcZqSb0fmwJJmQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=k//6xXNL; arc=none smtp.client-ip=74.125.82.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="k//6xXNL" Received: by mail-dy1-f169.google.com with SMTP id 5a478bee46e88-2bdbe434b47so845455eec.1 for ; Tue, 24 Feb 2026 14:45:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771973154; x=1772577954; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=e2wPLOGaHE2wd2tfpX30LfpnZoC91AB69pgJ3FbTup0=; b=k//6xXNLzoZbvfkKhJ3SBo0klkStq3XzRs7mBGOf3Pl7Z8oIhW7jCwFW9kDQB4tEYc oJyM9rZMM+wzKDVlfwykaeG+YJSAlSLRZZBOz6CzMKkmkWoswGC1RZlqtJaXYmVjjLdw zeqD7vobYEx9UsT7ZJSIr051VEHusd7tk63NqAmTgGhbHPDpcuyp8EY7VdRAwJ+JOv4V zPa00if1XX9MNIP6GgoOHE1mzdvNkiGAKkGs0bhv5HBxmgpLzOj0UWibHLcxQpF2pCuP QQl0Ylz+Q9gWbWlz0uXqsm2E8u78cQ4WOfKaXHT6MVrFPYZQQKqirdsHNoMCOyK5tenb suBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771973154; x=1772577954; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=e2wPLOGaHE2wd2tfpX30LfpnZoC91AB69pgJ3FbTup0=; b=HVVTs+GdJLxZTlScC6KukeozpNJcGw39hoWBpOH5GBvvFy9FZ6E4KfV2pCee4w1SWK PkALAcQM0qiv8+QFsZ+P/vauLs6DeQEJ2p4emxMc/WzchOKNBG18wp2Ok8Q3WEgGoACA E4Gwn+3Ule8bT9/C6cD1dZZEQKbwzMaSLqykH68xNbyIAfEjH1w6lY2Dr07Vsc+lZULC 81TQUucYqQ+6os4kkU4wua0QhlHcd0bjHsZdIqIZLBgDIfi0qjglHpxTReQPQyaFqLm5 XvMGkVzHe4Y15yVWpxZoJoMI31Q5sttiw0BR+toZgUcsBD7QaWm12PZBEyqH+A18HlB2 ja5Q== X-Forwarded-Encrypted: i=1; AJvYcCVmTpjV3XcO99V1XI15SJ09/7+E3jz4Z/RWmOnSeakwZpabZBOswdthQ1RgpSQgWVotCK0BqY34g321dbg=@vger.kernel.org X-Gm-Message-State: AOJu0Yxsl+8r/fgDCUzQely3B41adpiDYMhDPET/ag0hGcz4cxqcrBuK JtXb/CbPEMGrTSZyoM0BoExuogCO6AqAp3hSyIxwknGoM3SjwGnkNvOYDuWKhA== X-Gm-Gg: ATEYQzzh5lOvIcKtthT+2EMiszKdjFziPswBrdJIZCRDW0pcrO3G1cRslKBaE554aoq QUOV3Ey+/ijGz9F9OPLFnngb9biYK/eXDQ/bAJy3MQCvUjKHQ8bVxUa40/74UFmbAX3TYg5LJLq yIizHaunMLBBXqkIusxrjlFNjc6tieWRhOOZ5j7ra/+s7MCPgM641v28mGRlxZZES0oc7r7uKOk gxWZGqiD6oYnMe0VHelFCl9pMD3hPmnY1uYpeJ7zHi2D8aTjAPO7koxzQ6xTXqmfWJ5KRZcIw6j GckjVn3PtWVr8H9Em2vdYX53MDGm4Ftq1DTaSPtKaGYQqix5Xc06Xh6G7kFnruXcDH8+42wZeDo frJzHDwuqp7l9TB7FlfTOMsZH9Ozq09oBChmYOa6fCqUnucQ1j1c56eH9DvxQsZsCQk1oPg9wyY L7hAdAcT3aU8571mMk4hovod16zd6MAb7tsWDpQuk8U6weGj6tQiIGFXwfWxsP/cmR X-Received: by 2002:a05:7300:1904:b0:2ba:8018:cc53 with SMTP id 5a478bee46e88-2bdc34136d2mr51884eec.35.1771973154321; Tue, 24 Feb 2026 14:45:54 -0800 (PST) Received: from google.com ([2a00:79e0:2ebe:8:e1d3:e70f:c61b:7501]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2bdbc90844csm1165762eec.26.2026.02.24.14.45.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Feb 2026 14:45:53 -0800 (PST) Date: Tue, 24 Feb 2026 14:45:51 -0800 From: Dmitry Torokhov To: Yauhen Kharuzhy Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Hans de Goede Subject: Re: [PATCH v2 4/5] input: drv260x: Fix unbalanced regulator_disable() call Message-ID: References: <20260215141435.727872-1-jekhor@gmail.com> <20260215141435.727872-5-jekhor@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Feb 19, 2026 at 12:11:47PM +0200, Yauhen Kharuzhy wrote: > On Wed, Feb 18, 2026 at 06:43:30PM -0800, Dmitry Torokhov wrote: > > Hi Yauhen, > > > > On Sun, Feb 15, 2026 at 04:14:34PM +0200, Yauhen Kharuzhy wrote: > > > +static void drv260x_remove(struct i2c_client *client) > > > +{ > > > + struct drv260x_data *haptics = i2c_get_clientdata(client); > > > + > > > + regulator_disable(haptics->regulator); > > > } > > > > This will result in power being shut off the first thing during > > unbinding, which is too early. > > > > I switched this to devm_add_action_or_reset() and applied. > > Do you mean that, in this case, regulator_disable() may be called before any > devm_* registered actions? Good point, thanks. > Yes, all devm* actions are run after remove() completes. Thanks. -- Dmitry