From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF53129D260 for ; Wed, 25 Feb 2026 02:49:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771987761; cv=none; b=eR9s8z+qLB6GDmv7LKinQtn5ecneBmccEvLgVxMp4ylVPMI/vQ0wkuuiYKplDfIFDLxc359mCqlqImAm5AfsqY447MxiE4neWGWiHrCeOO2qJ/HRxCvDzHnC4YIlJBeeuSBBkGumGdNbMCjdmHvm14h1YFSq1MHtwDDT2F6oP3Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771987761; c=relaxed/simple; bh=4HFrWpFXHStHyAJDRKafDSwsXeaiBR4GTYw95WU4oD4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lLcwIRJhY5KpeAzVJ9Lavljkt7HAyKgk16TPMN0UADvW5WS/Sn8gpXfEdHAqz6z9IWGtv0/ihTh9R36VWyms/A3EnSJU7XKEWlbzUyoNdNi2BgFbQCFiR6KwOMSoj0nSMSUJ6wPK0zqnMBiLQqEtUNeENbt8I8IbaRIRiyZSCmI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=AC95wuQu; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AC95wuQu" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1771987759; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pjB7FH+yEMTAbO/yiMu0jHt9Q1j6LBXFMbedN1pzql8=; b=AC95wuQuHxeCjkUId4/MVDD1R/mbUYNDeiSkqjVPXK7bJ7+c3QtrVE9D0cHNxSVux0LbAn ALpYbzcWsuTr16VkrcbgEoIadrLIT2YfCT/hzomonkX00aqt6ecE6b+nJ7eDUG6PdnQDiL gMOnD6cFiY9l2zUl2nvZjydigHQU+BA= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-375-DJGhvPOKNaqfIszjs92zww-1; Tue, 24 Feb 2026 21:49:14 -0500 X-MC-Unique: DJGhvPOKNaqfIszjs92zww-1 X-Mimecast-MFC-AGG-ID: DJGhvPOKNaqfIszjs92zww_1771987753 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7F54119560A7; Wed, 25 Feb 2026 02:49:12 +0000 (UTC) Received: from fedora (unknown [10.72.116.18]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9B57F1955D71; Wed, 25 Feb 2026 02:49:06 +0000 (UTC) Date: Wed, 25 Feb 2026 10:48:56 +0800 From: Ming Lei To: Caleb Sander Mateos Cc: Jens Axboe , Keith Busch , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 7.1] ublk: report BLK_SPLIT_INTERVAL_CAPABLE Message-ID: References: <20260224155724.3142007-1-csander@purestorage.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260224155724.3142007-1-csander@purestorage.com> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 On Tue, Feb 24, 2026 at 08:57:22AM -0700, Caleb Sander Mateos wrote: > The ublk driver doesn't access request integrity buffers directly, it > only copies them to/from the ublk server in ublk_copy_user_integrity(). > ublk_copy_user_integrity() uses bio_for_each_integrity_vec() to walk all > the integrity segments. ublk devices are therefore capable of handling > requests with integrity intervals split across segments. Set > BLK_SPLIT_INTERVAL_CAPABLE in the struct blk_integrity flags for ublk > devices to opt out of the integrity-interval dma_alignment limit. > > Signed-off-by: Caleb Sander Mateos > --- > drivers/block/ublk_drv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/block/ublk_drv.c b/drivers/block/ublk_drv.c > index 004f367243b6..34ed4f6a02ef 100644 > --- a/drivers/block/ublk_drv.c > +++ b/drivers/block/ublk_drv.c > @@ -806,11 +806,11 @@ static void ublk_dev_param_basic_apply(struct ublk_device *ub) > set_capacity(ub->ub_disk, p->dev_sectors); > } > > static int ublk_integrity_flags(u32 flags) > { > - int ret_flags = 0; > + int ret_flags = BLK_SPLIT_INTERVAL_CAPABLE; > > if (flags & LBMD_PI_CAP_INTEGRITY) { > flags &= ~LBMD_PI_CAP_INTEGRITY; > ret_flags |= BLK_INTEGRITY_DEVICE_CAPABLE; Reviewed-by: Ming Lei Thanks, Ming