From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3AD429B76F for ; Wed, 25 Feb 2026 06:46:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772002009; cv=none; b=FEXms7LKma+c2EJHuy/V3uBlG05p0vvt2Opdt+02v+ogXfSmOmfhRI2nLIz8ZRs9BB5VzoM+msJq+0HdMFtQgiLJmoIG0Nv+9gLi4MEhGmn0sra+cgtlxe1mLNYYvXnqWychwVgNkOUmg0VGgRHgKmVIGV3O9Q8KvaMg/5RRUhM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772002009; c=relaxed/simple; bh=OsnoBlqsPRRMXQFggZjPmq6tctmLvwEZvl5IlaqGnas=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Pbiyh8mu61gcDMlkj2eVtJc1KpRo3JFk9wYIVK1LEfPfVSBY4fbqSgXON86PTUJcPqE+9qZ2iAGQYNpGvFboIFxQzJVi+1z/pSpA0yo/lp4LWkc47LX1CkqOjC1LrQixx1rKYX3u9oktco7TmdLmiOkammCbTuLBvBpHPDcYVsk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=mu2bHQ9h; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="mu2bHQ9h" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-48371bb515eso78446175e9.1 for ; Tue, 24 Feb 2026 22:46:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772002006; x=1772606806; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=e4NMqbshYRxO5mZM7OEYhfcX1DI7UCXh3U+W732gQjU=; b=mu2bHQ9h17nqcWKQe3BW/OaFtyaFmcmfr2jIJXxDal+M9njpkGhjF29dGudPNXhgGc 6QGD0ZVesnljsnOgoTUhh9vigXRrTfWgB0yCznANNBYXITD/5Fvc6kETAJBRDMepvSmw viO0ITerjZvKIY1sHQs/aVeX+q+51C6AjqvgOL1i7ZyAEQFUAj80pv33F8KdxQz50U95 hLuKYiTw1wzFNM6s5Y2HngJxAHYBu3xVbxqFQn7OddbaEq17WBzaS+XUnwhjpSUDkxNH jdUORLesxlNj6nO7zS6R7sTQ+ku1KeR4h8NLsH9Mj/UnIvEqQq1G/X5FBCF65kUiotDD bsAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772002006; x=1772606806; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=e4NMqbshYRxO5mZM7OEYhfcX1DI7UCXh3U+W732gQjU=; b=mNCjWV6e4KMQY7BC0oBcC14tegNeFVHT6aj4S9zjcYXzh4o714lpy0Ao0aOvL278X9 IwCCZqNGkug6NAnvUUWyD6FnvjiaazCxNU4eHzUPYPbne0wdTEJ+Ndb8E3MJSHBVun0H e46UJ32EwNUhrOpJd5l0JSUWRPH7RXK2lycS8meehwMbqE7I51hkAnnKWOgfneC0L2wt IiKIL/Eve5M620ixecO2URlzFXlIIKTDo3pjL5u8SLUTuVsfjt/1dvy3/rRQFDjDKnvB SDTVfi74KQgGdkJYomBo5pSb0UGNVlYXvxLFlItEf2HpAISfOdQ63Bmc4SLbZd8MUW9+ vmsw== X-Forwarded-Encrypted: i=1; AJvYcCWl9ne/L4qH6xJYB2blOVH+4sUwIj7icCA9003x/xmRSeAODoh4VRbUeTyA23Ef+BVtVWx7wkvZCkiXyb0=@vger.kernel.org X-Gm-Message-State: AOJu0Yzo8jYKL0kTCrmZ92Md/+RkukK8DctD/IcZb26g3wpDr8WgWQyw UBSg5rsjnPBjRd4iWU6fC7Qgh7wFqIJvn17EvGk6WdWbVPMJwluM8SrPiuSI+W3PoIk= X-Gm-Gg: ATEYQzwk7kYsRdSDP44516/xjQK8Rg/NESip8gs2EtBSgCq3LbCkKPNRP1a7Ce1/tc3 ojwYODFD/Efrw1ToPAYbksbATpszTtJ5UJKmcMGuQ+ifNBpd8lz5dAB+9JQ7O7I6pow+E7duCuO Ku4VOv+OObadTwh7T8WzN0xV3Ycq5dLY7GCasuIg1t5yT1EZXzx0jPTCU+5HRURhV+ynrgviAX2 8zl0BZUR3Ok1lFp1F2kd0spIsX1Yow7va2bTA9GPyc1Jd7X07zuwZ+HQNV9lq7v9r7B9E7f0BOL 1qnksz+ePCKRvCGNlwfHkZH00yk7JNUsyyyZAzN2E/TurxIk3Oqy2qktdHlshvXizXn7ItcqSng BaHWVhQ8SzEuUxIeCQqLCXjSBUIMKMQCReoJaIL168Z3VGK3viJ8M2o+db4h8wPKxeQh6ZzuSAe 69ujb0c+RjCzqkUYdJY1ENjaPQA23f X-Received: by 2002:a05:600c:3553:b0:47e:e87b:af8 with SMTP id 5b1f17b1804b1-483a962e491mr243587295e9.21.1772002006146; Tue, 24 Feb 2026 22:46:46 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483bd70b3f3sm51906145e9.6.2026.02.24.22.46.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Feb 2026 22:46:45 -0800 (PST) Date: Wed, 25 Feb 2026 09:46:42 +0300 From: Dan Carpenter To: luka.gejak@linux.dev Cc: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 1/1] staging: rtl8723bs: fix potential out-of-bounds read in rtw_restruct_wmm_ie Message-ID: References: <20260224132647.11642-1-luka.gejak@linux.dev> <20260224132647.11642-2-luka.gejak@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260224132647.11642-2-luka.gejak@linux.dev> On Tue, Feb 24, 2026 at 02:26:47PM +0100, luka.gejak@linux.dev wrote: > From: Luka Gejak > > The current code checks 'i + 5 < in_len' at the end of the if statement. > However, it accesses 'in_ie[i + 5]' before that check, which can lead > to an out-of-bounds read. Move the length check to the beginning of the > conditional to ensure the index is within bounds before accessing the > array. > > Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver") > Cc: stable@vger.kernel.org > Signed-off-by: Luka Gejak > --- This really should have a note here which says: v4: Sent this patch previously as part of a patchset, but pulled it out by itself because it's a bugfix and the rest of the patchset was cleanups. Otherwise, it's like I remember that I have seen something like this before but I don't know why I'm seeing this now. I thought maybe it was the same bug in a different driver or something so I had to look it up on lore. Anyway, looks good otherwise. Reviewed-by: Dan Carpenter regards, dan carpenter