From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E31192D839C for ; Wed, 25 Feb 2026 06:57:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772002632; cv=none; b=UVzLW3NLyo2iTri4/qeVup2Dyeeov3QlDbowsCpIBB0yU+AGSdy3PWKnRNSNGCVGTy2Ag2rGtvnZKmA/QXVVQnUYZydD4Ndt+TW0/jcY87/Qz2xLl+ima/L/K+IUkJlh3b3N1A/UQXnTYXNmocrf5yvlyJNcV7PDrIu77CiDbks= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772002632; c=relaxed/simple; bh=wHtx8dr7eJMKt1iFUOWMWmGCOWIph+PlhMwFkkxjvIw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Nx0N28ckP0I0qXuBpTUG5pZWTrAfnBB52yCp6iumsbTicUKxLsiiB7qM5SVKQ7V48yhwlhUA4m2zX/Eum3xG793LyV9IQHJgMk7d5T6nqN+XUWY3CQXDAwfHUC2xQ2NPjmjfcuOwGm2uFvGIHg/ikCwjCUKZ4f7LQN3Whmo973w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=yJzsuQba; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yJzsuQba" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-483487335c2so56377365e9.2 for ; Tue, 24 Feb 2026 22:57:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772002629; x=1772607429; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=WNVaLfglGOteoUVIsD34z2+yUS5Wq8z1t7Ac1ijBd7s=; b=yJzsuQba4wJGrFcG+gPT3Tz+TU9BF2xM/Zos/cKE3xdIWz+CYkAnvhyutnzFRAzcWt ytnp9T0baguJAYR+2mD8HuV5KjaDUcCLz4Ki8hqPWksbOkEu0pRTJbNXVdlBshbQdJkj r+xd+nn/Rt9MQGts3xE2ncnWKCTsWG9NcsJZYF9wtV1FgwtfF9JoRzanNMCTLvguF+v/ t4Dse8KYfrbuI2lIFzUD5/izifAyzF0qAzRgvHyXAxMR09/bSogoJhbkkKP0sQ52kHCO k+qfKVp8Euho4VFlDv+aMXgHVOb/K3T4SiZVgGyuWAT9HQaGkAL7IN3LNFN/hD8yWnba VBDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772002629; x=1772607429; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WNVaLfglGOteoUVIsD34z2+yUS5Wq8z1t7Ac1ijBd7s=; b=LNAXb58GBO7KE55E8zA61ilxlKkrBR+hDxrceiyPBNJw8g/k0nj4DWgmigHRBGnMP8 ye5uS/F1H0f2/g3t7LjBZUlKAebTVHjpzCw/wZ1dIwC6GEIoBeFVJw8nBLJQjvoyVNqg ghGqQE+b4BZMFukXEDImqpb0kbYUs1+7oTpb2XRdfbffdG1rEcdoU1eaV/dMZB+dJQxr /FYNJAetUKoWizJUJ0oeEY7Hv0e1f1SGPWS0ACvm2V7bD1jDs5BPxTHeTRtTxa+09c7A xfpGXdmGURheh4dzEN52pprM+9/TdQURJjxafwp+oVPBlXjWfnhSsSMUarBBk9Ltj9bC sfiw== X-Forwarded-Encrypted: i=1; AJvYcCUegA0HHDPdUwHOfPDAP2kH7W/Tv63d0xMrhrrCoP2q2nHjWSpKZtp8C2ZOTo/F3Yghs5uPsxQ8DyhP0EI=@vger.kernel.org X-Gm-Message-State: AOJu0Yx/11V2ufn4d2/qHk2F8N2EgLGtexwq+9VAkHeZbxrHtQ4ZUwI6 NJIjU5YhN87HAPGEApUN/HosbPYw/e9MoFv3oG+p0WM0kkEPuJyYuLbp+EvGNynfWOs= X-Gm-Gg: ATEYQzzaxtADjlU44YU49bFd7FXTwgtlScRFEsJvR8pvmy4dFZvcku2n8fga8TrGyGv 6fxXOxFEwY1KAceHYPPkeAnRsFfy2PyuAtoylZ9ofIbtkO0qD4Mb5yqTWLZZYHB8A/S5X3SuWlD m8zU9/Utcl9UTqYT73kkbwbis4hqv+wI3iU2sEJzJAU1i2tEgmfb/B+6W9LQUbuNFseR/q1gxcC DYA0tT4Zun4wOgAWci89DMTBG6+5IEOTcA9VwV+YPm/ZEcVEL1vpaervWsObsgBizEFwHkqqMaw J2aMW49t1hZI403Af8+ALzf3Gsv+IjJ2ndBe4Tj0E8KiBBTy2VYhEyugvS7O6if3kqi1l71mzaC DWGnUnkwexxdKD8XV9PajyjzTVLELiSh2nGfdEdSRYZ46mGR/mLM+9o3ShuC62zUiB2KqNX+eSw i1T7rZoneRqKIRNCky+ZKNIEHi9+bO8YQcZhGrLvU= X-Received: by 2002:a05:600c:450c:b0:483:75f1:54f with SMTP id 5b1f17b1804b1-483b80c9ea4mr105872775e9.31.1772002629251; Tue, 24 Feb 2026 22:57:09 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483bfb789efsm8367515e9.2.2026.02.24.22.57.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Feb 2026 22:57:08 -0800 (PST) Date: Wed, 25 Feb 2026 09:57:05 +0300 From: Dan Carpenter To: luka.gejak@linux.dev Cc: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 09/21] staging: rtl8723bs: hal: fix line lengths in HalPhyRf_8723B.c Message-ID: References: <20260224132748.12336-1-luka.gejak@linux.dev> <20260224132748.12336-10-luka.gejak@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260224132748.12336-10-luka.gejak@linux.dev> On Tue, Feb 24, 2026 at 02:27:36PM +0100, luka.gejak@linux.dev wrote: > @@ -1060,12 +1074,15 @@ static void _PHY_PathBFillIQKMatrix8723B( > reg = result[final_candidate][7] & 0x3F; > PHY_SetBBReg(pDM_Odm->Adapter, rOFDM0_XBRxIQImbalance, 0xFC00, reg); > pRFCalibrateInfo->RxIQC_8723B[PATH_S0][IDX_0xC14][KEY] = rOFDM0_XARxIQImbalance; > - pRFCalibrateInfo->RxIQC_8723B[PATH_S0][IDX_0xC14][VAL] = PHY_QueryBBReg(pDM_Odm->Adapter, rOFDM0_XBRxIQImbalance, bMaskDWord); > + pRFCalibrateInfo->RxIQC_8723B[PATH_S0][IDX_0xC14][VAL] = > + PHY_QueryBBReg(pDM_Odm->Adapter, rOFDM0_XBRxIQImbalance, bMaskDWord); > > reg = (result[final_candidate][7] >> 6) & 0xF; > /* PHY_SetBBReg(pDM_Odm->Adapter, rOFDM0_AGCRSSITable, 0x0000F000, reg); */ > pRFCalibrateInfo->RxIQC_8723B[PATH_S0][IDX_0xCA0][KEY] = rOFDM0_RxIQExtAnta; > - pRFCalibrateInfo->RxIQC_8723B[PATH_S0][IDX_0xCA0][VAL] = (reg << 28)|(PHY_QueryBBReg(pDM_Odm->Adapter, rOFDM0_RxIQExtAnta, bMaskDWord)&0x0fffffff); > + pRFCalibrateInfo->RxIQC_8723B[PATH_S0][IDX_0xCA0][VAL] = (reg << 28) | > + (PHY_QueryBBReg(pDM_Odm->Adapter, rOFDM0_RxIQExtAnta, bMaskDWord) & > + 0x0fffffff); > } You can introduce a lot of line breaks in one patch. Good. Fine. > } > > @@ -1078,7 +1095,6 @@ void ODM_SetIQCbyRFpath(struct dm_odm_t *pDM_Odm, u32 RFpath) > { > > struct odm_rf_cal_t *pRFCalibrateInfo = &pDM_Odm->RFCalibrateInfo; > - u8 path; > > if ( > (pRFCalibrateInfo->TxIQC_8723B[PATH_S0][IDX_0xC80][VAL] != 0x0) && > @@ -1086,18 +1102,31 @@ void ODM_SetIQCbyRFpath(struct dm_odm_t *pDM_Odm, u32 RFpath) > (pRFCalibrateInfo->TxIQC_8723B[PATH_S1][IDX_0xC80][VAL] != 0x0) && > (pRFCalibrateInfo->RxIQC_8723B[PATH_S1][IDX_0xC14][VAL] != 0x0) > ) { > - if (RFpath) > - path = PATH_S0; > - else > - path = PATH_S1; > - > - /* TX IQC */ > - PHY_SetBBReg(pDM_Odm->Adapter, pRFCalibrateInfo->TxIQC_8723B[path][IDX_0xC94][KEY], bMaskDWord, pRFCalibrateInfo->TxIQC_8723B[path][IDX_0xC94][VAL]); > - PHY_SetBBReg(pDM_Odm->Adapter, pRFCalibrateInfo->TxIQC_8723B[path][IDX_0xC80][KEY], bMaskDWord, pRFCalibrateInfo->TxIQC_8723B[path][IDX_0xC80][VAL]); > - PHY_SetBBReg(pDM_Odm->Adapter, pRFCalibrateInfo->TxIQC_8723B[path][IDX_0xC4C][KEY], bMaskDWord, pRFCalibrateInfo->TxIQC_8723B[path][IDX_0xC4C][VAL]); > - /* RX IQC */ > - PHY_SetBBReg(pDM_Odm->Adapter, pRFCalibrateInfo->RxIQC_8723B[path][IDX_0xC14][KEY], bMaskDWord, pRFCalibrateInfo->RxIQC_8723B[path][IDX_0xC14][VAL]); > - PHY_SetBBReg(pDM_Odm->Adapter, pRFCalibrateInfo->RxIQC_8723B[path][IDX_0xCA0][KEY], bMaskDWord, pRFCalibrateInfo->RxIQC_8723B[path][IDX_0xCA0][VAL]); > + if (RFpath) { /* S1: RFpath = 0, S0:RFpath = 1 */ > + u32 (*tx)[2] = pRFCalibrateInfo->TxIQC_8723B[PATH_S0]; > + u32 (*rx)[2] = pRFCalibrateInfo->RxIQC_8723B[PATH_S0]; > + struct adapter *a = pDM_Odm->Adapter; > + > + /* S0 TX IQC */ > + PHY_SetBBReg(a, tx[IDX_0xC94][KEY], bMaskDWord, tx[IDX_0xC94][VAL]); > + PHY_SetBBReg(a, tx[IDX_0xC80][KEY], bMaskDWord, tx[IDX_0xC80][VAL]); > + PHY_SetBBReg(a, tx[IDX_0xC4C][KEY], bMaskDWord, tx[IDX_0xC4C][VAL]); > + /* S0 RX IQC */ > + PHY_SetBBReg(a, rx[IDX_0xC14][KEY], bMaskDWord, rx[IDX_0xC14][VAL]); > + PHY_SetBBReg(a, rx[IDX_0xCA0][KEY], bMaskDWord, rx[IDX_0xCA0][VAL]); > + } else { > + u32 (*tx)[2] = pRFCalibrateInfo->TxIQC_8723B[PATH_S1]; > + u32 (*rx)[2] = pRFCalibrateInfo->RxIQC_8723B[PATH_S1]; > + struct adapter *a = pDM_Odm->Adapter; > + > + /* S1 TX IQC */ > + PHY_SetBBReg(a, tx[IDX_0xC94][KEY], bMaskDWord, tx[IDX_0xC94][VAL]); > + PHY_SetBBReg(a, tx[IDX_0xC80][KEY], bMaskDWord, tx[IDX_0xC80][VAL]); > + PHY_SetBBReg(a, tx[IDX_0xC4C][KEY], bMaskDWord, tx[IDX_0xC4C][VAL]); > + /* S1 RX IQC */ > + PHY_SetBBReg(a, rx[IDX_0xC14][KEY], bMaskDWord, rx[IDX_0xC14][VAL]); > + PHY_SetBBReg(a, rx[IDX_0xCA0][KEY], bMaskDWord, rx[IDX_0xCA0][VAL]); > + } But when we start re-writing the code, then I want that separated into a different patch. It requires more thought to review this. regards, dan carpenter