From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8CFCA3115B8 for ; Wed, 25 Feb 2026 06:58:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772002694; cv=none; b=OMGQJ/Da8b4cTUt4OGtWp/ivqu+b0dB3S/HbyzJqbTW/qP7wSCxZmoNNhTpN2vkI520VeJWTtQNcBfnXypnngpk79snrQCnM7qKSK1dlWC8WLUOyMHi1U0JtglSQ0XdOBr7ajTPaPnZX5dSUUBACe3S0XzKxLpn/H91ACtaUlyI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772002694; c=relaxed/simple; bh=v60r68gfDl7wZWbSddD8l3aellAxLobWK4TkWXSqT5w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qHCMdpJwdCrD75BcIhW7CUn7GfcNVlCULSJkiBcwTuYwlJToShL4EGI2Dcp88qIsO3rGe68/ewqVsD/yiVnG/p5FRwji9Dj9Pn+6skbsAE8sAIGRUEQ2xD8ipbtTXo8l7cDTzr8/hDbAogMrlo7W90W5GCzbONlusayT+EoyfH0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=QDEv0LAu; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="QDEv0LAu" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-483a233819aso61539125e9.3 for ; Tue, 24 Feb 2026 22:58:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772002691; x=1772607491; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=R6+NDOY5H+WoTBtir80X8g3iQTGFT3zn6+YzwoNyzvw=; b=QDEv0LAuQq7cCp08CPveVK9RvD7cV3iHce8ANk6ahwr09RoP1GFP6QldGwgMw0z6iE kCizX+ymmpTKDE2qbqNzGDyfrcyWRheLXwxArr0Pm+dLZrsBz1XmxMPJSZV4C8OmEJhy qKH8ovZrT7SjkmCCASIpPDIyHD9bXtXEP3UkP/Jhwyh4TULpMWg9alivlZGe3kb8je3V HHogujI/GWicw+wp+xnLIn2fDNqA6ED1NxbFuPb+bINk6BU214UhopTkyrmsIhWnjvge 5cErg9NXKDCASesxHium72Geod3cmE+XKeTpT5iOo3k6MdJFDKGScNhC+B1h2Xy5KUQd 6H+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772002691; x=1772607491; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=R6+NDOY5H+WoTBtir80X8g3iQTGFT3zn6+YzwoNyzvw=; b=hENF9fHWCQg2qL38s8xJ67GoKjk/MZrpW0XI7UMH/tyDqdpZk5FYLVAbRwqS+4BZ5p 3J1pc1+Uj3/icH1GjznyP6gdhx/I1xxomW+3qijp4yZ9YYtjhOcyakiy4gWhaPRMymfr +KPypX1wYGKRziwIg6RJlm4Gq2KQOSSaAnho2pbKBE/QiwlIX4nHu9jA3FzVlPhS+8Qb gUvz51e9RtYY0qSwd9N6PaM5zEJY1uO1/bsstR/EbcSFHRnoOZDSqp+yCt6aLhgEdh78 NZW6jXQFE2uJymGV4P+JURQ10HbqF4fUwd/puuq5K5aQcPsEwpEZ2aLilaKsevWodNwt Qx4Q== X-Forwarded-Encrypted: i=1; AJvYcCV12xdYUvqJcajV0VUQ5NvLQ+Cs2PovKAjM//EVY0UBZ1Mbc04GBKkSDx7euisKxC/7CHDPrLgH1tmawqA=@vger.kernel.org X-Gm-Message-State: AOJu0YwaVEk7vmd3XvstO688G/d+LD67JZWbMQK/iy0SGaoBaphgpGDI 9QWsX0sh2J75tB4hbPc8PbaSw1+U39gMl6m0I7Lvyw9qDUhOaNT7y0e8P2W78ni8Dno= X-Gm-Gg: ATEYQzw2Sn4YksdnBb3q38urqsYrpMj5G7HLK2IQ260TmyEm40fhLQqOwygn+s5zT3m j6BVOppizqODsogjzeHWe4E+P3E0YswXZuH0dNLNy8433T6Pm1v3UdvocrSk01jOUsZCPdj+Wps HjPzcPsDPMZzjtT/WQmSphGicWikrY5s1tx6WBoe3cYbWxyusJBkQ6r9MMEevsQlKeGc3r+KcW+ TIpmLJMuUuF2ogwu0+LUdgYVo7G2MUDlClBZAlBjOYWxf5LLV2TzKrLThzIv6isZXZku2FU9LeZ CcuMv3FxaZlaRjSAOZNULKXE0AOWZ7Twc9HDlwkfN4yDJnGqWmlcmQTITyQHykluXuq2+8YOB8d /MgJGG9J6S4W2fWPezev9KrsTypo/cLtwKCDaId/grNmkEHmcZpzbGNGGVsPBKEdfn5BfHSw+vy VxnyGpBtLN3b+z2GQBaS+gjXiExkjt X-Received: by 2002:a05:600c:3147:b0:477:6374:6347 with SMTP id 5b1f17b1804b1-483a962e3e2mr229792055e9.22.1772002690819; Tue, 24 Feb 2026 22:58:10 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483bfba9a5esm9329075e9.4.2026.02.24.22.58.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Feb 2026 22:58:10 -0800 (PST) Date: Wed, 25 Feb 2026 09:58:07 +0300 From: Dan Carpenter To: luka.gejak@linux.dev Cc: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 10/21] staging: rtl8723bs: os_dep: fix line lengths in ioctl_cfg80211.c Message-ID: References: <20260224132748.12336-1-luka.gejak@linux.dev> <20260224132748.12336-11-luka.gejak@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260224132748.12336-11-luka.gejak@linux.dev> On Tue, Feb 24, 2026 at 02:27:37PM +0100, luka.gejak@linux.dev wrote: > From: Luka Gejak > > Break long lines exceeding 100 characters to comply with kernel coding > style. > > Signed-off-by: Luka Gejak > --- > .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 134 ++++++++++++------ > 1 file changed, 94 insertions(+), 40 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c > index 51725c302458..c04af493f24d 100644 > --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c > +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c > @@ -127,8 +127,10 @@ static struct ieee80211_supported_band *rtw_spt_band_alloc( > if (!spt_band) > goto exit; > > - spt_band->channels = (struct ieee80211_channel *)(((u8 *)spt_band) + sizeof(struct ieee80211_supported_band)); > - spt_band->bitrates = (struct ieee80211_rate *)(((u8 *)spt_band->channels) + sizeof(struct ieee80211_channel) * n_channels); > + spt_band->channels = (struct ieee80211_channel *)(((u8 *)spt_band) + > + sizeof(struct ieee80211_supported_band)); > + spt_band->bitrates = (struct ieee80211_rate *)(((u8 *)spt_band->channels) + > + sizeof(struct ieee80211_channel) * n_channels); > spt_band->band = band; > spt_band->n_channels = n_channels; > spt_band->n_bitrates = n_bitrates; > @@ -207,7 +209,8 @@ int rtw_ieee80211_channel_to_frequency(int chan) > } > > #define MAX_BSSINFO_LEN 1000 > -struct cfg80211_bss *rtw_cfg80211_inform_bss(struct adapter *padapter, struct wlan_network *pnetwork) > +struct cfg80211_bss *rtw_cfg80211_inform_bss(struct adapter *padapter, > + struct wlan_network *pnetwork) > { > struct ieee80211_channel *notify_channel; > struct cfg80211_bss *bss = NULL; > @@ -248,7 +251,10 @@ struct cfg80211_bss *rtw_cfg80211_inform_bss(struct adapter *padapter, struct wl > u32 wpsielen = 0; > u8 *wpsie = NULL; > > - wpsie = rtw_get_wps_ie(pnetwork->network.ies + _FIXED_IE_LENGTH_, pnetwork->network.ie_length - _FIXED_IE_LENGTH_, NULL, &wpsielen); > + u8 *ies = pnetwork->network.ies + _FIXED_IE_LENGTH_; > + uint ie_len = pnetwork->network.ie_length - _FIXED_IE_LENGTH_; > + No spaces in the middle of a declaration block, please. regards, dan carpenter