From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BA1030E855 for ; Wed, 25 Feb 2026 06:58:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772002710; cv=none; b=ZQHQkYFNS66rvyRh2qa6yeGrod/FewE997XlPHneeMs4oFmuVzaWngmKDOpoMGiuPqcVR2ZYnw7K16kpVhXOl/ualA1LrcW4KSUpGX+mBW1qxyk7o8UPgYmMmCi6l5N8hcOBQaCiGStiMIz+H2XqMl5XaTSNDSQu21wXvau26Vw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772002710; c=relaxed/simple; bh=uvZsRSj7mCjP5umTIAlh8QVei37SuoxZndYxK/47sB0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XX4QO8/WQoaFZURIBXwGL1oxpCkVIoLfR5BrDzqD+i+O3cyCiPv2JEiB0GBMv5uvrQhi0z4zHg0rl8VhV6ya+lmyoNSNUh0Vks7zdAiZzCzmaZiHfOyjZ+aq6tvcVhZ4XQ3MMg28WrJcg3je7E+lWEt+SoL0SNkxBTfUe0akHr4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=aWzx9pq1; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="aWzx9pq1" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-483703e4b08so4355985e9.1 for ; Tue, 24 Feb 2026 22:58:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772002707; x=1772607507; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=iyHU5sMgTd3FgAYbrP7QK+9rU24euug+BHUoAhLeps8=; b=aWzx9pq1C8FCzbSa5yksle4emCPJn6+ajvIdlzCjMFWvaD3uT0vc5sG21Kp5cuEk9h pU+a4ABiNNHkue+bYlYo5Bzq6QHdtcma51LUVV5X4W/d/v9+9C/DnzArvN+Bfn0Rl0Fa rQ+Nh60AmdIEZELaClnr3m/UUX2bn7xiT76LwQ4mzFnqx5QEvfQqbDB46BnEmP1yuvyD GoqCYZyBi1DvbMZqJL7N3gUOeh7FCTuid/1Eo06IsH2vdc3kUL8B3mchv0K7i0Fbt81t Gum5f//nL+XGNweiwnTGvoA4nllb4qJQywQPnjwqH9ztUgHC6JcTmsE86HwtunRjg1By La/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772002707; x=1772607507; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iyHU5sMgTd3FgAYbrP7QK+9rU24euug+BHUoAhLeps8=; b=QUkqLgJHVVODNRm3vifp0k9h22N0y8tuPvH6dzizbXBeh5YsQvwXCmSKmTmymoycks 29bbctcgZmEQkTTLao3B7fvBJNPdfCDASQkPuo58plhNomRU2pOYwAeS+I0yed4oxS9z 28g3j88sBaKLNPRdShmPp8oYBtX2y2OeWI8kamRnPjAt8KvS2lHl7HKJ+zzCdjEM5ijJ 2zSWsZ50/1IE6JTVC/5047JXAF9LTNFAzXhj9bgXUQVq2eqtwalDzLmk/1wSmFx63U9F TgyTBykzowTkoBFfDsl8FMBdU/MkbFn/93WPBObjxWy0W0xIVHAVyDIFFgrKfwZtj7LT eWGw== X-Forwarded-Encrypted: i=1; AJvYcCWKazCCaTq2I/fGSaD1hPvwiwWyoQKWj3n3eVZjKaUUW443a2IBYzxB2egEQN4tOpyBZ3DfTbAXv+vKbuQ=@vger.kernel.org X-Gm-Message-State: AOJu0Ywhvd2118vinllrDqxPcQAgMc+JmLsOFBElOSroO99SKqh7tqFR 3WhF80Z5SWkdS3OAZJfZRIFGTnwic/qglPbVFaFiP9NFisf66JMnfxzF06iV3MWkPic= X-Gm-Gg: ATEYQzz0ctistX28wNROF6jhS9Zb9fCgOWxL7FLnHXQDSzJw07TivCRz2Spm2uDB0SV ZsemiPuC2vASz6CU+5xABWRDuxTTpSbF5+jSIooWttKdE6ykaGhpSkV51jMeo3+p31V3M91jGBN /IEdpRACR0pAVnQZ7ACLW0SE9C9YRWYenKnGSebNMEye1rtC13tJ3osLsLky3QKaey2Lxo2MI19 wPSKmA4jQqXGzl6mj8lrutxbJvkaQiP8Wo0PFaPDAS5TEqmdkTmL4pS+b1Z3DPtInybsCqySueI dmIrDMjwYRnlpe0IE3+1PbJJuy3/bsS09nCSJAu7FFD5j2M/rd2qToLD/PMP0XCP4+DS+qJpqun qQVITVDIcv83ArZWaWmsbYihhiMjD0bZpwSO60aQR5mPuxOBOwPKh9aKnIGSLRDIiW6RoS0V90U YH5NzBV1OCT1gg9rgnKDh9mtxllwRO X-Received: by 2002:a05:600c:1551:b0:483:a2b0:d210 with SMTP id 5b1f17b1804b1-483bd726f78mr42505745e9.7.1772002707511; Tue, 24 Feb 2026 22:58:27 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483bd6f19f5sm118917625e9.1.2026.02.24.22.58.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Feb 2026 22:58:27 -0800 (PST) Date: Wed, 25 Feb 2026 09:58:23 +0300 From: Dan Carpenter To: luka.gejak@linux.dev Cc: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 11/21] staging: rtl8723bs: hal: fix line lengths in rtl8723b_cmd.c Message-ID: References: <20260224132748.12336-1-luka.gejak@linux.dev> <20260224132748.12336-12-luka.gejak@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260224132748.12336-12-luka.gejak@linux.dev> On Tue, Feb 24, 2026 at 02:27:38PM +0100, luka.gejak@linux.dev wrote: > From: Luka Gejak > > Break long lines exceeding 100 characters to comply with kernel coding > style. > > Signed-off-by: Luka Gejak > --- > drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 103 +++++++++++++++---- > 1 file changed, 83 insertions(+), 20 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c b/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c > index af6cdda8238d..92951ba4561e 100644 > --- a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c > +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c > @@ -154,14 +154,28 @@ static void ConstructBeacon(struct adapter *padapter, u8 *pframe, u32 *pLength) > /* below for ad-hoc mode */ > > /* SSID */ > - pframe = rtw_set_ie(pframe, WLAN_EID_SSID, cur_network->ssid.ssid_length, cur_network->ssid.ssid, &pktlen); > + { > + uint ssid_len = cur_network->ssid.ssid_length; > + > + pframe = rtw_set_ie(pframe, WLAN_EID_SSID, ssid_len, > + cur_network->ssid.ssid, &pktlen); > + } No. regards, dan carpenter