From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AEB4D19E97B for ; Wed, 25 Feb 2026 07:00:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772002828; cv=none; b=lTGp/42GIWfiblJTNPfos+35fgyGx3dPKbBXUPAjsofFS+askenEDfcBqAM/y6NZSRF75EPQkV6lryyIrXCuDkCBw2yE7F5VpU06tRr84vD6+wpm4+HxMPmzb691lorjiQkRKtsxtSBkH3GjbQK2yAR5HhPkNNVkHRwlcaWt/gM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772002828; c=relaxed/simple; bh=vcJmK+0n+pAu+LoutcgCCXx5e/jsMREN6YUr9PObVnY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=W/69azxfVGk7ZbHSfovfr8CeWMB3RZ6xBy4GVfzC6ajcbLzMRuBLABq6K19PGyZncDX/k2i7HlrliQn0XsizY3fRts5ATZ9dql/Wx/E4Yy3Wq3sb4NXyZOjJFy5GI0WNC1GcrNlHJyUJIURjUHldEtf/eK2FvSFvx46xOxU17KU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=C3U+pdYe; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="C3U+pdYe" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-4375d4fb4d4so3990138f8f.0 for ; Tue, 24 Feb 2026 23:00:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772002825; x=1772607625; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=XrgllbZC0hX2Y8N4kX0e2uvpdghjGsY3RfCGNWJzKhs=; b=C3U+pdYe/ZvBHrSlKauEzSZDWg9/hIDO9GJWBui578NiGO5CiIci5M8x+JRZSTszFH KVi0r+6P4oeULC0mN14QajKpBxuoGi3WDQJcmhfjkhcPgyaZLAwAtikn0BzfiJdV1kIK eyLjnJdjMqK9Rb1QB2wSzAyBT3HYCVcpomnlDaMEBDR2dor3lEa89RVuHFp2ybSLIUux yObkwqXn1O5DhgiC5UYFuJQyiEcHNc2UobgrwrCEl9hFZbPmNTZ2BmYCpaFONDukv+Ny F7PWH3WWcrXpu5wTdyJR3NSeR2b4EzSMEABTxdB2AynnV2ya4SOThFBULin7imdwvh+o YssA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772002825; x=1772607625; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XrgllbZC0hX2Y8N4kX0e2uvpdghjGsY3RfCGNWJzKhs=; b=mxFHqRnERwfVnLAtlKzFd0NPeVJbg8/1LV8rysEmafm9sfqK5ZgKEyFgpbNB6EWRD/ zwMfu0pMlmxnrl6V8nvbKBwNPuAW1uvV4SPBcfK0jxso2MBpdeJ7J0NYaQ4gJXNXDZ49 4Eup1EaAG7Nrpy4CAPJEmels7znwWDe7khEz7isFj6M32ARlQxC14NchxFh+sdmXYvxp 80WIYQmHVK53LZo40/7x2AujFYExsnMKBBfprrHBbtR/GyDBkNGjHOKaCbqXg660sNRT 5cR0a9LPj/pmPZd1nVxbcpT2/Cf11+BItQEhiajIUvqJBVDv5Ta/OMzhKuz29zo20zen ISSQ== X-Forwarded-Encrypted: i=1; AJvYcCVk/0F12Af5xlNQAwGNfiyR0c5iGx9/9vmKO65vRcb1B3ihPdkhh6LgxJMfx6QF9ZBHW9WSI2Gp8BrMqro=@vger.kernel.org X-Gm-Message-State: AOJu0Yxb58fQTgQ68ueuZBsW5jw+25SY1WkB1TE6K7mMhEtWX6BSdgnc yfsaKh7aFkJaNgK6QzErzngPtLMlZMbzM0x3/kUpa47jzFpGlf2vME3tSIAmb7pANwY= X-Gm-Gg: ATEYQzzEYKw5oi54hDtzjYUYg5u+F7Ux65zyMI/sTyyUwVvYVe+Gdwrgy1N3X1Qha33 bg2y5blA56EaWhPP2/mNPgJbwtblrxCWsuhJo6rWBVGr6UFAw8jpHrKYEktpqNx1cz8ysbCrcMp vLom3SVQghJv+V7PSAZF86Eq2+yvB7WSSSJ11q93oxJpkofFbpklXe3PlqMsfZRI7Wz+037MyYB rlLOAilYijEW/4oJoxOQBaurb7OxoNSFxkitE7sWfaCcTQwEbc2YZfurlB0HpKAAiXJmKNHKIh4 MHP73tl75vrfpSpFnYjV9Pyq4rbC/8fnUeM1h5C/Vp7oYJt2oR23JfIQs4P2KnW0QsGiMcqAphM XnutS4KaSWxC35qSSRY5tokI9Y9Y6HhfrCX+kEwrQM/xRjCjRp1MoCNQ3P3Udn0i9Z0kIyQmYO6 UwbQhEOzHYqQbK73LJBWVzPkPuf5Lm X-Received: by 2002:a05:6000:26d2:b0:439:8aaf:33fb with SMTP id ffacd0b85a97d-4398aaf3477mr7451916f8f.22.1772002824818; Tue, 24 Feb 2026 23:00:24 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43970bf9fb2sm32491902f8f.1.2026.02.24.23.00.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Feb 2026 23:00:24 -0800 (PST) Date: Wed, 25 Feb 2026 10:00:21 +0300 From: Dan Carpenter To: luka.gejak@linux.dev Cc: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 12/21] staging: rtl8723bs: hal: fix line lengths in rtl8723b_hal_init.c Message-ID: References: <20260224132748.12336-1-luka.gejak@linux.dev> <20260224132748.12336-13-luka.gejak@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260224132748.12336-13-luka.gejak@linux.dev> On Tue, Feb 24, 2026 at 02:27:39PM +0100, luka.gejak@linux.dev wrote: > @@ -998,9 +1008,13 @@ void rtl8723b_SetBeaconRelatedRegisters(struct adapter *padapter) > rtw_write32(padapter, REG_TCR, value32); > > /* NOTE: Fix test chip's bug (about contention windows's randomness) */ > - if (check_fwstate(&padapter->mlmepriv, WIFI_ADHOC_STATE|WIFI_ADHOC_MASTER_STATE|WIFI_AP_STATE) == true) { > - rtw_write8(padapter, REG_RXTSF_OFFSET_CCK, 0x50); > - rtw_write8(padapter, REG_RXTSF_OFFSET_OFDM, 0x50); > + { > + u16 state_mask = WIFI_ADHOC_STATE | WIFI_ADHOC_MASTER_STATE | WIFI_AP_STATE; > + > + if (check_fwstate(&padapter->mlmepriv, state_mask)) { > + rtw_write8(padapter, REG_RXTSF_OFFSET_CCK, 0x50); > + rtw_write8(padapter, REG_RXTSF_OFFSET_OFDM, 0x50); > + } > } I'm done reviewing the patchset for now. regards, dan carpenter