Re: [PATCH v5 0/4] Add USB support for Canaan K230

From: Jiayu Du <jiayu.riscv@isrc.iscas.ac.cn>
To: vkoul@kernel.org, gregkh@linuxfoundation.org, conor@kernel.org
Cc: neil.armstrong@linaro.org, robh@kernel.org, krzk+dt@kernel.org,
	pjw@kernel.org, palmer@dabbelt.com, aou@eecs.berkeley.edu,
	alex@ghiti.fr, linux-phy@lists.infradead.org,
	linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 0/4] Add USB support for Canaan K230
Date: Wed, 25 Feb 2026 20:14:46 +0800	[thread overview]
Message-ID: <aZ7ntvit57TaPgyw@duge-virtual-machine> (raw)
In-Reply-To: <aYCLGLvbKZy+WyxI@duge-virtual-machine>

On Mon, Feb 02, 2026 at 07:31:36PM +0800, Jiayu Du wrote:
> On Wed, Jan 21, 2026 at 10:55:21PM +0800, Jiayu Du wrote:
> > Add support for the USB PHY and DWC2 IP which is used by Canaan K230,
> > and made relevant changes to the DTS.
> > 
> > This series is based on the initial 100ask K230 DshanPi series [1] which
> > is based on the clock and pinctrl series. Check the details in the link.
> > 
> > Link: https://lore.kernel.org/all/20260115060801.16819-1-jiayu.riscv@isrc.iscas.ac.cn/ [1]
> > 
> > Changes in v5:
> > - Changed the year of Copyright to 2026.
> > - Add blank line after the declaration of variables
> > - Fix wrong alignment.
> > - Link to v4: https://lore.kernel.org/all/20260120143243.71937-1-jiayu.riscv@isrc.iscas.ac.cn/
> > 
> > Changes in v4:
> > - Shrink reg length to match the address/size-cells in k230-usb-phy yaml.
> > - Move all PHY instance creation and initialization from xlate to probe.
> > - Modify xlate function to only perform index lookup for PHY instances.
> > - Define all register base offsets macros at the top of file instead of
> >   hard-coding magic numbers directly in probe.
> > - Link to v2: https://lore.kernel.org/all/20260115064223.21926-1-jiayu.riscv@isrc.iscas.ac.cn/
> > 
> > Changes in v3:
> > - Please ignore v3.
> > 
> > Changes in v2:
> > - Fold the child into the parent in dtsi.
> > - Define one usbphy with phy-cells=1.
> > - Delete the clock of the usbphy as it is not needed.
> > - Link to v1: https://lore.kernel.org/all/20251230023725.15966-1-jiayu.riscv@isrc.iscas.ac.cn/
> > 
> > Jiayu Du (4):
> >   dt-bindings: phy: Add Canaan K230 USB PHY
> >   dt-bindings: usb: dwc2: Add support for Canaan K230 SoC
> >   phy: usb: Add driver for Canaan K230 USB 2.0 PHY
> >   riscv: dts: canaan: Add syscon and USB nodes for K230
> > 
> >  .../bindings/phy/canaan,k230-usb-phy.yaml     |  35 +++
> >  .../devicetree/bindings/usb/dwc2.yaml         |   3 +
> >  .../boot/dts/canaan/k230-canmv-dshanpi.dts    |  17 ++
> >  arch/riscv/boot/dts/canaan/k230.dtsi          |  35 +++
> >  drivers/phy/Kconfig                           |   1 +
> >  drivers/phy/Makefile                          |   1 +
> >  drivers/phy/canaan/Kconfig                    |  14 +
> >  drivers/phy/canaan/Makefile                   |   2 +
> >  drivers/phy/canaan/phy-k230-usb.c             | 284 ++++++++++++++++++
> >  9 files changed, 392 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/phy/canaan,k230-usb-phy.yaml
> >  create mode 100644 drivers/phy/canaan/Kconfig
> >  create mode 100644 drivers/phy/canaan/Makefile
> >  create mode 100644 drivers/phy/canaan/phy-k230-usb.c
> > 
> > -- 
> > 2.52.0
> > 
> Hello Vinod, could you please take a look at this patch? Thank you!
> 
> Regards,
> Jiayu Du

Hi Vinod, will you review this patch? Thank you again!

Regards,
Jiayu Du

> 
> 
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv