From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f202.google.com (mail-pl1-f202.google.com [209.85.214.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B4C53AE6F6 for ; Wed, 25 Feb 2026 13:59:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772027949; cv=none; b=RSNvsO5wR2p7JJteYLOfNzMvpr//pJOByxO3KzCPRUFUnfe7dPdKvcwGbmnFHVmSpLIBZgafIt5+1qva0NgwzyVw5dYhyeApnUuYcafeMHFHnjYVXUWiNtfNVVMOAajd6mofU3jxuFgUlKyvDlHEc8EkS9aO4Cub6vqedwbIDxs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772027949; c=relaxed/simple; bh=kUnsSf6fs3cOu9pmGJrE9E1cjS39vhoQ4IC7090/cMA=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=HRyGSGi0K9fJ7WLLN9qnFgwEvMCZ8GKQLt3XtL09TFSTGlOh3lHulYhc2va5L/GAkbZ7M2pEZlfAE8PQYbB0Pd5+Azq+Ma+sDt2KgjFLaT671RfYS9546t0zK9CrcQf9aUWAu+GXprFB2tQgVM3uUAt2JGsWER9poOsxa7wHylE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=xLyVAlTg; arc=none smtp.client-ip=209.85.214.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="xLyVAlTg" Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-2adba04421eso64462735ad.3 for ; Wed, 25 Feb 2026 05:59:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1772027948; x=1772632748; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=nDEZNV3YXPdpDxBVV0b0e6H2LhU4cBUkmu8+IMpXwGY=; b=xLyVAlTgkkPrG1L6mBw2ysPXzQi/V2MW1GTTL/94hL7h8V/owtDZHdyeMLb8By9MGo Dg9GLs6cwx/ViQi5++JkqWPZ0qdCmW4U9lU6BVG9Hi6xxuygRntBugPb1kdvTIuIXA7p xay16Sd6SLYWWeiuc++tYNNHR3Ksc1gb7p0r3SAgWGHtKyvGIbJAmHzGhuiCv8bre5qL qXvPyA7j4Bbbyx/n+za80tJUy31mIDGN5e6dFeM+sIYDBbhJXSJSjPDtsZJZzcz04r6U H4tcRtXCg9/Hdgp3xyret3daOC6qrzjQgh8BGUDaL+vQG/YT9tu2m9CuWnKvVt5JqEAP 31tQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772027948; x=1772632748; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nDEZNV3YXPdpDxBVV0b0e6H2LhU4cBUkmu8+IMpXwGY=; b=l5ui9K2r8lXwLo6GRq6F3ngsFw+CZAUReyy3gC49d7bOp/fgjEKZ1tvNvcs+We9buq DRWnTbl8W3hMcjbzzV1h/XJL64S+TaWWyyLWozA05AEI5BURG+WLcKIusRQlzdiIQMXB zq9S7HjVhLxWzPfG89zYbTssBSH3ITVhl8uDLudqiucpgzl7jxLjjrmIhRcn/KRObBw1 7Fl20bSG0kTuJPg3h5k8PZUzPz82TCDV6qMorD70tBOhUS29ZNvc6vQJPdbbpciVBwmz 5wr21znueQ0/L1qvYdZVdoa0GL1HMShtBG0j5Z5CGcMkc2JHVWzEwYA7+NueMXKyYwyp NA3Q== X-Forwarded-Encrypted: i=1; AJvYcCVYHKaXMxRcDAMi4C4WeyDOV2Jki7Pq5TdIJNnlOqShQtRJqSRpk3Vr0gbgfnQoYNYP9T9EcuE7+Ck/h3s=@vger.kernel.org X-Gm-Message-State: AOJu0YyOxcYvEDuQ/+Tx3+Fhdiw0SYaLgYirNjm3YXkSS/UJLkpv0Cqa 9rw7sV2z9ljjxepzk3yMNdoHwQuxgpoqS5AqKJF224rKLlSNRygRJB6a8AaMwzsL7L9+2zAbr0k HTpmuCQ== X-Received: from plgz12.prod.google.com ([2002:a17:903:18c:b0:2ad:ae4d:4a00]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:ec8d:b0:2a9:48ce:b5f5 with SMTP id d9443c01a7336-2ad7455eceamr134638165ad.51.1772027947782; Wed, 25 Feb 2026 05:59:07 -0800 (PST) Date: Wed, 25 Feb 2026 05:59:05 -0800 In-Reply-To: <66336533-8bee-4219-9936-3163c7ce06bb@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260223214336.722463-1-changyuanl@google.com> <213d614fe73e183a230c8f4e0c8fa1cc3d45df39.camel@intel.com> <66336533-8bee-4219-9936-3163c7ce06bb@linux.intel.com> Message-ID: Subject: Re: [PATCH] KVM: TDX: Set SIGNIFCANT_INDEX flag for supported CPUIDs From: Sean Christopherson To: Binbin Wu Cc: Rick P Edgecombe , Xiaoyao Li , "changyuanl@google.com" , "pbonzini@redhat.com" , Binbin Wu , Isaku Yamahata , "bp@alien8.de" , "x86@kernel.org" , "kas@kernel.org" , "hpa@zytor.com" , "mingo@redhat.com" , "linux-kernel@vger.kernel.org" , "dave.hansen@linux.intel.com" , "tglx@kernel.org" , "kvm@vger.kernel.org" , "linux-coco@lists.linux.dev" Content-Type: text/plain; charset="us-ascii" On Wed, Feb 25, 2026, Binbin Wu wrote: > Do we need to consider the panic_on_warn case? I guess the option will not be > enabled in a production environment? Nope. That's even explicitly called out in Documentation/process/coding-style.rst: Do not worry about panic_on_warn users ************************************** A few more words about panic_on_warn: Remember that ``panic_on_warn`` is an available kernel option, and that many users set this option. This is why there is a "Do not WARN lightly" writeup, above. However, the existence of panic_on_warn users is not a valid reason to avoid the judicious use WARN*(). That is because, whoever enables panic_on_warn has explicitly asked the kernel to crash if a WARN*() fires, and such users must be prepared to deal with the consequences of a system that is somewhat more likely to crash.