From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f171.google.com (mail-dy1-f171.google.com [74.125.82.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A7099285C9F for ; Wed, 25 Feb 2026 17:14:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772039662; cv=none; b=qfVrlrCebE8EUrR0zIyiMYJqLdFD6ynCLrH7wIDWbIcwo7uTvJgErWYL8xB7jpiaCSnpiCUSqraiFdwvbpJf03R97PglyWxBPC+b3DNU0s7rXWEF9Pb5DTLHGioBIvAZMsm231SWnDe5sE6w9jHtXp8OAjCvZbAQfwGKBgot+lo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772039662; c=relaxed/simple; bh=6+SccbS+g4a6oOmUo4VbEGkpk8iwX9aoh4LICkhKYF0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UrmShTHPWYhsvu8znetaUtANjQSR7Q41sudNm6tvq8v3ZAMLCr7o5V1xMhFZPnqD2VOcB8GyWrIsRlXb2fUjJ0PzwXxMiEO81HKL7l/Aa2wXs63Hcv6BOaQ7mL/TAhCno4+0PeWpxul3lum7q7Szv+YnbeiQ5S4xBN3vqCvwuNc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=L4Xzuk3R; arc=none smtp.client-ip=74.125.82.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="L4Xzuk3R" Received: by mail-dy1-f171.google.com with SMTP id 5a478bee46e88-2ba9c484e5eso7012469eec.1 for ; Wed, 25 Feb 2026 09:14:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772039661; x=1772644461; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=M6Fai54Ul21d21qsppL/OgbjNjE4u/Ww2JyK/Frhu5U=; b=L4Xzuk3R0W8s+Pr8g70rI3llz5/7izSqkAZQc4uldD1EraLNWcwrdwISNpmkpmvw4h WtaGX51Lap5U1vaVxY+XLLWbtABv8ptP3vjSsSCcce8hwIb3bBnoYfoJeI0cGjfFg2g+ PYo5aynYEvIbMA639kcjMU6+adgc3xWMfjIBCSpc/CX28ItY8wiUmrnjVmlh7p9MQMrZ JreQ4dYn6a5eSvvY68bCQnb4XOliGSiV/D1wPUjE369FbJqz/6WnOlRQz3fYqpbBlBzT 0SPHehj7uaCIiTV12lJMz1k7r5ATq/rqpLkF7N5GIWim24Mi0t9D58C5Wsnth8ClCcCi CzAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772039661; x=1772644461; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=M6Fai54Ul21d21qsppL/OgbjNjE4u/Ww2JyK/Frhu5U=; b=XKOKo9HOQOleqB/4K6LMUFiYNVwWncfNH+pY//13UyrI5jqQV4ytlLUAld7ZMZd+zo chm9MXLtutOpYVNJXOJgi8zokIHFczW7gKP/p+C74LJs1cLotuHnm8Ofj9V+0jS+flgB X6Uo3g7Idm9bNY0GnEwAiBrluqWbiFu4hbH6A29NELg7Y8DJZStH9day9hyrUYJ+lrKb 9fziet6yzuFq/oPjqAj7i3eDPJVO87G5dY0Sj0VcNoXh5mqvPgW2EJLRiVDuMZ4sIMtw 0B/5bowla4r8f69MbhnGOq8YQd/H0cAtxEIe/l40i671yWSMAAIfh936l0THOGf9UERb ADvg== X-Forwarded-Encrypted: i=1; AJvYcCXlIwMY6rUg6WCczHH2bSt9VpdTTQJmy69ZWlALqpQdWt+XrLD1VdIrnqdKiepQoYMLUfvn2sD7LLp3C9I=@vger.kernel.org X-Gm-Message-State: AOJu0YyICN0MADsIZgNvceujfOOoaQxOUtua6+8A+neZu43BRK3wfdEZ mYg6SZcL/sonw9PK+zubdGiQKjVuWba+OBrphWlUaLPiEL4OQmxUZvwg X-Gm-Gg: ATEYQzwB9uZ7YU++akeRfip//h0LE9D8oe7bx/C5rVhKqOtnONGws0jkH+/Eak4txTE 8cbYQQerpQQQADhC6V+Mp7uHBN9nkAWIE5f/El1uLuIdOrLY9OT3CuDg2wstZzaeCBhwIUPBn9d YJacV8mSLTWYyG90/WggdQ60JA6UPJE2bdbZoAq0Hk3ZslZTJw9yugau96P2cESCP6DpSyzrlw2 EbBIJOBJocLsNtDyqHhaKThf/ZMjEnKsv0zOagbt3ae9IdgsZpBktWmz2Lr3b9yS9RLIYyurBXf ib4vtrQvmE2BgMNBp7br+DEKnxeNv9v4X1w/udY2mwQSlR5caM4LsS/6Q92fpD4Rz2iQEelwNbZ DIhIADwxrY3Z8fJ2yFaq4BoSeHYIa7PcQ+oQ4K/x/b7EWouZD+AyIOfyv6befy9wS1Mkbf1rr6A KJ0qg/kTc7j+9QRZiyLcFYsvANUW/oVxJp4FxePHJGl7u059HOvpzBal4UPVBh3E6L X-Received: by 2002:a05:7301:d1a:b0:2bd:b2c9:851c with SMTP id 5a478bee46e88-2bdcc070e66mr620754eec.30.1772039660613; Wed, 25 Feb 2026 09:14:20 -0800 (PST) Received: from google.com ([2a00:79e0:2ebe:8:64dd:9670:711a:678e]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2bd7da4775dsm9332416eec.2.2026.02.25.09.14.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Feb 2026 09:14:20 -0800 (PST) Date: Wed, 25 Feb 2026 09:14:16 -0800 From: Dmitry Torokhov To: Hugo Villeneuve Cc: Andy Shevchenko , robin@protonic.nl, andy@kernel.org, geert@linux-m68k.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, hvilleneuve@dimonoff.com, mkorpershoek@kernel.org, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, lee@kernel.org, alexander.sverdlin@gmail.com, marek.vasut@gmail.com, akurz@blala.de, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH v3 4/4] Input: charlieplex_keypad: add GPIO charlieplex keypad Message-ID: References: <20260225155409.612478-1-hugo@hugovil.com> <20260225155409.612478-5-hugo@hugovil.com> <20260225114155.3ee2efb002aa0f52a905f535@hugovil.com> <20260225115652.8beb1979df3824f7a95d22bc@hugovil.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260225115652.8beb1979df3824f7a95d22bc@hugovil.com> On Wed, Feb 25, 2026 at 11:56:52AM -0500, Hugo Villeneuve wrote: > On Wed, 25 Feb 2026 11:41:55 -0500 > Hugo Villeneuve wrote: > > > Hi Andy, > > thank you for the review. > > > > On Wed, 25 Feb 2026 18:12:13 +0200 > > Andy Shevchenko wrote: > > > > > On Wed, Feb 25, 2026 at 10:54:01AM -0500, Hugo Villeneuve wrote: > > > > > > > Add support for GPIO-based charlieplex keypad, allowing to control > > > > N^2-N keys using N GPIO lines. > > > > > > > > Reuse matrix keypad keymap to simplify, even if there is no concept > > > > of rows and columns in this type of keyboard. > > > > > > ... > > > > > > > +/* > > > > + * GPIO driven charlieplex keypad driver > > > > + * > > > > + * Copyright (c) 2025 Hugo Villeneuve > > > > + * > > > > + * Based on matrix_keyboard.c > > > > > > A single space after asterisk is enough. > > > > Ok, leftover from copy/paste from matrix_keyboard.c :) > > > > > > > > > + */ > > > > > > ... > > > > > > + bitops.h > > > > > > > +#include > > > > > > + dev_printk.h > > > + device/devres.h > > > + err.h > > > > > > > +#include > > > > +#include > > > > +#include > > > > > > + math.h > > > > Ok. > > > > > > > > > > > +#include > > > > > > > +#include > > > > > > Is this in use? Or you wanted mod_devicetable.h for OF ID table? > > > > I need only OF ID table, so will replace with mod_devicetable.h. > > Hi Andy, > finally I need for of_match_ptr()... > > But I will keep ... Do we need the dependency on OF? We may include of match pointer unconditionally and the driver could be used on ACPI systems with PRP0001 HID. Thanks. -- Dmitry