From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f41.google.com (mail-oo1-f41.google.com [209.85.161.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 208532744F for ; Wed, 25 Feb 2026 17:24:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772040251; cv=none; b=I2EY+K95sSea7Q+mMH62JRCsWczonjNZruWUsmD0dqRJr3hIUxCj7pOxTMxNcl/Ep8j315Vl2OKIV9MiPbFBmumBhIamBc7nFF2iRxUdEdfAQqIMMLuB+cZEDQaUFR5fDjLKx54FvV5+/NqIk0E5I8FQQ17DsVRfezbKvBtx44g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772040251; c=relaxed/simple; bh=kFBUeSrCJcgeVZQHXlbB3qF3h65fAHKQt2LY2SMsUkk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mMIHSnYpdYlwKGX0lvlgxcnKaWTxEfCGaS7wbsrCrmVH3XKVaVA4k0cGPGHpCe2fpYvcYq1aVXkLxIJGJiNEFBtfRTsJWNBb+oLIYK5Edx1Cz2P7JYYBvEA21pmMQDBYe4Wfy05Y7nsYqKBUqifEFxxD8LKWPQVqDd276/cKa8g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TLWgPiTP; arc=none smtp.client-ip=209.85.161.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TLWgPiTP" Received: by mail-oo1-f41.google.com with SMTP id 006d021491bc7-679b072ed3aso8715eaf.1 for ; Wed, 25 Feb 2026 09:24:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772040249; x=1772645049; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=kFBUeSrCJcgeVZQHXlbB3qF3h65fAHKQt2LY2SMsUkk=; b=TLWgPiTPQcFT4FyiIJiE++XezeE5pOn5AmxSGW0hSI2EmiKgZ27LgYwItzK+Hr3vzh tw2lTsm6Wekh919OJBXyEfyjNFvUggcw3kKJrTe+HcCI2OvmNPJKND8Dhjgp3c+BsfiC GwRDyU2K9nV8QEgtoPMvrPNp19VV4t44g6dgkby3iqPToKn6k4S6oP65RDgUCAzSrjOy mKPa95frbkBnMopFJfHrQ6u9u4XMorlGyZ1XYlnVBpoUYnnGd8DYb7t9E6DjgqkgxbWB AFEuhUlv25gWnyIEv8HfwlIZmURTjyr8B5/DguBtcg5Dd8xhnsaAfysMd6Sff7VfNpW8 HLvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772040249; x=1772645049; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kFBUeSrCJcgeVZQHXlbB3qF3h65fAHKQt2LY2SMsUkk=; b=Gi2iBTYagYENk0sX+X9fAGEVMgiE79s2oeN9cqaNWcdEEOPwbm1wF9+aon3dpdywin QDvdPaKCULQE3X4oitJnj55lLwd60d4RMIfjlTh9uQIkFCMXhreK/XdQM03eKG1FV0GT HkmEKTzkgdZHghdeAMnTrK7K/Z/83+Ijh+9uCBqiPG2+HAyrnRkPYXSYX33p0jgx3mGi PxXQWuk6W3meNOey19ip2QR7O+5n5ndbMoy77Ca2XMjo9ju5G3bod9CaMp3b20YXCzOR 8pOADryjydsJzE+h1oVgzbC7270IUNFNo2M7XIMc1YoSsTHkAfwU3XFhT0zteTFI9bdl 80kw== X-Forwarded-Encrypted: i=1; AJvYcCVhczkwQB58i54gS9E5frKodJZjGcyeR/TtvwQS3wjr/keMBbIo+eIyG52PmLiBv8aE8TBiZD4ZlbiH7PA=@vger.kernel.org X-Gm-Message-State: AOJu0YxQYOpFwoVQ3TgD7cua61uUA3/br6ZO0mkQyt40ASFRWnSfC0vz RT/8UiaUkGqQo4VKQCJ8Ar8o+N5G3gzzPrajlZSES2gEc1HZGEqweWYp X-Gm-Gg: ATEYQzzUDX718yMVc7TAapR7ukUTKqf+rQJjJ0bb9T73D9zPZ0kNYitvMwvENSM3gKh nL0YRT6cUzAByeHCO7ZrzgiY4JqZw2UY6ln6vHsKmczDFWWEKEff7LMkBsLYIzQcsNTKmBaFXDL badACy5tGrECL/SqiYqWddKMwHjsVa93QV4GthegnCLojzLcJZFGNLNYOu5OTymJy5XyAoo4t9R LZz54WnhZe1DXj3/rxy45Yhjjpz+WeZlaCOEldDqbKM1dhVyagIVGxLWCC5Pn+E4w6hJorQLGQZ U7uPDO6ydPhwaeJSlwF40dk2giBlWXB4qUL7KufV+I2wOjrHr9/x4bKjOFdYGLc44dDS1Tf5QiQ NmwKoGEnaNR4VNQwylB+aUkBc8SVzDSuUnUIMExCUPvZePIjn/srdgg3F3VbBT+D8R9cGzS7ZIV Ok1NFxPfI4wFl4ba6gZ1uvj/oR1+sjwkoLuDb11A== X-Received: by 2002:a05:6820:1799:b0:66e:e441:857f with SMTP id 006d021491bc7-679ef9832ffmr601352eaf.51.1772040248944; Wed, 25 Feb 2026 09:24:08 -0800 (PST) Received: from fedora ([2603:8080:10f0:ab80::1382]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-679c5630827sm10737190eaf.3.2026.02.25.09.24.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Feb 2026 09:24:08 -0800 (PST) Date: Wed, 25 Feb 2026 09:24:04 -0800 From: "Vishal Moola (Oracle)" To: Zi Yan Cc: Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Kefeng Wang , linux-mm@kvack.org, linux-kernel@vger.kernel.org, SeongJae Park , Ron Economos Subject: Re: [PATCH v3] mm/cma: move put_page_testzero() out of VM_WARN_ON in cma_release() Message-ID: References: <20260225031231.2352011-1-ziy@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260225031231.2352011-1-ziy@nvidia.com> On Tue, Feb 24, 2026 at 10:12:31PM -0500, Zi Yan wrote: > When CONFIG_DEBUG_VM is not set, VM_WARN_ON is a NOP. Putting any statement > with side effect inside it is incorrect. Collect all !put_page_testzero() > results and check the sum using WARN instead after the loop. It restores > the same check in free_contig_range() before commit > e0c1326779cc ("mm: page_alloc: add alloc_contig_frozen_{range,pages}()"), > the commit prior to the Fixes one. LGTM. Reviewed-by: Vishal Moola (Oracle)