From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD14933B960 for ; Wed, 25 Feb 2026 22:33:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772058798; cv=none; b=M406nucIKNqeo6Q0YAOQaNqlYsVjsv8C+TBF9any69q3j/7ogz+bUEJ8G4NttNadTPdZgT+jDfcv4UiKNNl1KRO5TFnwBv8YZq2yBbngpJcL7eKGUoNfTdYbiR1vWe2/yWNVX+CxXbgNi0BawQSUp5R+i6UN4MToANN2wm8PAbs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772058798; c=relaxed/simple; bh=ub4YPOS9MW8FeneJ+8J7whwUxcyuGRtYV/5WM5Rvo3M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VBWn+AjJfZ4uqbqwqo5dOclSnU0BqgMbIj/6dRc5HtulaT8QjzWpzhs32zwaOTZp3qUqYTrpOLdf1iDoHFMsTcYcQxqYe9s56AvX3byORXA4KeeHcrMLmo+BjK1d2xyAUGCypW22ewu5bqECEhvrxrE7Xpwnih0idYfIYTQfP9M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=CR50LbXG; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=SLT7UbuT; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CR50LbXG"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="SLT7UbuT" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1772058795; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZJ4w+GJGB5YcT1aoYf5wDNw6bacytrNfbyC1gI6kr6g=; b=CR50LbXGY5Gr7PO0eZWchITvtU04mstDII1WL7afH9YbAg3rzoe+dtxtH0ByGRaGTDDjxC l+vY3uqrZlRQ5DPrT1aS4Y8ujnlISa844+HjiytgGn1KhlxwArliSsnriaiz01sOuD4VRU giFWijBWbSFEwGudo69N+8Wq1H8kX5Y= Received: from mail-yx1-f70.google.com (mail-yx1-f70.google.com [74.125.224.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-478-zDDPeeXlPVi37Q2Cpx5RlA-1; Wed, 25 Feb 2026 17:33:14 -0500 X-MC-Unique: zDDPeeXlPVi37Q2Cpx5RlA-1 X-Mimecast-MFC-AGG-ID: zDDPeeXlPVi37Q2Cpx5RlA_1772058793 Received: by mail-yx1-f70.google.com with SMTP id 956f58d0204a3-64956932a51so107432d50.0 for ; Wed, 25 Feb 2026 14:33:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1772058793; x=1772663593; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=ZJ4w+GJGB5YcT1aoYf5wDNw6bacytrNfbyC1gI6kr6g=; b=SLT7UbuTH8p0tjvUb0Pux678M4B1kb3BW7hgGLnAhokDai7/HUCrtt0b7GkFz6uE6i iPfJ/X4zItt0xCTvwaLZXLcmcAs+cQ22zgHasfm8k1mOHaFZpe9OjhTiSUhlDkexuhSQ 5v/KO91HF7TSiaDJ46pMP8KKn8nd8Ufkrk8nIsg++Av14jZmHfoTVOg4fLL0OLJHyVsl 0MG4ugUbI0Eb9mkopTNHtW8CyGdUcsm7oKtbD/iw35+8oJrg/Hx0Gg6egtOmLOVvxhPd 6RjixcbmlaOO3vzM3TdjvbHRGt8LDViSAN9b+cN3w50cdO9bJcSt1Y4d72pQyQrPL/+L elCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772058793; x=1772663593; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ZJ4w+GJGB5YcT1aoYf5wDNw6bacytrNfbyC1gI6kr6g=; b=Wvkxnp2itnniZl/dY0d8S7QCnH2z+04I06+/JjcPnSCWlbcvs/BzxSIjuWlM6eWYj+ ybMYCtUIGpG8KtQGMme4lJNLLGs9G1gNwO07mXTtWg922za4PQcghkHZW/ZfS1hFz/XZ aXdCXEUxxGYK30n4aJKmsXVbpgENsJg2SnrgkCMJUUEn0Dfpx9dFKtqhQNtbhF6GKGsd xXVlq8a88jqTmnQQ5muCstN3eQnPGQF5g04AwwLTtSB4reux4Dvf5l+jn2x6mAElF0/0 reY8MKWH353hiyUGQlQCsuo3NkM2T9nux8SWUxpqWlDgYkOeGFE9J1ZhM5r3dSt6PX5b 27tQ== X-Forwarded-Encrypted: i=1; AJvYcCWcj11iYuAkruJ7z250QZZAFJvIamoSezvsFHfUXBolsGlpmI3Za0J8wsOdcGQ+eLSAXEdtU2dr0DoR1hs=@vger.kernel.org X-Gm-Message-State: AOJu0YxWp93pMwe5Ie5cT8vy1TzwkQ9LXocjN/xiUP5WnL9RRNrGoljn 0IChq6BzThHrkVyNgiXasr8951LgXsFXN0T/WJTUiiiMhXALjvqfAnnoI6mfy0P5d9aynkxNVdV MHyBFOTK4WTS67qNX2aLOjkBqHTIc/2y/d8DpD3ExdFllnrquaoCJq4ZW05EhaWbWOg== X-Gm-Gg: ATEYQzw+JsCRDQKkC8f23L4Q893IE3oyPE3sRoqBzWAk9pfmmVb9/aCJ9B1EZPkrGjG Ku7FEYcPo/JLI1dO0pYaY3pCXdOBFSY3aUiijxI3jbL9+vZI/PredYC9eTXxVvFkpsyBloDehe+ kqG+wV2eBPIyBnZPPHoD8lx6Aw+Ko7qyJ/9sricJej5JcTj4C6fXaFtnSZDKzjnKVInqVvrzG9T R/q7spMlCvOWZJ7Vi4te290WRhBUfY/HWm1gvJRbBLlJtHuprWIo6n+R3galeme+xXFeA0tSFJJ UkoNkbSsfORNOm7808k3+4SqTaMR7yDj7gU/LUG7d3NaEqWRrgYjhXewg6+hNNN4gfDt6wbYwJc A7AK6BWyiO+TPShIGnAE= X-Received: by 2002:a05:690e:1909:b0:649:58f1:6ce2 with SMTP id 956f58d0204a3-64cb7c6a7b6mr183181d50.63.1772058793457; Wed, 25 Feb 2026 14:33:13 -0800 (PST) X-Received: by 2002:a05:690e:1909:b0:649:58f1:6ce2 with SMTP id 956f58d0204a3-64cb7c6a7b6mr183158d50.63.1772058793037; Wed, 25 Feb 2026 14:33:13 -0800 (PST) Received: from redhat.com ([2600:382:811f:bb35:ae9a:1ac7:e1d:86ce]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-64cb7626ff1sm162622d50.13.2026.02.25.14.33.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Feb 2026 14:33:12 -0800 (PST) Date: Wed, 25 Feb 2026 17:33:10 -0500 From: Brian Masney To: Andy Shevchenko Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Turquette , Stephen Boyd Subject: Re: [PATCH v2 1/3] clk: x86: lpss-atom: Use predefined constants from units.h Message-ID: References: <20260224121159.3503754-1-andriy.shevchenko@linux.intel.com> <20260224121159.3503754-2-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260224121159.3503754-2-andriy.shevchenko@linux.intel.com> User-Agent: Mutt/2.2.14 (2025-02-20) On Tue, Feb 24, 2026 at 01:09:20PM +0100, Andy Shevchenko wrote: > Use predefined constants from units.h to make code robust against typos > like how many zeros to put. > > Signed-off-by: Andy Shevchenko Reviewed-by: Brian Masney