From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org, driver-core@lists.linux.dev,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Danilo Krummrich <dakr@kernel.org>
Subject: Re: [PATCH v2 5/5] regcache: Amend printf() specifiers when printing registers
Date: Wed, 25 Feb 2026 21:24:32 +0200 [thread overview]
Message-ID: <aZ9McAzXLejc3Ttl@smile.fi.intel.com> (raw)
In-Reply-To: <a2e1dc8d-584c-4c72-8e9c-558a220ab5d4@sirena.org.uk>
On Wed, Feb 25, 2026 at 07:15:18PM +0000, Mark Brown wrote:
> On Wed, Feb 25, 2026 at 05:15:59PM +0100, Andy Shevchenko wrote:
...
> > - dev_dbg(map->dev, "Writing %zu bytes for %d registers from 0x%x-0x%x\n",
> > + dev_dbg(map->dev, "Writing %zu bytes for %d registers from %#x-%#x\n",
> > count * val_bytes, count, base, cur - map->reg_stride);
>
> I'm really not convinced this is helping legibility.
You mean the only this hunk, or the entire patch?
If the former, I have no strong opinion, can drop it as 0x%x is (almost)
an equivalent to %#x. For the %d --> %x I think it needs to be applied as
it makes harder to debug and follow when some of the messages use register
printed in decimal.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-02-25 19:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-25 16:15 [PATCH v2 0/5] regcache: Avoid accessing non-initialised cache Andy Shevchenko
2026-02-25 16:15 ` [PATCH v2 1/5] regcache: Remove duplicate check in regcache_hw_init() Andy Shevchenko
2026-02-25 16:15 ` [PATCH v2 2/5] regcache: Split regcache_count_cacheable_registers() helper Andy Shevchenko
2026-02-25 16:15 ` [PATCH v2 3/5] regcache: Move HW readback after cache initialisation Andy Shevchenko
2026-02-26 12:20 ` Mark Brown
2026-02-26 13:27 ` Andy Shevchenko
2026-02-26 13:41 ` Andy Shevchenko
2026-02-26 13:57 ` Mark Brown
2026-02-25 16:15 ` [PATCH v2 4/5] regcache: Define iterator inside for-loop and align their types Andy Shevchenko
2026-02-25 16:15 ` [PATCH v2 5/5] regcache: Amend printf() specifiers when printing registers Andy Shevchenko
2026-02-25 19:15 ` Mark Brown
2026-02-25 19:24 ` Andy Shevchenko [this message]
2026-02-25 19:26 ` Andy Shevchenko
2026-02-26 11:10 ` Mark Brown
2026-02-26 11:47 ` (subset) [PATCH v2 0/5] regcache: Avoid accessing non-initialised cache Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZ9McAzXLejc3Ttl@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=dakr@kernel.org \
--cc=driver-core@lists.linux.dev \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox