From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f53.google.com (mail-ot1-f53.google.com [209.85.210.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE57023EA8D for ; Wed, 25 Feb 2026 22:11:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772057475; cv=none; b=pWOsB8imqv7IoPIiEIHxE+RIiZWqkNaguRlRRKBgVZqsSOQexeXDy/QFzhnhvvT5TVyzP07XSYDeGHT/5lTQ8p8Qm51MrDAirIE4FHe7d6yUfML3VSg4hWi/qhQajapYOftRf33uDVbGZTVocBWDPBGZvxtchcfQvKLQmM+K86E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772057475; c=relaxed/simple; bh=040+chYFRp8ObmlQdUo/liyivcE3aF9Yn4UUZV31FOs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CsyUlnsfU6QK5DrdhVsdQgPvtm8ltnyAi0vRYNNaCZ0nzYDYBpF7kjSR3F/xp4WbsxkZWptqAZBl8YLQH4wOcSUl6bJ2GQOxTIOYpqboWx1YVnzzON5fjDCqobgroz9JTwb/zVgDyN97XJ7qIbN4yUO4PqI8JHIEVBkA7ix7470= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mUlp/MGS; arc=none smtp.client-ip=209.85.210.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mUlp/MGS" Received: by mail-ot1-f53.google.com with SMTP id 46e09a7af769-7d195166b2cso72369a34.3 for ; Wed, 25 Feb 2026 14:11:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772057473; x=1772662273; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=vU6GlShc4/RKkhIbjvbyyJHXZFOxo4/Rb7lB1rnFGYI=; b=mUlp/MGScVtmUbojGpeaUU3GpbLwIObMShELoJslnzOrkreMSU9nuicZnHRHkAVzOI Vfnr94l2weHgrfrweoM6D6/liREfGgPYsnCg08PvHrdhhTuHanW5wg6xshkjC9nojsV+ U/iIqrM+Zf80muNq+k6TKN5YuOfnJjWDPfp8D2ECr6/MDreRnJ+U5fKuvUXrRXjXIluW z0DMsHVERrsR74ulSia1Jua/Nq7J2y+MCwN522g/XXD7gMHQtqryGLiObC4fC8upwiLV cw2HCHfBf/Yy4t9Q73CdLfyHCmbzZCY33sixp8yc6XvHYD5In7mdIujDc4AkqR84/o1R YI9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772057473; x=1772662273; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vU6GlShc4/RKkhIbjvbyyJHXZFOxo4/Rb7lB1rnFGYI=; b=S+hQjGS0KMVnKtkV+U0IkYsoC48qsOQWMAjKm1Z3UNq/3y6b/V8sZaasFq960iLyUK 5OvYtDGca8taHpLP4OtiFIM5u6UHhN5m3ii3l1rVZ3Mk+SKnJxF0HdWSN0aez4zTMUGY ixtlEQ4u3/pykeoQxZA75Fy5TXgAWp97AAO/brAhh/uNRlC9SIkRWxEnJ34sV6gE+bFw 5vkjHp07a4/nEPhar//EC6VFjpuPW7L4GZPAvoffcUh2EF4ob7qTfU2YDNCaQOgHblMx Yh9MdsvsBJIIZSgjSbhCqp8co8m5gMCRVi0oWqFUUxk8JcrxX82fb9srVdywtwAg7dAe YtuQ== X-Forwarded-Encrypted: i=1; AJvYcCV/95JrKc9VViXQOwEiaHmBZdRuq4v9EoToRdJ+Uvx4ny4Qnzi0LbEB1SVYGb7dEodok9dbf4SfP1uip9k=@vger.kernel.org X-Gm-Message-State: AOJu0Ywie/mQSGix6LMGzwiVqP8FGvAyppvVwNvLwpdN1BRzItRu6Zx5 IYor3g1BL8Xh7+uqWqfUMsAYPucWOjs0KlVemMmF4eMcLeUdrRr15sha X-Gm-Gg: ATEYQzytV7p6BqK3w9FjD9/UYVCU9ctr1FIq7e6LQriqBUVfHSDwnQ+8iUeZIIDqzUS qYzpLwcTWy1oKl2Blz5jG7pThnyVccXCTpBvYr55uEBTxNKDDkFhlusH/HgSXvzVilgpg32rZrd HtzXVu40AlUxL5yRyaBKBbs1XbBqZ7BXE1P1pZjEU2CxhiyzeI5vXJakBI3oRod33jfZflGRlT5 ryoyx/fBtnYJphCzMugfA3Pp7ohztlnBMFg5rUOaVSXIe5XJgSZ1Q1S8OceGuuDD13bMJ6nf/Uh Ts5aVNa6j2FmN7nXAL+oLN92oD91ToDvn3mS8JA7ulS9RkOxJT6EWn1ngVrSAP7m9VK8YoJ6bxy bFPr5udfhQ2FgHONVcGUQb8UiXlp2Fy63UqTjGGuIQeJ3gflkJm8JOJyYcFwFqzW8Q24vFyJalI SCWpWFSz2w3i9lnw3rJTqtZDVoqGq9Icdjm4sG3w== X-Received: by 2002:a05:6830:1b78:b0:7d5:2c30:9fba with SMTP id 46e09a7af769-7d52c30a246mr8551076a34.24.1772057472770; Wed, 25 Feb 2026 14:11:12 -0800 (PST) Received: from fedora ([2603:8080:10f0:ab80::1382]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7d58666f30esm175108a34.26.2026.02.25.14.11.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Feb 2026 14:11:12 -0800 (PST) Date: Wed, 25 Feb 2026 14:11:09 -0800 From: "Vishal Moola (Oracle)" To: Axel Rasmussen Cc: Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , "Matthew Wilcox (Oracle)" , linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] Revert "ptdesc: remove references to folios from __pagetable_ctor() and pagetable_dtor()" Message-ID: References: <20260225002434.2953895-1-axelrasmussen@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260225002434.2953895-1-axelrasmussen@google.com> On Tue, Feb 24, 2026 at 04:24:34PM -0800, Axel Rasmussen wrote: > This change swapped out mod_node_page_state for lruvec_stat_add_folio. > But, these two APIs are not interchangeable: the lruvec version also > increments memcg stats, in addition to "global" pgdat stats. > > So after this change, the "pagetables" memcg stat in memory.stat always > yields "0", which is a userspace visible regression. > > I tried to look for a refactor where we add a variant of > lruvec_stat_mod_folio which takes a pgdat and a memcg instead of a > folio, to try to adhere to the spirit of the original patch. But at the > end of the day this just means we have to call > folio_memcg(ptdesc_folio(ptdesc)) anyway, which doesn't really > accomplish much. I recall making sure we had a memcg_data member in ptdesc so that ptdesc could directly reference it. Until we have a generic version, reverting this patch should be the right way to go. > This regression is visible in master as well as 6.18 stable, so CC > stable too. > > Fixes: f0c92726e89f ("ptdesc: remove references to folios from __pagetable_ctor() and pagetable_dtor()") > Cc: stable@vger.kernel.org > Signed-off-by: Axel Rasmussen Reviewed-by: Vishal Moola (Oracle)