From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: David Lechner <dlechner@baylibre.com>
Cc: Neel Bullywon <neelb2403@gmail.com>,
jic23@kernel.org, nuno.sa@analog.com, andy@kernel.org,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 3/3] iio: magnetometer: bmc150_magn: minor formatting cleanup
Date: Sat, 14 Feb 2026 20:00:12 +0200 [thread overview]
Message-ID: <aZC4LBKjjZSz5k4L@smile.fi.intel.com> (raw)
In-Reply-To: <f53438af-0177-4326-acc5-aa653046052b@baylibre.com>
On Sat, Feb 14, 2026 at 10:31:44AM -0600, David Lechner wrote:
> On 2/10/26 5:39 PM, Neel Bullywon wrote:
...
> > +} bmc150_magn_samp_freq_table[] = {
> > + { 2, 0x01 }, { 6, 0x02 }, { 8, 0x03 }, { 10, 0x00 }, /* 0 - 3 */
> > + { 15, 0x04 }, { 20, 0x05 }, { 25, 0x06 }, { 30, 0x07 }, /* 4 - 7 */
> > +};
> >
> Just an opinion: I think it is easier to see the patterns in
> the numbers if we leave it as one struct per line. (Fixing
> the indent and padding is still an improvement.)
I proposed both, so I'm okay with that too.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-02-14 18:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-10 23:39 [PATCH v6 0/3] iio: magnetometer: bmc150_magn: cleanup and formatting Neel Bullywon
2026-02-10 23:39 ` [PATCH v6 1/3] iio: magnetometer: bmc150_magn: use automated cleanup for mutex Neel Bullywon
2026-02-11 8:39 ` Andy Shevchenko
2026-02-13 23:31 ` kernel test robot
2026-02-14 16:34 ` Jonathan Cameron
2026-02-14 16:28 ` David Lechner
2026-02-10 23:39 ` [PATCH v6 2/3] iio: magnetometer: bmc150_magn: replace msleep with fsleep Neel Bullywon
2026-02-11 8:40 ` Andy Shevchenko
2026-02-10 23:39 ` [PATCH v6 3/3] iio: magnetometer: bmc150_magn: minor formatting cleanup Neel Bullywon
2026-02-11 8:41 ` Andy Shevchenko
2026-02-14 16:31 ` David Lechner
2026-02-14 18:00 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZC4LBKjjZSz5k4L@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neelb2403@gmail.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox