public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Nikolay Kulikov <nikolayof23@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	Ethan Tidmore <ethantidmore06@gmail.com>,
	Rivka <rivkab300@gmail.com>
Subject: Re: [PATCH] staging: rtl8723bs: rename camelCase variables
Date: Sun, 15 Feb 2026 11:04:28 +0300	[thread overview]
Message-ID: <aZF-DIvCHAHVtK2B@archlinux> (raw)
In-Reply-To: <2026020733-blatancy-periscope-e425@gregkh>

On Sat, Feb 07, 2026 at 02:43:16PM +0100, Greg KH wrote:
> Why did you pick these names?  You kept the "p" prefix for some reason,
> which is "Hungarian" notation, and is not a kernel coding style, so
> shouldn't you just use a name that reflects what this variable is doing,
> and not encode the type in it?

Hello, thanks for the feedback - you're absolurely right about the
"Hungarian" notation. I should have removed the 'p' prefix,

I see that Rivka has already fixed "pHT_info_ie" (with Reviewed-by from
Ethan Tidmore). To avoid duplication, i will send v2 that only fixes
"pHT_caps_ie"

Thanks for teaching,
Nikolay

  reply	other threads:[~2026-02-15  8:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-06 12:25 [PATCH] staging: rtl8723bs: rename camelCase variables Nikolay Kulikov
2026-02-07 13:43 ` Greg KH
2026-02-15  8:04   ` Nikolay Kulikov [this message]
2026-02-16  7:28 ` [PATCH v2] staging: rtl8723bs: rename camelCase variable Nikolay Kulikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aZF-DIvCHAHVtK2B@archlinux \
    --to=nikolayof23@gmail.com \
    --cc=ethantidmore06@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=rivkab300@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox