From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 89F582C029D for ; Sun, 15 Feb 2026 08:04:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771142674; cv=none; b=XpabaTyIZHfTqRsLv7UFNz+T/nKgAh00+Mf/Z/6WP17DM2dqcCDwLE9+HQFzoVeyocTtLEMFlf/mevvVXP4L8AR3zPwHfpdJzTsGBsfeUbT1PW6f8h8egz1JnS6dKNLXFzZ0LbA/+Jvuf7VNpxXQlQoJeqZt0nv73eJCHX+zHgo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771142674; c=relaxed/simple; bh=gia3U0NMi0eo9lNjIlFbqZyufBLX9qOX1Qtq24tord8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UzSv50ppUC42/lCpX9ihTjxvWy1H2Z2nfOW0lgjwxzbWRCU598AQMUr+xI3pNqQF1rOVSRl0UIKGxXb1LLG1RLp+Tctl+t3WKws5WZrzoojZyjJxdL6aDLOfIKWsKXctjFEED21Mp7OLPKcWMM4+mImivx6C1JcfqGCBGefAUFM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=S+mVUxre; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="S+mVUxre" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-4359228b7c6so1592871f8f.2 for ; Sun, 15 Feb 2026 00:04:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771142672; x=1771747472; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=r44RmfAkOHN1ghzwJGbO72qc0QPba/sx3DF2Yww1PYU=; b=S+mVUxref+yYUkZgqjkEfwPa4x9PiUK3qwVmF1OA+NBAAlUV/7evajHaAPsk+bYbTs BfBfWWB12Pk9HKWJnUE8n3QDe9XQ85ZL7BQoopqxVs23y2XbNbPUjXQfiuVeLtMmTc7n OoRQpBx3Ghb5r0Q8AIvuy9sUP5xmgEVe0mBEyypbqdHdcHENHiGU/mAjINkP+JGHYtqW rNHJvUbeESPcwIOf0FLNEIAQjV75HCizD32UbWDgEqBVuEGulemMRZqwosCteU8eGvXz dgyGAOAbByopbulCwbhkuohdBvbxHYXgwbd/iVmXg8KZm5U5du8WvVMY4eJdh1LH28uw CTsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771142672; x=1771747472; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=r44RmfAkOHN1ghzwJGbO72qc0QPba/sx3DF2Yww1PYU=; b=eTmjA/Ql9g3d060wwUxL54inF9gLKAoQAlXVRRCZnnfc1XlMya0lHu09XJYm0OCYdI PX1LaY/BtvrpzydE5xH/9Xi8K82iTuaGNJbOxHhQivNErkFdbxIEWdjHak/ZGphnFyAQ tieztdRx2CQBX3yAW37njbJFJIL7NisEJhFUboCBdgySFoBajnz3FS3t/KwQfFSNdRIA 2sfpNJTnMq1jz8XpAznpuccDZMiKUHbF8x5bDHWVaUJ9wK0IduExgkA++/hf4f8s1o7H hdFk6xMmDZZAwGtYf0reZmqy3fFJUq2on/weRP7AWBax8V6SWKsuXikSPWADH8bA2cpq PWBw== X-Forwarded-Encrypted: i=1; AJvYcCWwGtEFCKnBxNxhcs16h/dX66/Nif5fxN/rBepJtYXg4rfL0L9TNRitLsjPE/XOhTNgicCulu7+s1TA5CE=@vger.kernel.org X-Gm-Message-State: AOJu0YxLftvg3oyVGudvVQ2jYa3Vj6pR1XMge85tklSyzdbtg9ssmBfM mrw8CkVNFnodY79BWiqPYtdY97z2UrpvSBWr1KSILVUIoWF/FlywiVuj X-Gm-Gg: AZuq6aID7cvDLHW+jfYxAe6dOK7ECcNibQmU01WvXz5ixvSbtJ97HeuSSPftjTST5M/ r+P1fElg8hNR31NxfPOUx69d4uonryNhtOUyZz3kmpoOExqKfO461p9ceuXQ5SbG6W6/xbNBkoG DPP+iQePP7GSr1upfCtoFj95GPQbvoY9z/qFyF52W3J/ZSQUedu6FghqRNs9mRn8WVC7sAC4jdV NxYhT2Or8WLlvHugorG6JOdt1dgGmWXKMXxjPpsTFfxyi1Ie1P7LXD0YWhj6lr3BAGal9VemCS2 R4MKp7CFHfxQjtMP450LOxGygbMs59oh32ZRtYpnrN5l/NbC0u333LeXO7T1BZ5OyHibSDCPZuq AhyvSKpS5j2C1vG8ZE91arZgvOLraLudqAeMcVFJkZ4WuipE33tJGXOiOzS6k5d5EVqFhm6+yud PSf7ogaFWgvQ1+xSczQ6Cchw== X-Received: by 2002:a05:600c:198b:b0:475:dd9a:f791 with SMTP id 5b1f17b1804b1-48379be5cb8mr72744045e9.28.1771142671556; Sun, 15 Feb 2026 00:04:31 -0800 (PST) Received: from archlinux ([93.186.111.52]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48370a4e149sm87519745e9.2.2026.02.15.00.04.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Feb 2026 00:04:31 -0800 (PST) Date: Sun, 15 Feb 2026 11:04:28 +0300 From: Nikolay Kulikov To: Greg KH Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Ethan Tidmore , Rivka Subject: Re: [PATCH] staging: rtl8723bs: rename camelCase variables Message-ID: References: <20260206123013.15533-2-nikolayof23@gmail.com> <2026020733-blatancy-periscope-e425@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2026020733-blatancy-periscope-e425@gregkh> On Sat, Feb 07, 2026 at 02:43:16PM +0100, Greg KH wrote: > Why did you pick these names? You kept the "p" prefix for some reason, > which is "Hungarian" notation, and is not a kernel coding style, so > shouldn't you just use a name that reflects what this variable is doing, > and not encode the type in it? Hello, thanks for the feedback - you're absolurely right about the "Hungarian" notation. I should have removed the 'p' prefix, I see that Rivka has already fixed "pHT_info_ie" (with Reviewed-by from Ethan Tidmore). To avoid duplication, i will send v2 that only fixes "pHT_caps_ie" Thanks for teaching, Nikolay