From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f51.google.com (mail-dl1-f51.google.com [74.125.82.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1AAC73090E0 for ; Tue, 17 Feb 2026 22:11:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771366314; cv=none; b=VcMnX79BlZ+c2N8uTs4/++FT1wINQ6nEgcRZE4pM9yom1+NIPLKEZD3Poyn/y1HaRNdQnKUcgbP4Lq6ZthFjbXy7/beg/vhhSA+fUdh8N8s5n/MYUppcRdHaUkEFftLfjlNsl4KoxR3jTpp1uofO33SlkWrLUZOMBl/WxpZenws= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771366314; c=relaxed/simple; bh=Nfm9sZLbTRNQxsMPnZMvEXDpJfkPUjKzjmZ0c50X78A=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=qYjqxh/nE/Ra/XXW0tZCHXNSU1uYO8adYtcfobmjK/qC7gA7AoIFgq+z8ZVnqJio6a0fYdhsBxTVkAseCzs9gDLKlFIVryR5twfcA0OcLztK/RnwkI1TSPK3st8RcTR4KyN4Kk8MhtWjUkZvGjDBMSY4GPj7jtypqoQOzEB5teI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JfehiB72; arc=none smtp.client-ip=74.125.82.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JfehiB72" Received: by mail-dl1-f51.google.com with SMTP id a92af1059eb24-126ea4b77adso5756613c88.1 for ; Tue, 17 Feb 2026 14:11:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771366312; x=1771971112; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=C+P7TyKy8JYgNvmXjAX6UhAcFjxUgUJoN1VfEz87ibM=; b=JfehiB72VRXTHmuoNierPX5yafCIz7oA1TzMB1Vj70aKAls3mPReSF1CfeNAIT/owh 0GeOdtEv/EmAdYTfPMYAR4Kb51n+Wbh4FsorsZ7m7MzFG1jui1OoDMpw4bgtimxLtOAW VHY2K77cb85LsQ4bTr7KH/HXdkdcZmSwQA4VMMIGcH3K3mSqwR2IHnT7HFErfa7Tcini uOr4erjb6direFku8YNUko++uwjbGO6QGLaEJp9IgULCckCMhu4Gg1I/psZ4RR5KlHFO IDHqUnb/f8ShrLrs+wdAUt3xLvm2Zzik2n3GOkjgJVE7dTzZxINtDuUKe3/DaDs8qvlR vBmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771366312; x=1771971112; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=C+P7TyKy8JYgNvmXjAX6UhAcFjxUgUJoN1VfEz87ibM=; b=JpuoFd7en/OEEWpbh1X+y3cQOFymKfT9BgqFcWt7mf3p3fi8uNJ0vNB9xicLdRcPFq PKeLiRfxyIPM4AdXEYBrR0JnxdJmo9fTKS4Rt0hc+wnAD/xzWy/9ogn57zXdLYCbeqWc caAhdVcNphBegnDWIDT+b7znfzLpgMwDT0azyOmQSiOLYbhAPWaME01S8KupUrfQE9U9 Pz5v4LIOhmuuNt7anHKgYxvYU6Wnot/H+fy1BvSTXWyuC5ZEWVPkGhNnH9SHhpi6Bqwu subYbnv9dSceobIAJDCTXRmmHbU6Wk5UgBqdBF2Jwh6IigzbYeTP/VzgSUyhBguYATDL aE4w== X-Forwarded-Encrypted: i=1; AJvYcCVgvEmv5PFn/iLoVt3CylojtFFYO6bMgFC7aYI1hPoQrXTt/tmG0CSNi2WqtcAt/CkBJJQe1N1eQNkWJI0=@vger.kernel.org X-Gm-Message-State: AOJu0Yz9eKs0nrzARrZPTVb0wcbNFQSUDMzNsCWU4LcYL46klmN587nT oOsmMMz9qKffdGxAChSG7MqBHAtwdpCc4EBOWUWz9XU8bDV/dyBfNzyG X-Gm-Gg: AZuq6aLUATstMsAISvD2dR+68wzcDrUYli0iHYZ8X49UMymsKskbs8f+P3KaZwN/Bc0 NPJr2rD6B3zusVcylKh8F8QGLjf4FYWpvIG8xDitCaw1yN2MR6SGey7Eji6yIo06xZSq5Aw3fof gTl7E88dC5S91rLB1cd1Y7PKO33WPwTVJhUd1tgjN0f6is9esXt/+SyA8Q6SzuZv3/VKQ6Xxz8W rmlpK8e7TwWy8H8ugvSxpJaXAFl3/kQ7zyR9NtRQ5LNdtPglyStjTNNX2qiTzmkDR1UNFUORdZl YMDkKZffdKqjtEscbXUrOTbYv3MUA2ymc71JTr3oFe5+4JGO93rvOtiI3DGF/51ftCn5E5GziEy XDXZDdiIiTQ7iIPyR4hft9UxTxcaiP5z1+t9J+Au/0V/iHAOhkwQlAU0mRiE6H5xiJBVSAM03of 7SGL8XYBFxAxRg0V4TBmyQbylOMmizdS9eDk/tE2eWkqUV0ljWg9TxDBG5YQo4BNWCGvvlZd6ug 4U= X-Received: by 2002:a05:7022:608d:b0:124:adfd:623d with SMTP id a92af1059eb24-12739819487mr6366167c88.31.1771366312045; Tue, 17 Feb 2026 14:11:52 -0800 (PST) Received: from google.com ([2a00:79e0:2ebe:8:968c:f102:3683:408a]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12742cc83e6sm16612704c88.15.2026.02.17.14.11.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Feb 2026 14:11:51 -0800 (PST) Date: Tue, 17 Feb 2026 14:11:49 -0800 From: Dmitry Torokhov To: Bartosz Golaszewski Cc: Linus Walleij , "Enrico Weigelt, metux IT consult" , Tj , Hans de Goede , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] gpio: amd-fch: ionly return allowed values from amd_fch_gpio_get() Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline As of 86ef402d805d ("gpiolib: sanitize the return value of gpio_chip::get()") gpiolib requires drivers implementing GPIOs to only return 0, 1 or negative error for the get() callbacks. Ensure that amd-fch complies with this requirement. Fixes: 86ef402d805d ("gpiolib: sanitize the return value of gpio_chip::get()") Reported-and-tested-by: Tj Signed-off-by: Dmitry Torokhov --- drivers/gpio/gpio-amd-fch.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpio/gpio-amd-fch.c b/drivers/gpio/gpio-amd-fch.c index e6c6c3ec7656..9f329938202b 100644 --- a/drivers/gpio/gpio-amd-fch.c +++ b/drivers/gpio/gpio-amd-fch.c @@ -8,6 +8,7 @@ * */ +#include #include #include #include @@ -120,15 +121,15 @@ static int amd_fch_gpio_get(struct gpio_chip *gc, unsigned int offset) { unsigned long flags; - int ret; + u32 val; struct amd_fch_gpio_priv *priv = gpiochip_get_data(gc); void __iomem *ptr = amd_fch_gpio_addr(priv, offset); spin_lock_irqsave(&priv->lock, flags); - ret = (readl_relaxed(ptr) & AMD_FCH_GPIO_FLAG_READ); + val = readl_relaxed(ptr); spin_unlock_irqrestore(&priv->lock, flags); - return ret; + return FIELD_GET(AMD_FCH_GPIO_FLAG_READ, val); } static int amd_fch_gpio_request(struct gpio_chip *chip, -- 2.53.0.310.g728cabbaf7-goog -- Dmitry