From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f54.google.com (mail-dl1-f54.google.com [74.125.82.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80FCE1DE2A5 for ; Wed, 18 Feb 2026 00:31:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771374670; cv=none; b=Z+3wxLhqlWbKL/kqM3jwfFjufQq91bOkpuA82/Hz0TjpvWJvC3R6hjk6T0bzPnCXheT7ofuwbhMGCxIH5tRwgK8Ujni4LO6nt71oBaqqd7lvLfQIXpmIQULPHC4C+G/hDQLj4faLnfr7ZELN/JzN3DfeiJCS3OqDQpYZ6XZ+X50= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771374670; c=relaxed/simple; bh=Y2Fa0g/eiWnBGtl7TW6Y8Fxqa981wFYoJqnEQ9J5DTI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CvYw/A/IBh9cHLfj1Bekq2buaRij6rfwNtig6RI9LknE8KJ97lpcnNMZinA9hEEW8/ugm5qehDtPJKw89/mU2ZzUf1g4jVE6TTllvqTQY6//MPH6bTH6VVKdM79rzPVbKlPCS1+XF06+LCm5kv0GLg5kl1DOzOsY7KFMWb/s190= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=H7EHxQCQ; arc=none smtp.client-ip=74.125.82.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="H7EHxQCQ" Received: by mail-dl1-f54.google.com with SMTP id a92af1059eb24-12721cd256bso5879544c88.1 for ; Tue, 17 Feb 2026 16:31:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771374669; x=1771979469; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Sg0v5gzcAHvCWeUv8SrWGgkElA1mA5SgiIxc3XoTrGs=; b=H7EHxQCQzO0WfhvoxtJjCdHi3nZgfw6X0lMl76bjBN+ISxt8UIMRJXOgOclTRkvAiS KIjaFFBIwXZQXJsdC+C0/Ir7YEatWth1NPmPVvFZMw1kBq8tVrL4On0Lyjb9zuXM9ASu WstOqUzxXOfgibQuEO+7WZDykWdDJJNpb7XSvzvIqQOiObLPRGBhiO17cseYCgWdGE8B KHVQL8yKMYH5SPtMymKssb2Y4drPGU/s9ipDzOH/kwfB2XR9OU/4baSn7yhmTzNWaahc S+bhmQDXzgixCo31wkGk7PRQLg6hWjqHtsMMZT9z2wLc6wOBRSuwe6gKZWT+uqIg70I4 KrUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771374669; x=1771979469; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Sg0v5gzcAHvCWeUv8SrWGgkElA1mA5SgiIxc3XoTrGs=; b=WBCyDd3soPosiTuB1dJtcenZFgiQpd+20mBdOkrpEn0ag6Ve+jBwke+0SykXLmPlpC vyHw7uPGPR35HZNpdFfQojUE/+bIuEm9oQl1+21++Sis3zskNkyscRKHzp1uzQISxu9T TdCrelH9cDIRBTo87bg1h8uX6xF/7rVPXXaByjXcUQDiCrT+q3PejzlUyZCdIpA/s9g6 tChxY7M0/33/MFnah0Ij+MaSQVzVEdmAmKboFgVjIDc0+1j4C4u1nb0QYeABfgeAsOye pSgabhJT2X8dQHjjUIGlmisqglAQb1D6XiK8ZzKVML6+RnqGQpNG+X9///xqoJKASQxn vtkQ== X-Forwarded-Encrypted: i=1; AJvYcCUsNtuO+swFG0hOM3rGUOhUG4iinKCK3E8n7kGLH194TZk6+qXRA866b6LMkfN8NZfsTJLBo9hEsZHborU=@vger.kernel.org X-Gm-Message-State: AOJu0YwdPKelRxvl258TiYw5mMCv6unE+mOv5CKD77+UO85E4r3GBBlC W90WKvvl7uSynOWVu2zrtrGeVDqNaSoygo08D3mcYedqjJP86qun69K4 X-Gm-Gg: AZuq6aJI26fKoa+OIsGOF2dGfARJFCIHVpF4qwz1PN7BAgXPcQFySNUj4AUzDQorPlB sJK9zcDIXJEMZjOJixU6YS1EkUZSdi+gEddkn6uzUBbgHp3A7Lc1W4MscVo3VFcGZFVxdfh3GUh tg538/No4kQmZaMQ4WN9a5+nfEO8y6fYyrCZUnJW7K/dAwS4QtpWw1Uv+70/7yZBRzrL1T+Agwq GtupB0+PZsErmSOlUBxGPRyuZU6egNM9u1HLAm+IMl9lf/XbdGI1LJNn+U3/CSMMkrIg9CrG4R8 HXCsO/97Ey+Do0EosF3OwvR/9AAvYUlvkHDvPzjfjJnlI3vm12arjb/TtUywbzXBC/qh5VRUcX0 jqqhwXeuqYfR8FbFsrxB2yENKRqN9XumYpb82BSF25kXPCzNnUjbkFxBHo71UGKAD+LI7RRSL3u IevWvFaHfvQJYHZYtTsQjsiODwclNLrDZXKRleUWW0alI1kD5CX3hMptOWxOVJ/SAj X-Received: by 2002:a05:7022:2393:b0:127:369e:5d54 with SMTP id a92af1059eb24-12741b71059mr5293643c88.13.1771374668482; Tue, 17 Feb 2026 16:31:08 -0800 (PST) Received: from google.com ([2a00:79e0:2ebe:8:968c:f102:3683:408a]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2bacb66bd17sm17035569eec.28.2026.02.17.16.31.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Feb 2026 16:31:08 -0800 (PST) Date: Tue, 17 Feb 2026 16:31:05 -0800 From: Dmitry Torokhov To: Bartosz Golaszewski Cc: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Greg Kroah-Hartman , Arnd Bergmann , Hans de Goede , Ilpo =?utf-8?B?SsOkcnZpbmVu?= , Dan Carpenter , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2] gpio: swnode: restore the swnode-name-against-chip-label matching Message-ID: References: <20260211085313.16792-1-bartosz.golaszewski@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260211085313.16792-1-bartosz.golaszewski@oss.qualcomm.com> On Wed, Feb 11, 2026 at 09:53:13AM +0100, Bartosz Golaszewski wrote: > Using the remote firmware node for software node lookup is the right > thing to do. The GPIO controller we want to resolve should have the > software node we scooped out of the reference attached to it. However, > there are existing users who abuse the software node API by creating > dummy swnodes whose name is set to the expected label string of the GPIO > controller whose pins they want to control and use them in their local > swnode references as GPIO properties. > > This used to work when we compared the software node's name to the > chip's label. When we switched to using a real fwnode lookup, these > users broke down because the firmware nodes in question were never > attached to the controllers they were looking for. > > Restore the label matching as a fallback to fix the broken users but add > a big FIXME urging for a better solution. > > Cc: stable@vger.kernel.org # v6.18, v6.19 > Fixes: 216c12047571 ("gpio: swnode: allow referencing GPIO chips by firmware nodes") > Link: https://lore.kernel.org/all/aYkdKfP5fg6iywgr@jekhomev/ > Acked-by: Andy Shevchenko > Signed-off-by: Bartosz Golaszewski > --- > Changes in v2: > - check if gdev_node and gdev_node->name are not NULL before trying to > match the label (Hans & Dan) > - use the right link > - collect tags > > drivers/gpio/gpiolib-swnode.c | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/drivers/gpio/gpiolib-swnode.c b/drivers/gpio/gpiolib-swnode.c > index 21478b45c127d..0d7f3f09a0b4b 100644 > --- a/drivers/gpio/gpiolib-swnode.c > +++ b/drivers/gpio/gpiolib-swnode.c > @@ -42,6 +42,25 @@ static struct gpio_device *swnode_get_gpio_device(struct fwnode_handle *fwnode) > > fwnode_lookup: > gdev = gpio_device_find_by_fwnode(fwnode); By the way, should we extend gpio_device_find_by_fwnode() to use both primary and secondary nodes? Thanks. -- Dmitry