[PATCH net v2] bnge: fix reserving resources from FW

[PATCH net v2] bnge: fix reserving resources from FW

[Vikas Gupta]

HWRM_FUNC_CFG is used to reserve resources, whereas HWRM_FUNC_QCFG is
intended for querying resource information from the firmware.
Since __bnge_hwrm_reserve_pf_rings() reserves resources for a specific
PF, the command type should be HWRM_FUNC_CFG.

Changes in v2:
  -Fix commit message.

Fixes: 627c67f038d2 ("bng_en: Add resource management support")
Signed-off-by: Vikas Gupta <vikas.gupta@broadcom.com>
Reviewed-by: Bhargava Chenna Marreddy <bhargava.marreddy@broadcom.com>
---
 drivers/net/ethernet/broadcom/bnge/bnge_hwrm_lib.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_hwrm_lib.c b/drivers/net/ethernet/broadcom/bnge/bnge_hwrm_lib.c
index 84c90a957719..91a4ef9e3150 100644
--- a/drivers/net/ethernet/broadcom/bnge/bnge_hwrm_lib.c
+++ b/drivers/net/ethernet/broadcom/bnge/bnge_hwrm_lib.c
@@ -442,7 +442,7 @@ __bnge_hwrm_reserve_pf_rings(struct bnge_dev *bd, struct bnge_hw_rings *hwr)
 	struct hwrm_func_cfg_input *req;
 	u32 enables = 0;
 
-	if (bnge_hwrm_req_init(bd, req, HWRM_FUNC_QCFG))
+	if (bnge_hwrm_req_init(bd, req, HWRM_FUNC_CFG))
 		return NULL;
 
 	req->fid = cpu_to_le16(0xffff);
-- 
2.47.1

Re: [PATCH net v2] bnge: fix reserving resources from FW

[Simon Horman]

On Wed, Feb 18, 2026 at 10:57:55AM +0530, Vikas Gupta wrote:
> HWRM_FUNC_CFG is used to reserve resources, whereas HWRM_FUNC_QCFG is
> intended for querying resource information from the firmware.
> Since __bnge_hwrm_reserve_pf_rings() reserves resources for a specific
> PF, the command type should be HWRM_FUNC_CFG.
> 
> Changes in v2:
>   -Fix commit message.
> 
> Fixes: 627c67f038d2 ("bng_en: Add resource management support")
> Signed-off-by: Vikas Gupta <vikas.gupta@broadcom.com>
> Reviewed-by: Bhargava Chenna Marreddy <bhargava.marreddy@broadcom.com>

Thanks for the update.

Reviewed-by: Simon Horman <horms@kernel.org>

Re: [PATCH net v2] bnge: fix reserving resources from FW

[Jakub Kicinski]

On Wed, 18 Feb 2026 10:57:55 +0530 Vikas Gupta wrote:
> Changes in v2:
>   -Fix commit message.

No need to repost but for the future changelog should go under the ---
separator.

I assume you have a lot more code to upstream to this driver, so please
follow the community guidelines:
https://docs.kernel.org/maintainer/feature-and-driver-maintainers.html
specifically:

  Maintainers must be subscribed and follow the appropriate
  subsystem-wide mailing list. Either by subscribing to the whole 
  list or using more modern, selective setup like lei.

If you spend 15min every day reading some ML submissions you'd avoid
all these silly mistakes.

Re: [PATCH net v2] bnge: fix reserving resources from FW

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Wed, 18 Feb 2026 10:57:55 +0530 you wrote:
> HWRM_FUNC_CFG is used to reserve resources, whereas HWRM_FUNC_QCFG is
> intended for querying resource information from the firmware.
> Since __bnge_hwrm_reserve_pf_rings() reserves resources for a specific
> PF, the command type should be HWRM_FUNC_CFG.
> 
> Changes in v2:
>   -Fix commit message.
> 
> [...]

Here is the summary with links:
  - [net,v2] bnge: fix reserving resources from FW
    https://git.kernel.org/netdev/net/c/604530085b2e

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html