* [PATCH] media: i2c: max9286: normalize return value of gpio_get
@ 2026-02-18 20:53 Dmitry Torokhov
2026-02-19 10:42 ` Ricardo Ribalda
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Dmitry Torokhov @ 2026-02-18 20:53 UTC (permalink / raw)
To: Jacopo Mondi
Cc: Jacopo Mondi, Kieran Bingham, Laurent Pinchart,
Niklas Söderlund, Mauro Carvalho Chehab, Linus Walleij,
Bartosz Golaszewski, Hans Verkuil, Sakari Ailus, Ricardo Ribalda,
linux-media, linux-kernel, linux-gpio
The GPIO get callback is expected to return 0 or 1 (or a negative error
code). Ensure that the value returned by max9286_gpiochip_get() is
normalized to the [0, 1] range.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/media/i2c/max9286.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c
index e6e214f8294b..ac0712ce1e65 100644
--- a/drivers/media/i2c/max9286.c
+++ b/drivers/media/i2c/max9286.c
@@ -1205,7 +1205,7 @@ static int max9286_gpiochip_get(struct gpio_chip *chip, unsigned int offset)
{
struct max9286_priv *priv = gpiochip_get_data(chip);
- return priv->gpio_state & BIT(offset);
+ return !!(priv->gpio_state & BIT(offset));
}
static int max9286_register_gpio(struct max9286_priv *priv)
--
2.53.0.335.g19a08e0c02-goog
--
Dmitry
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] media: i2c: max9286: normalize return value of gpio_get
2026-02-18 20:53 [PATCH] media: i2c: max9286: normalize return value of gpio_get Dmitry Torokhov
@ 2026-02-19 10:42 ` Ricardo Ribalda
2026-02-19 10:48 ` Bartosz Golaszewski
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Ricardo Ribalda @ 2026-02-19 10:42 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Jacopo Mondi, Kieran Bingham, Laurent Pinchart,
Niklas Söderlund, Mauro Carvalho Chehab, Linus Walleij,
Bartosz Golaszewski, Hans Verkuil, Sakari Ailus, linux-media,
linux-kernel, linux-gpio
On Wed, 18 Feb 2026 at 21:53, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
>
> The GPIO get callback is expected to return 0 or 1 (or a negative error
> code). Ensure that the value returned by max9286_gpiochip_get() is
> normalized to the [0, 1] range.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-by: Ricardo Ribalda <ribalda@chromium.org>
> ---
> drivers/media/i2c/max9286.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c
> index e6e214f8294b..ac0712ce1e65 100644
> --- a/drivers/media/i2c/max9286.c
> +++ b/drivers/media/i2c/max9286.c
> @@ -1205,7 +1205,7 @@ static int max9286_gpiochip_get(struct gpio_chip *chip, unsigned int offset)
> {
> struct max9286_priv *priv = gpiochip_get_data(chip);
>
> - return priv->gpio_state & BIT(offset);
> + return !!(priv->gpio_state & BIT(offset));
> }
>
> static int max9286_register_gpio(struct max9286_priv *priv)
> --
> 2.53.0.335.g19a08e0c02-goog
>
>
> --
> Dmitry
--
Ricardo Ribalda
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] media: i2c: max9286: normalize return value of gpio_get
2026-02-18 20:53 [PATCH] media: i2c: max9286: normalize return value of gpio_get Dmitry Torokhov
2026-02-19 10:42 ` Ricardo Ribalda
@ 2026-02-19 10:48 ` Bartosz Golaszewski
2026-02-19 11:58 ` Kieran Bingham
2026-02-19 17:32 ` Linus Walleij
3 siblings, 0 replies; 5+ messages in thread
From: Bartosz Golaszewski @ 2026-02-19 10:48 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Jacopo Mondi, Kieran Bingham, Laurent Pinchart,
Niklas Söderlund, Mauro Carvalho Chehab, Linus Walleij,
Bartosz Golaszewski, Hans Verkuil, Sakari Ailus, Ricardo Ribalda,
linux-media, linux-kernel, linux-gpio
On Wed, 18 Feb 2026 21:53:48 +0100, Dmitry Torokhov
<dmitry.torokhov@gmail.com> said:
> The GPIO get callback is expected to return 0 or 1 (or a negative error
> code). Ensure that the value returned by max9286_gpiochip_get() is
> normalized to the [0, 1] range.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
> drivers/media/i2c/max9286.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c
> index e6e214f8294b..ac0712ce1e65 100644
> --- a/drivers/media/i2c/max9286.c
> +++ b/drivers/media/i2c/max9286.c
> @@ -1205,7 +1205,7 @@ static int max9286_gpiochip_get(struct gpio_chip *chip, unsigned int offset)
> {
> struct max9286_priv *priv = gpiochip_get_data(chip);
>
> - return priv->gpio_state & BIT(offset);
> + return !!(priv->gpio_state & BIT(offset));
> }
>
> static int max9286_register_gpio(struct max9286_priv *priv)
> --
> 2.53.0.335.g19a08e0c02-goog
>
>
> --
> Dmitry
>
Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] media: i2c: max9286: normalize return value of gpio_get
2026-02-18 20:53 [PATCH] media: i2c: max9286: normalize return value of gpio_get Dmitry Torokhov
2026-02-19 10:42 ` Ricardo Ribalda
2026-02-19 10:48 ` Bartosz Golaszewski
@ 2026-02-19 11:58 ` Kieran Bingham
2026-02-19 17:32 ` Linus Walleij
3 siblings, 0 replies; 5+ messages in thread
From: Kieran Bingham @ 2026-02-19 11:58 UTC (permalink / raw)
To: Dmitry Torokhov, Jacopo Mondi
Cc: Jacopo Mondi, Laurent Pinchart, Niklas Söderlund,
Mauro Carvalho Chehab, Linus Walleij, Bartosz Golaszewski,
Hans Verkuil, Sakari Ailus, Ricardo Ribalda, linux-media,
linux-kernel, linux-gpio
Quoting Dmitry Torokhov (2026-02-18 20:53:48)
> The GPIO get callback is expected to return 0 or 1 (or a negative error
> code). Ensure that the value returned by max9286_gpiochip_get() is
> normalized to the [0, 1] range.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
> drivers/media/i2c/max9286.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c
> index e6e214f8294b..ac0712ce1e65 100644
> --- a/drivers/media/i2c/max9286.c
> +++ b/drivers/media/i2c/max9286.c
> @@ -1205,7 +1205,7 @@ static int max9286_gpiochip_get(struct gpio_chip *chip, unsigned int offset)
> {
> struct max9286_priv *priv = gpiochip_get_data(chip);
>
> - return priv->gpio_state & BIT(offset);
> + return !!(priv->gpio_state & BIT(offset));
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> }
>
> static int max9286_register_gpio(struct max9286_priv *priv)
> --
> 2.53.0.335.g19a08e0c02-goog
>
>
> --
> Dmitry
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] media: i2c: max9286: normalize return value of gpio_get
2026-02-18 20:53 [PATCH] media: i2c: max9286: normalize return value of gpio_get Dmitry Torokhov
` (2 preceding siblings ...)
2026-02-19 11:58 ` Kieran Bingham
@ 2026-02-19 17:32 ` Linus Walleij
3 siblings, 0 replies; 5+ messages in thread
From: Linus Walleij @ 2026-02-19 17:32 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Jacopo Mondi, Kieran Bingham, Laurent Pinchart,
Niklas Söderlund, Mauro Carvalho Chehab, Bartosz Golaszewski,
Hans Verkuil, Sakari Ailus, Ricardo Ribalda, linux-media,
linux-kernel, linux-gpio
On Wed, Feb 18, 2026 at 9:53 PM Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
> The GPIO get callback is expected to return 0 or 1 (or a negative error
> code). Ensure that the value returned by max9286_gpiochip_get() is
> normalized to the [0, 1] range.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-by: Linus Walleij <linusw@kernel.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-02-19 17:33 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-18 20:53 [PATCH] media: i2c: max9286: normalize return value of gpio_get Dmitry Torokhov
2026-02-19 10:42 ` Ricardo Ribalda
2026-02-19 10:48 ` Bartosz Golaszewski
2026-02-19 11:58 ` Kieran Bingham
2026-02-19 17:32 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox