From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f48.google.com (mail-dl1-f48.google.com [74.125.82.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB06831BCB7 for ; Wed, 18 Feb 2026 21:02:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771448573; cv=none; b=pBIUpwXs36M+tme+k4eL8U9g5Ub5/fb6391nvIOme65gUGUOdYIPOx6joxq558Ap9ekkHcQddi2EhwaKpeG1rSCNBIu5RXqvsc9RhcCua0t/8SFTQyGoxQIaCc09CGC2YOdqQDANLZGzGOZSOd4Gmy02n0PyaXlzB8PjCGs9geM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771448573; c=relaxed/simple; bh=MZZPzKZy1Fp+fNvLtQVklivSgxRjmtz/6SJAY6gzE4w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OtHC6rG5O0VJbvnDxCJQqJiqqz49AYps5vbRS0iMZ7eNI5eyscfcv/sSBmQtHGJPns0AIY3CD9afJsvbbuiZkOqrJRBlnPB/BEqYX1N2y/k2Im0WyBdgUKrTfcWuQAmrLZ4C3aGurUpTvpnTn4m0NdZq1bYOcyL9zPpN+QBf96o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=J/zmjEpz; arc=none smtp.client-ip=74.125.82.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="J/zmjEpz" Received: by mail-dl1-f48.google.com with SMTP id a92af1059eb24-127423bea4bso485573c88.0 for ; Wed, 18 Feb 2026 13:02:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771448571; x=1772053371; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=iXwStKZfCkBmMw4vSjlUuygcZKcf6mhO/tsFkerTSTM=; b=J/zmjEpztRBSJV5PSZ2uZJpW/mw0ooPlWICndLFQu7bHefT3Hl34uWffN/3xfeZOG6 kDTjNv4J9Fs0SpQAioerXHQEz0GNarFDw5TaJ4N6Se/dulai/BOIRjMmpjaYa1pi+6hY JIl+ZQ+bTopZ4DrwDLmid1jcTQzS5t4dBXVEz75CQDy9hf8hpp/DNF162x62zfGouwVo zSj7UI/xDcAll0dXhS+pjgnwq8Ocy+TitCxeLlAMxfoINXB84Fa2urpFqATPMEUZf/mq HHTbT9Mvz3aDR71ntH1NWPCqqx8oZEE+YODQPbrI64MUvl47SX/KFX4gCTAJhdpKnMv6 nIMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771448571; x=1772053371; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iXwStKZfCkBmMw4vSjlUuygcZKcf6mhO/tsFkerTSTM=; b=xSG++ShGaNajRu+ZPvbBaoODrxWMvnJmPqsnR50CnKKxey+hJ1dK7Mf8J6LEf5BWHi 2hi+0Fkulu+mqALhQsxGeem5xbP5nBd4Pf2CzSzHte44JY849PhWm9pHnH7jINky/7GZ jlpn/vkl+BdViVEZkdu0Mb2m0tDU88HGXnatpU/KGXH5ISpX4hVdBdj5oi+xQXfIBMSO 6aiEk/2PfefxIfnSijmaXJ84u+yTE60G6PpfhuWsmOQ4OXMA/cVmrbf8hxyq+POuZ/CC 771Y7DM7CPWrQzqaSadWV8LCHiYknK9WZ60eq35YmIvObIeTXpzyxQVq3aXx8CS9ma5S mxww== X-Forwarded-Encrypted: i=1; AJvYcCVRo6Y5MBU9cM767lQJtTfZaDIhrhu7iZemIo3lUb3VNNWpOH8lHKMQYw6n+OAEiPaToPXjlJwxKBOWNDY=@vger.kernel.org X-Gm-Message-State: AOJu0YwW3ceDWcPYAcfNIT1r7PLo0zTV6VLjIBKzEVr2lcduhaIBNTIr pYuNB/veRSw77Nl+ctnowrQwXz4IVCfJHhFGOiMOKaa9WyzoYiwxfx1C X-Gm-Gg: AZuq6aKT4jr8FY3w+kpWDXTgjYi+wpqIPQqtbQG5GUyfU/W1y68OIUrTGxiClIK8GfG 3+HrFB3YEhnj+J65TpwHpYFddSLPm5KYTNm0EYQrZg/n92qdqXcoLLG03mbrv8mza1kWo2qgVrT savDGeYy+RTTWzyNqYJGW3dyrfVyhBLXgXeETBTsHiFssJPgf4p/+65NJ1QN+lN5xi49qyqmVbG HlOokFZncsbzp3eQdPEw2qF+Ukl0DTxFCQmZyiuuLy4k3mRhMjny4XCNFoS9dUwKH9p366S3A/R WOJwyGOfFi6ZHo6zsapZLbyoKDcW7TP7JrNUIyxTsqjZO1XvBMAPiCYYyIhHtF7Z9lkmxIygmoH AAyT0hAlcOuHBpQzgeg2b+0Tr+IKft/72cP8WHOPbC2WAk3IABaIqvqfE5iwCEF8HGlBkePQL4J e5nAYXX/g021Qp195D9RZaJfprYsBjHz9LI27dxK6uAyJv7HoLV9XmI/240+0yW/ei X-Received: by 2002:a05:7022:6285:b0:11b:9386:825c with SMTP id a92af1059eb24-1273ae66b03mr9158229c88.41.1771448570753; Wed, 18 Feb 2026 13:02:50 -0800 (PST) Received: from google.com ([2a00:79e0:2ebe:8:265b:f5ad:9e03:677e]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2bacb6782e5sm19215556eec.29.2026.02.18.13.02.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Feb 2026 13:02:50 -0800 (PST) Date: Wed, 18 Feb 2026 13:02:47 -0800 From: Dmitry Torokhov To: Bartosz Golaszewski Cc: Linus Walleij , Marek Vasut , Thomas Richard , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH 1/7] gpio: bd9571mwv: normalize return value of gpio_get Message-ID: References: <20260218190657.2974723-1-dmitry.torokhov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed, Feb 18, 2026 at 09:23:38PM +0100, Bartosz Golaszewski wrote: > On Wed, Feb 18, 2026 at 8:07 PM Dmitry Torokhov > wrote: > > > > The GPIO get callback is expected to return 0 or 1 (or a negative error > > code). Ensure that the value returned by bd9571mwv_gpio_get() is > > normalized to the [0, 1] range. > > > > Signed-off-by: Dmitry Torokhov > > --- > > drivers/gpio/gpio-bd9571mwv.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpio/gpio-bd9571mwv.c b/drivers/gpio/gpio-bd9571mwv.c > > index 7c95bb36511e..cc5b1746f2fe 100644 > > --- a/drivers/gpio/gpio-bd9571mwv.c > > +++ b/drivers/gpio/gpio-bd9571mwv.c > > @@ -69,7 +69,7 @@ static int bd9571mwv_gpio_get(struct gpio_chip *chip, unsigned int offset) > > if (ret < 0) > > return ret; > > > > - return val & BIT(offset); > > + return !!(val & BIT(offset)); > > } > > > > static int bd9571mwv_gpio_set(struct gpio_chip *chip, unsigned int offset, > > -- > > 2.53.0.335.g19a08e0c02-goog > > > > Thanks for doing this. I think it would make sense to backport them > all the way to commit 86ef402d805d ("gpiolib: sanitize the return > value of gpio_chip::get()")? I do not think this is workable since the breakages are not limited to dtivers/gpio/. I would recommend reverting the patch for stable, but keeping it for 7.0 and working with maintainers outside of drivers/gpio to make sure the fixes land in this release cycle. This way you will ensure that new drivers are not adding tech debt while not punishing existing users who might not be running latest and greatest kernel. Thanks. -- Dmitry