From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f49.google.com (mail-ot1-f49.google.com [209.85.210.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22A1D148850 for ; Thu, 19 Feb 2026 04:38:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771475912; cv=none; b=q3f7VWULTuuWHi09FWUCLoLutRf9ylY7PKThVxurh3gTvNjxpFU/UDYAZAKUmje/fCQPtTr2do28umc7zNYqGxMLiiWSdFbrZr/EV5iGSl3yMwZE51u8ByXfDQ1Ic0uUBbAn0zKP5tpJomBSkg0mb9h68LMxsbq5KpKwLMye+78= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771475912; c=relaxed/simple; bh=/Fzizo3yusJUP2ovcIzutUgUDMEZwEl6ZxV/ZpzhJ+M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=r9AwcMP9kYX0kwwI9FZH+gK3L2eTZaUiFGgxgOGpNLX+cxzk117HVk8LYE/LurxdjIH3npM4DfjZOkzCiAwbPBop8EP31OEeBeVHkT5B/IwEgDKlPnZnab5tVnNSFZT/nurhDgTW9m72HI1EIvsWzD2YW1POxtw29KOIAlyVaXo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DiMb6Bww; arc=none smtp.client-ip=209.85.210.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DiMb6Bww" Received: by mail-ot1-f49.google.com with SMTP id 46e09a7af769-7d4c9537f90so421366a34.0 for ; Wed, 18 Feb 2026 20:38:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771475910; x=1772080710; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=CDio/2GMwWj+Msmfl056o9NycQmZ+bkeO+GVRZjCPFo=; b=DiMb6Bww2r8o5v5qg3sTBO9kWfgAipICNp/skeEUIqAmE9FC49s4lnUUDxqiTohN2j 29hjowlHWPbeGOjHnV+CZWt+JHPbkdjE9Xh2zkAS+GwNMSBdZ90rviqMe/YqymCT3GMZ 8Y4ndelhW9Xypa1uEc68x55GDjzs5xtIeUN9KBxkeoaik4LUtYb2YEZ/2X1zWYuV8RTn 0DlvbctMpFkPbvZEGWNP4JCdRSJP7NJ2XHpyWBTRDhTOxjenN9lxqAVA8fpb8cOqYCUZ 5V/EqPPPTgzfVtxmyCHSrPtpi4PVuQfha75R+/18N7rEz3Ztmf3V0vDSmAcR7dLGIcJN 77Vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771475910; x=1772080710; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CDio/2GMwWj+Msmfl056o9NycQmZ+bkeO+GVRZjCPFo=; b=dLLn1Ifzj/yffA0yJRGx9RuSrj/cleiByV0L9Jfn7rkCl78gr4xIEsY2tOHwNmvoGh sELak28k4eqarvqKOt/NcMFkuWotvEqZqajo28KAK5nz41dHmT82JRsCUovIyPLuoLlK m0aXXyg6MZwUYM6pvbyxOXZLDrPa/NVFq64muTlyND/44NpohjB5C9l1K1UvNVraAsfW 1hK0eHkkccv7rtGOjP+KrYoOASL+4VOVi53lf1vR9OCCzObqFomZy0y5yRmrpVdmHjn2 xdFq+7JtQJwX6KVRX85ELdPsNBKcD3BwC47OGXqfcnRkGWWrdBzpKUq97XEB3z1/1QLf vmXw== X-Forwarded-Encrypted: i=1; AJvYcCUNVbycygrRkMjX07rv+Au4DaOPbQv0QDdENx3bxgxXooGX09KaAJbrpoH+ixPVNAsw+qInlJmN0GtTTlI=@vger.kernel.org X-Gm-Message-State: AOJu0YwAuW8x9v44iGZLB8/Z9QRAXh8slso/WCwPcog2mVVr1UkC/5sd Unozucp1T7Wd9z0NM1rAIc3AXuXbU2xLn+bk1jW81xRLF+yRRzVzy8b+7lBkkw== X-Gm-Gg: AZuq6aKolG99ed2T2RA7dpZlDLYp/mybmxFi77Bwf0fbiZJKKaPw8jQGfpNzuIfNBuY dm9SqtzvZNXCt4NiAQvupelAE67gJSSUMSrevBi+sN5AjfNaMHckxQ41TeCBN8ZcJktrpHfqOF0 F3rZh/OwywGtRx5c9pQUXc73RSL0QOZhoOBwYxc902np2Kv2bCBz7oXQUo5aq5bnqQehB7BIkNj ud0gsIlSTFAHKBgcP4kpSjk7CGdt3LaBZBrTBpokf6NgbCAS/BKb/0PA9zwb3oAZAhqgLHYl/oq Rc2qGhHH412d6TKJsJIlbFgPPs70yHQdlp7Viim7vmCkHZq6uWILgR5vLv+pqKUSloKylDZQhUT ZtKS+LLPqZC1pWkb3RMwwbfUehzYZx3w7k2tjwKZK6MLOWciYHYIyit6cfwQPdhu0B/ZPgmQTZ5 JuROHAd6ZCRQuIEKMQ5dObJh2LNlvZJn9T28Os4y/4L6Pb+ZiPz1Q9EIlHzh6kZQDU X-Received: by 2002:a05:7022:2397:b0:11b:c1ab:bdd4 with SMTP id a92af1059eb24-12759a87feemr1681224c88.38.1771469133294; Wed, 18 Feb 2026 18:45:33 -0800 (PST) Received: from google.com ([2a00:79e0:2ebe:8:265b:f5ad:9e03:677e]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12742cc9376sm23655808c88.16.2026.02.18.18.45.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Feb 2026 18:45:32 -0800 (PST) Date: Wed, 18 Feb 2026 18:45:30 -0800 From: Dmitry Torokhov To: Liam Mitchell Cc: Henrik Rydberg , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] bcm5974: recover from failed mode switch Message-ID: References: <20260213-bcm5974-reset-v2-1-1837851336b0@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260213-bcm5974-reset-v2-1-1837851336b0@gmail.com> Hi Liam, On Fri, Feb 13, 2026 at 10:25:40AM +0100, Liam Mitchell wrote: > Mode switches sent before control response are ignored. > On receiving unknown 8-byte packets, assume that mode switch was ignored > and reset by switching to normal mode, waiting then switching back to > wellspring mode. > > --- > This patch addresses an issue where the bcm5974 driver switches modes > before the device is ready, resulting in an unresponsive trackpad and > "bcm5974: bad trackpad package, length: 8" repeated in logs. > > Discussion of issue in the thread: > https://lore.kernel.org/linux-input/CAOQ1CL4+DP1TuLAGNsz5GdFBTHvnTg=5q=Dr2Z1OQc6RXydSYA@mail.gmail.com/ > > This fix is conservative, avoiding changing existing mode-switch > behavior because I cannot test all variations of hardware. > > On receiving an unknown 8-byte packet, we assume the device is not in > wellspring mode and schedule an asynchronous mode reset. > > Signed-off-by: Liam Mitchell > Link: https://lore.kernel.org/linux-input/CAOQ1CL4+DP1TuLAGNsz5GdFBTHvnTg=5q=Dr2Z1OQc6RXydSYA@mail.gmail.com/ > --- > Changes in v2: > - mutex_lock -> guard(mutex) > - dprintk -> dev_err > - msleep -> fsleep > - removed 0 init > - cancel_work_sync -> disable_delayed_work_sync > - work_struct -> delayed_work My apologies, I did not mean to request switch to delayed work, just to switch to disable_work_sync(). I fixed this up on my side and applied. Thanks. -- Dmitry